Code quality improvements for the Memory panel [devtools/devtools-frontend : main]

0 views
Skip to first unread message

Nikolay Vitkov (Gerrit)

unread,
Mar 23, 2026, 11:49:18 AM (18 hours ago) Mar 23
to Simon Zünd, devtools-rev...@chromium.org
Attention needed from Simon Zünd

Nikolay Vitkov voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Simon Zünd
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: If8434349d63d118bda717327fb1c07ce5e1d6669
Gerrit-Change-Number: 7693137
Gerrit-PatchSet: 1
Gerrit-Owner: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-Reviewer: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-Reviewer: Simon Zünd <szu...@chromium.org>
Gerrit-Attention: Simon Zünd <szu...@chromium.org>
Gerrit-Comment-Date: Mon, 23 Mar 2026 15:49:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Simon Zünd (Gerrit)

unread,
1:08 AM (4 hours ago) 1:08 AM
to Nikolay Vitkov, devtools-rev...@chromium.org
Attention needed from Nikolay Vitkov

Simon Zünd voted and added 1 comment

Votes added by Simon Zünd

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Simon Zünd . resolved

Nice, thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Nikolay Vitkov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: If8434349d63d118bda717327fb1c07ce5e1d6669
Gerrit-Change-Number: 7693137
Gerrit-PatchSet: 1
Gerrit-Owner: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-Reviewer: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-Reviewer: Simon Zünd <szu...@chromium.org>
Gerrit-Attention: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-Comment-Date: Tue, 24 Mar 2026 05:08:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Devtools-frontend LUCI CQ (Gerrit)

unread,
1:41 AM (4 hours ago) 1:41 AM
to Nikolay Vitkov, Simon Zünd, devtools-rev...@chromium.org

Devtools-frontend LUCI CQ submitted the change

Change information

Commit message:
Code quality improvements for the Memory panel

While working on extracting the parsing I noticed small changes
that we can make.
Bug: 454624251
Change-Id: If8434349d63d118bda717327fb1c07ce5e1d6669
Auto-Submit: Nikolay Vitkov <nvi...@chromium.org>
Reviewed-by: Simon Zünd <szu...@chromium.org>
Commit-Queue: Simon Zünd <szu...@chromium.org>
Files:
  • M front_end/panels/profiler/HeapDetachedElementsView.ts
  • M front_end/panels/profiler/HeapProfileView.ts
  • M front_end/panels/profiler/HeapSnapshotView.ts
  • M front_end/panels/profiler/ProfileHeader.ts
  • M front_end/ui/legacy/UIUtils.ts
Change size: M
Delta: 5 files changed, 47 insertions(+), 48 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Simon Zünd
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: If8434349d63d118bda717327fb1c07ce5e1d6669
Gerrit-Change-Number: 7693137
Gerrit-PatchSet: 2
Gerrit-Owner: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-Reviewer: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages