Better handle near hueless colors. [devtools/devtools-frontend : main]

0 views
Skip to first unread message

Philip Pfaffe (Gerrit)

unread,
Apr 13, 2026, 2:42:27 AM (2 days ago) Apr 13
to Yulun Zeng, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Yulun Zeng

Philip Pfaffe voted and added 1 comment

Votes added by Philip Pfaffe

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Philip Pfaffe . resolved

Nice, thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Yulun Zeng
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I61443c2bf3a39149d8336f922a70d7039e396abc
Gerrit-Change-Number: 7750005
Gerrit-PatchSet: 1
Gerrit-Owner: Yulun Zeng <yul...@chromium.org>
Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>
Gerrit-Reviewer: Yulun Zeng <yul...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Yulun Zeng <yul...@chromium.org>
Gerrit-Comment-Date: Mon, 13 Apr 2026 06:42:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Yulun Zeng (Gerrit)

unread,
Apr 13, 2026, 1:41:28 PM (2 days ago) Apr 13
to Philip Pfaffe, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org

Yulun Zeng voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: devtools/devtools-frontend
    Gerrit-Branch: main
    Gerrit-Change-Id: I61443c2bf3a39149d8336f922a70d7039e396abc
    Gerrit-Change-Number: 7750005
    Gerrit-PatchSet: 2
    Gerrit-Owner: Yulun Zeng <yul...@chromium.org>
    Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>
    Gerrit-Reviewer: Yulun Zeng <yul...@chromium.org>
    Gerrit-Comment-Date: Mon, 13 Apr 2026 17:41:24 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

    unread,
    Apr 13, 2026, 2:58:03 PM (2 days ago) Apr 13
    to Yulun Zeng, Philip Pfaffe, devtools-rev...@chromium.org

    devtools-fro...@luci-project-accounts.iam.gserviceaccount.com submitted the change

    Unreviewed changes

    1 is the latest approved patch-set.
    No files were changed between the latest approved patch-set and the submitted one.

    Change information

    Commit message:
    Better handle near hueless colors.
    Bug: 489704048
    Change-Id: I61443c2bf3a39149d8336f922a70d7039e396abc
    Reviewed-by: Philip Pfaffe <pfa...@chromium.org>
    Commit-Queue: Yulun Zeng <yul...@chromium.org>
    Files:
    • M front_end/core/common/Color.ts
    • M front_end/ui/legacy/components/color_picker/Spectrum.test.ts
    Change size: S
    Delta: 2 files changed, 27 insertions(+), 2 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Philip Pfaffe
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: devtools/devtools-frontend
    Gerrit-Branch: main
    Gerrit-Change-Id: I61443c2bf3a39149d8336f922a70d7039e396abc
    Gerrit-Change-Number: 7750005
    Gerrit-PatchSet: 3
    Gerrit-Owner: Yulun Zeng <yul...@chromium.org>
    Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>
    Gerrit-Reviewer: Yulun Zeng <yul...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages