Set .mjs file Mime type to be text/javascript [chromium/src : main]
0 views
Skip to first unread message
Jayson Chen (Gerrit)
Jul 2, 2024, 2:07:24 PMJul 2
to Alex Rudenko, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org
Attention needed from Alex Rudenko
Jayson Chen added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Jayson Chen . resolved
Hi Alex, I have a small fix for devtools http handler about the mime type for .mjs file serving from devtools debugging port. Could you take a look when you get a chance? Thank you!
Related details
Attention is currently required from:
- Alex Rudenko
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
Jul 3, 2024, 1:57:26 AMJul 3
to Jayson Chen, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org
Attention needed from Jayson Chen
Alex Rudenko voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Jayson Chen
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jayson Chen (Gerrit)
Jul 3, 2024, 2:24:03 AMJul 3
to Danil Somsikov, Alex Rudenko, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org
Attention needed from Danil Somsikov
Jayson Chen added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Jayson Chen . resolved
Hi Danil, could you help me take a look at this quick CL? This patch is to fix devtools debugging port serving .mjs file as text/plain mime type. Thank you!
Related details
Attention is currently required from:
- Danil Somsikov
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Danil Somsikov (Gerrit)
Jul 3, 2024, 2:25:07 AMJul 3
to Jayson Chen, Alex Rudenko, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org
Attention needed from Jayson Chen
Danil Somsikov voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Jayson Chen
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jayson Chen (Gerrit)
Jul 3, 2024, 2:42:19 AMJul 3
to Danil Somsikov, Alex Rudenko, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org
Jayson Chen voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 3, 2024, 2:54:38 AMJul 3
to Jayson Chen, Danil Somsikov, Alex Rudenko, chromium...@chromium.org, devtools...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Set .mjs file Mime type to be text/javascript
https://imgur.com/a/L8s84ex
In DevTools, when .mjs file is being served from the backend debugging port, its mime type will be marked as text/plain and become unusable in devtools-frontend due to HTML specification. This patch helps the backend http handler recognize .mjs file.
Bug: 350627117
Change-Id: I2f3f764a5119b02f0662fb0dd2b529b5c5380342
Commit-Queue: Jayson Chen <jayso...@microsoft.com>
Reviewed-by: Alex Rudenko <alexr...@chromium.org>
Reviewed-by: Danil Somsikov <d...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1322608}
Files:
- M content/browser/devtools/devtools_http_handler.cc
Change size: XS
Delta: 1 file changed, 2 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alex Rudenko, +1 by Danil Somsikov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages