Normalize URLs first before checking for UNC path [devtools/devtools-frontend : chromium/7559]

0 views
Skip to first unread message

Mathias Bynens (Gerrit)

unread,
2:48 AM (21 hours ago) 2:48 AM
to Benedikt Meurer, Simon Zünd, AyeAye, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Benedikt Meurer

Mathias Bynens voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Benedikt Meurer
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: chromium/7559
Gerrit-Change-Id: I8d7c602657e45a8110e695ab4a91b9c4ef6f62aa
Gerrit-Change-Number: 7320487
Gerrit-PatchSet: 1
Gerrit-Owner: Benedikt Meurer <bme...@chromium.org>
Gerrit-Reviewer: Benedikt Meurer <bme...@chromium.org>
Gerrit-Reviewer: Mathias Bynens <mat...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-CC: Simon Zünd <szu...@chromium.org>
Gerrit-Attention: Benedikt Meurer <bme...@chromium.org>
Gerrit-Comment-Date: Tue, 30 Dec 2025 07:48:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Devtools-frontend LUCI CQ (Gerrit)

unread,
3:09 AM (20 hours ago) 3:09 AM
to Benedikt Meurer, Simon Zünd, Mathias Bynens, AyeAye, devtools-rev...@chromium.org

Devtools-frontend LUCI CQ submitted the change

Change information

Commit message:
Normalize URLs first before checking for UNC path

R=bme...@chromium.org

Fixed: 468027781
Change-Id: I8d7c602657e45a8110e695ab4a91b9c4ef6f62aa
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7255782
Commit-Queue: Benedikt Meurer <bme...@chromium.org>
Reviewed-by: Benedikt Meurer <bme...@chromium.org>
Auto-Submit: Simon Zünd <szu...@chromium.org>
(cherry picked from commit 8564770a55f6a9d1e18bb202ef4ba01d618bb2ac)
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7320487
Auto-Submit: Benedikt Meurer <bme...@chromium.org>
Commit-Queue: Mathias Bynens <mat...@chromium.org>
Reviewed-by: Mathias Bynens <mat...@chromium.org>
Files:
  • M front_end/core/host/ResourceLoader.ts
  • M front_end/core/sdk/PageResourceLoader.test.ts
Change size: S
Delta: 2 files changed, 15 insertions(+), 1 deletion(-)
Branch: refs/heads/chromium/7559
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Mathias Bynens
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: chromium/7559
Gerrit-Change-Id: I8d7c602657e45a8110e695ab4a91b9c4ef6f62aa
Gerrit-Change-Number: 7320487
Gerrit-PatchSet: 2
Gerrit-Owner: Benedikt Meurer <bme...@chromium.org>
Gerrit-Reviewer: Benedikt Meurer <bme...@chromium.org>
Gerrit-Reviewer: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Mathias Bynens <mat...@chromium.org>
Gerrit-CC: Simon Zünd <szu...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages