[views-ax] Migration of kProtected state in textfield with testcases [chromium/src : main]

0 views
Skip to first unread message

Gaurav Kumar (Gerrit)

unread,
Jul 2, 2024, 8:08:39 AM (21 hours ago) Jul 2
to Daniel Cheng, Dirk Schulze, Enterprise Policy Reviews, Nate Chapin, Nancy Wang, Hiroki Nakagawa, Stephen Chenney, AyeAye, Chromium Metrics Reviews, (Julie)Jeongeun Kim, Kevin Babbitt, Benjamin Beaudry, Javier Contreras, Vinay Singh, Ragvesh Sharma, Chromium LUCI CQ, chromium...@chromium.org, James Su, alancutter...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, blink-reviews-p...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, dibyapal+wa...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dominickn+wat...@chromium.org, dominickn+...@chromium.org, dominickn+watch-...@chromium.org, drott+bl...@chromium.org, druber...@chromium.org, ericwillige...@chromium.org, extension...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, gavinp...@chromium.org, horo+...@chromium.org, jeffreycohen+watc...@chromium.org, jsbell+ser...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mgiuca...@chromium.org, michaelpg+wa...@chromium.org, mxcai+watch...@chromium.org, nwoked...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, tgupta...@chromium.org, tsergea...@chromium.org, vakh+safe_br...@chromium.org, webap...@microsoft.com, xinghui...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org, devtools...@chromium.org, abigailbk...@google.com, alemat...@chromium.org, anastas...@google.com, asvitkine...@chromium.org, blink-...@chromium.org, blundell+...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, chrome-intell...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, fuzzin...@chromium.org, gcasto+w...@chromium.org, hirokisa...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jdonnel...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kyungjunle...@google.com, mahmad...@chromium.org, marq+...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, oshima...@chromium.org, rouslan+au...@chromium.org, rrsilva+wat...@google.com, shannc...@chromium.org, vasilii+watchlis...@chromium.org, yuzo+...@chromium.org, keithle...@chromium.org, nona+...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Attention needed from Benjamin Beaudry, Javier Contreras and Ragvesh Sharma

Gaurav Kumar added 1 comment

Patchset-level comments
File-level comment, Patchset 11:
Javier Contreras . resolved

Could you rebase the change on top of the intro CL? It looks like it was not rebased correctly and in this CL you are also doing the introduction.

Gaurav Kumar

Acknowledged

Open in Gerrit

Related details

Attention is currently required from:
  • Benjamin Beaudry
  • Javier Contreras
  • Ragvesh Sharma
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I38522d966b1dd1c626866cab7b23350861b24a9d
Gerrit-Change-Number: 5645514
Gerrit-PatchSet: 13
Gerrit-Owner: Gaurav Kumar <gaur...@microsoft.com>
Gerrit-Reviewer: Benjamin Beaudry <benjamin...@microsoft.com>
Gerrit-Reviewer: Gaurav Kumar <gaur...@microsoft.com>
Gerrit-Reviewer: Javier Contreras <javi...@microsoft.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Daniel Cheng <dch...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Nancy Wang <nancyl...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Ragvesh Sharma <rags...@microsoft.com>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-CC: Vinay Singh <vinay...@microsoft.com>
Gerrit-Attention: Javier Contreras <javi...@microsoft.com>
Gerrit-Attention: Benjamin Beaudry <benjamin...@microsoft.com>
Gerrit-Attention: Ragvesh Sharma <rags...@microsoft.com>
Gerrit-Comment-Date: Tue, 02 Jul 2024 12:08:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Javier Contreras <javi...@microsoft.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Javier Contreras (Gerrit)

unread,
Jul 2, 2024, 12:58:40 PM (17 hours ago) Jul 2
to Gaurav Kumar, Jacques Newman, Daniel Cheng, Dirk Schulze, Enterprise Policy Reviews, Nate Chapin, Nancy Wang, Hiroki Nakagawa, Stephen Chenney, AyeAye, Chromium Metrics Reviews, (Julie)Jeongeun Kim, Kevin Babbitt, Benjamin Beaudry, Vinay Singh, Ragvesh Sharma, Chromium LUCI CQ, chromium...@chromium.org, James Su, alancutter...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, blink-reviews-p...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, dibyapal+wa...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dominickn+wat...@chromium.org, dominickn+...@chromium.org, dominickn+watch-...@chromium.org, drott+bl...@chromium.org, druber...@chromium.org, ericwillige...@chromium.org, extension...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, gavinp...@chromium.org, horo+...@chromium.org, jeffreycohen+watc...@chromium.org, jsbell+ser...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mgiuca...@chromium.org, michaelpg+wa...@chromium.org, mxcai+watch...@chromium.org, nwoked...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, tgupta...@chromium.org, tsergea...@chromium.org, vakh+safe_br...@chromium.org, webap...@microsoft.com, xinghui...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org, devtools...@chromium.org, abigailbk...@google.com, alemat...@chromium.org, anastas...@google.com, asvitkine...@chromium.org, blink-...@chromium.org, blundell+...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, chrome-intell...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, fuzzin...@chromium.org, gcasto+w...@chromium.org, hirokisa...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jdonnel...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kyungjunle...@google.com, mahmad...@chromium.org, marq+...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, oshima...@chromium.org, rouslan+au...@chromium.org, rrsilva+wat...@google.com, shannc...@chromium.org, vasilii+watchlis...@chromium.org, yuzo+...@chromium.org, keithle...@chromium.org, nona+...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Attention needed from Benjamin Beaudry, Gaurav Kumar, Jacques Newman and Ragvesh Sharma

Javier Contreras voted and added 1 comment

Votes added by Javier Contreras

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 13 (Latest):
Javier Contreras . resolved

LGTM adding Jacques for review since Ben is OOO

Open in Gerrit

Related details

Attention is currently required from:
  • Benjamin Beaudry
  • Gaurav Kumar
  • Jacques Newman
  • Ragvesh Sharma
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I38522d966b1dd1c626866cab7b23350861b24a9d
Gerrit-Change-Number: 5645514
Gerrit-PatchSet: 13
Gerrit-Owner: Gaurav Kumar <gaur...@microsoft.com>
Gerrit-Reviewer: Benjamin Beaudry <benjamin...@microsoft.com>
Gerrit-Reviewer: Gaurav Kumar <gaur...@microsoft.com>
Gerrit-Reviewer: Jacques Newman <jane...@microsoft.com>
Gerrit-Reviewer: Javier Contreras <javi...@microsoft.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Daniel Cheng <dch...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Nancy Wang <nancyl...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Ragvesh Sharma <rags...@microsoft.com>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-CC: Vinay Singh <vinay...@microsoft.com>
Gerrit-Attention: Jacques Newman <jane...@microsoft.com>
Gerrit-Attention: Benjamin Beaudry <benjamin...@microsoft.com>
Gerrit-Attention: Gaurav Kumar <gaur...@microsoft.com>
Gerrit-Attention: Ragvesh Sharma <rags...@microsoft.com>
Gerrit-Comment-Date: Tue, 02 Jul 2024 16:58:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Javier Contreras (Gerrit)

unread,
Jul 2, 2024, 12:59:16 PM (17 hours ago) Jul 2
to Gaurav Kumar, Jacques Newman, Daniel Cheng, Dirk Schulze, Enterprise Policy Reviews, Nate Chapin, Nancy Wang, Hiroki Nakagawa, Stephen Chenney, AyeAye, Chromium Metrics Reviews, (Julie)Jeongeun Kim, Kevin Babbitt, Benjamin Beaudry, Vinay Singh, Ragvesh Sharma, Chromium LUCI CQ, chromium...@chromium.org, James Su, alancutter...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, blink-reviews-p...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, dibyapal+wa...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dominickn+wat...@chromium.org, dominickn+...@chromium.org, dominickn+watch-...@chromium.org, drott+bl...@chromium.org, druber...@chromium.org, ericwillige...@chromium.org, extension...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, gavinp...@chromium.org, horo+...@chromium.org, jeffreycohen+watc...@chromium.org, jsbell+ser...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mgiuca...@chromium.org, michaelpg+wa...@chromium.org, mxcai+watch...@chromium.org, nwoked...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, tgupta...@chromium.org, tsergea...@chromium.org, vakh+safe_br...@chromium.org, webap...@microsoft.com, xinghui...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org, devtools...@chromium.org, abigailbk...@google.com, alemat...@chromium.org, anastas...@google.com, asvitkine...@chromium.org, blink-...@chromium.org, blundell+...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, chrome-intell...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, fuzzin...@chromium.org, gcasto+w...@chromium.org, hirokisa...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jdonnel...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kyungjunle...@google.com, mahmad...@chromium.org, marq+...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, oshima...@chromium.org, rouslan+au...@chromium.org, rrsilva+wat...@google.com, shannc...@chromium.org, vasilii+watchlis...@chromium.org, yuzo+...@chromium.org, keithle...@chromium.org, nona+...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Attention needed from Benjamin Beaudry, Gaurav Kumar, Jacques Newman and Ragvesh Sharma

Javier Contreras added 1 comment

Commit Message
Line 7, Patchset 13 (Latest):[views-ax] Migration of kProtected state in textfield with testcases
Javier Contreras . unresolved

nit: not needed

Open in Gerrit

Related details

Attention is currently required from:
  • Benjamin Beaudry
  • Gaurav Kumar
  • Jacques Newman
  • Ragvesh Sharma
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Gerrit-Comment-Date: Tue, 02 Jul 2024 16:59:01 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Jacques Newman (Gerrit)

    unread,
    Jul 2, 2024, 7:09:55 PM (10 hours ago) Jul 2
    to Gaurav Kumar, Javier Contreras, Daniel Cheng, Dirk Schulze, Enterprise Policy Reviews, Nate Chapin, Nancy Wang, Hiroki Nakagawa, Stephen Chenney, AyeAye, Chromium Metrics Reviews, (Julie)Jeongeun Kim, Kevin Babbitt, Benjamin Beaudry, Vinay Singh, Ragvesh Sharma, Chromium LUCI CQ, chromium...@chromium.org, James Su, alancutter...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, blink-reviews-p...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, dibyapal+wa...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dominickn+wat...@chromium.org, dominickn+...@chromium.org, dominickn+watch-...@chromium.org, drott+bl...@chromium.org, druber...@chromium.org, ericwillige...@chromium.org, extension...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, gavinp...@chromium.org, horo+...@chromium.org, jeffreycohen+watc...@chromium.org, jsbell+ser...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mgiuca...@chromium.org, michaelpg+wa...@chromium.org, mxcai+watch...@chromium.org, nwoked...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, tgupta...@chromium.org, tsergea...@chromium.org, vakh+safe_br...@chromium.org, webap...@microsoft.com, xinghui...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org, devtools...@chromium.org, abigailbk...@google.com, alemat...@chromium.org, anastas...@google.com, asvitkine...@chromium.org, blink-...@chromium.org, blundell+...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, chrome-intell...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, fuzzin...@chromium.org, gcasto+w...@chromium.org, hirokisa...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jdonnel...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kyungjunle...@google.com, mahmad...@chromium.org, marq+...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, oshima...@chromium.org, rouslan+au...@chromium.org, rrsilva+wat...@google.com, shannc...@chromium.org, vasilii+watchlis...@chromium.org, yuzo+...@chromium.org, keithle...@chromium.org, nona+...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
    Attention needed from Benjamin Beaudry, Gaurav Kumar and Ragvesh Sharma

    Jacques Newman voted and added 1 comment

    Votes added by Jacques Newman

    Code-Review+1

    1 comment

    Patchset-level comments
    Jacques Newman . resolved

    lgtm with Javier's comment addressed.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Benjamin Beaudry
    • Gaurav Kumar
    • Ragvesh Sharma
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Review
    Gerrit-Attention: Benjamin Beaudry <benjamin...@microsoft.com>
    Gerrit-Attention: Gaurav Kumar <gaur...@microsoft.com>
    Gerrit-Attention: Ragvesh Sharma <rags...@microsoft.com>
    Gerrit-Comment-Date: Tue, 02 Jul 2024 23:09:42 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages