ComputedStyleModel: add dispose() method [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Jack Franklin (Gerrit)
8:02 AM (7 hours ago) 8:02 AM
to Devtools-frontend LUCI CQ, Philip Pfaffe, devtools-rev...@chromium.org
Attention needed from Philip Pfaffe
Jack Franklin voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Philip Pfaffe
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jack Franklin (Gerrit)
8:03 AM (7 hours ago) 8:03 AM
to Devtools-frontend LUCI CQ, Philip Pfaffe, devtools-rev...@chromium.org
Attention needed from Philip Pfaffe
Jack Franklin added 1 comment![]( "Open in Gerrit")
File front_end/models/computed_style/ComputedStyleModel.ts
Line 23, Patchset 1 (Latest):
if (node) {
// Call the explicit setter to trigger the setup and event binding.
this.node = node;
}Jack Franklin . unresolved
without this, if you construct and pass a node, the updateModel doesn't run.
Related details
Attention is currently required from:
- Philip Pfaffe
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Philip Pfaffe (Gerrit)
8:05 AM (7 hours ago) 8:05 AM
to Jack Franklin, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Jack Franklin
Philip Pfaffe voted![]( "Open in Gerrit")
Attention is currently required from:
- Jack Franklin
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jack Franklin (Gerrit)
8:05 AM (7 hours ago) 8:05 AM
to Philip Pfaffe, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Philip Pfaffe
Jack Franklin voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jack Franklin
| Commit-Queue | +2 |
1 comment
File front_end/models/computed_style/ComputedStyleModel.ts
Line 23, Patchset 1 (Latest):
if (node) {
// Call the explicit setter to trigger the setup and event binding.
this.node = node;
}Jack Franklin . resolved
without this, if you construct and pass a node, the updateModel doesn't run.
Attention is currently required from:
- Philip Pfaffe
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Philip Pfaffe (Gerrit)
9:28 AM (5 hours ago) 9:28 AM
to Jack Franklin, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Jack Franklin
Philip Pfaffe voted and added 1 comment![]( "Open in Gerrit")
Votes added by Philip Pfaffe
| Code-Review | +1 |
1 comment
File front_end/panels/elements/StylesSidebarPane.test.ts
Line 27, Patchset 2 (Latest):
const {node: createdNode} = createStubbedDomNodeWithModels({nodeId: 1});Philip Pfaffe . unresolved
You can write `({node} = createStubbedDomNodeWithModels({nodeId: 1}))`
Related details
Attention is currently required from:
- Jack Franklin
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jack Franklin (Gerrit)
9:52 AM (5 hours ago) 9:52 AM
to Philip Pfaffe, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Jack Franklin voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jack Franklin
| Auto-Submit | +1 |
| Commit-Queue | +2 |
1 comment
File front_end/panels/elements/StylesSidebarPane.test.ts
Line 27, Patchset 2:
const {node: createdNode} = createStubbedDomNodeWithModels({nodeId: 1});Philip Pfaffe . resolved
You can write `({node} = createStubbedDomNodeWithModels({nodeId: 1}))`
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devtools-frontend LUCI CQ (Gerrit)
10:25 AM (4 hours ago) 10:25 AM
to Jack Franklin, Philip Pfaffe, devtools-rev...@chromium.org
Devtools-frontend LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: front_end/panels/elements/StylesSidebarPane.test.ts
Insertions: 1, Deletions: 2.
@@ -24,8 +24,7 @@
describe('StylesSidebarPane', () => {
let node: SDK.DOMModel.DOMNode;
beforeEach(() => {
- const {node: createdNode} = createStubbedDomNodeWithModels({nodeId: 1});
- node = createdNode;
+ ({node} = createStubbedDomNodeWithModels({nodeId: 1}));
UI.Context.Context.instance().setFlavor(SDK.DOMModel.DOMNode, node);
});
```
Change information
Commit message:
ComputedStyleModel: add dispose() method
This allows callers who need to use the model to look up styles just
once to do that, and then dispose the method, preventing excessive
listeners being bound and then held onto.
R=pfa...@chromium.org
Bug: 475845628
Change-Id: Iae6528787465eee70e17d35e0876189ae3d5e41c
Reviewed-by: Philip Pfaffe <pfa...@chromium.org>
Auto-Submit: Jack Franklin <jacktf...@chromium.org>
Commit-Queue: Jack Franklin <jacktf...@chromium.org>
Files:
- M front_end/models/computed_style/ComputedStyleModel.ts
- M front_end/panels/elements/ComputedStyleWidget.test.ts
- M front_end/panels/elements/StylePropertyHighlighter.test.ts
- M front_end/panels/elements/StylesSidebarPane.test.ts
- M front_end/testing/StyleHelpers.ts
Change size: M
Delta: 5 files changed, 64 insertions(+), 35 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Philip Pfaffe
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages