[sensors] Migrate location validation to native HTML [devtools/devtools-frontend : main]

0 views

Skip to first unread message

Simon Zünd (Gerrit)

unread,

3:12 AM (2 hours ago) 3:12 AM

to Devtools-frontend LUCI CQ, Danil Somsikov, devtools-rev...@chromium.org

Attention needed from Danil Somsikov

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

Danil Somsikov

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Danil Somsikov (Gerrit)

unread,

5:29 AM (9 minutes ago) 5:29 AM

to Simon Zünd, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org

Attention needed from Simon Zünd

Danil Somsikov added 1 comment

File front_end/panels/sensors/SensorsView.ts

Line 502, Patchset 2 (Latest): input.value = prevValue;

Danil Somsikov . unresolved

This changes the behavior for out-of-bounds values with the arrow keys, right? Previously, the input would display the invalid value and be styled as an error. Now, it reverts to the previous valid value. Is this intentional?