Takashi Toyoshima (Gerrit)

unread,

May 21, 2026, 12:57:54 AM (4 days ago) May 21

to Ken Okada, Jonathan Lee, Chromium LUCI CQ, Hiroshige Hayashizaki, Hiroki Nakagawa, Danil Somsikov, android-bu...@system.gserviceaccount.com, prerendering-reviews, devtools...@chromium.org, Code Review Nudger, chromium...@chromium.org, Anthi Orfanou, Chromium Metrics Reviews, blink-re...@chromium.org, gavin...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org, tburkar...@chromium.org, loading...@chromium.org, asvitkine...@chromium.org

Attention needed from Danil Somsikov, Hiroki Nakagawa, Hiroshige Hayashizaki, Jonathan Lee and Ken Okada

Takashi Toyoshima voted and added 1 comment

Votes added by Takashi Toyoshima

Code-Review

+1

1 comment

Commit Message

Line 10, Patchset 3 (Latest):

Takashi Toyoshima . unresolved

Can you clarify what has changed from the past attempt?

Open in Gerrit

Related details

Attention is currently required from:

Danil Somsikov
Hiroki Nakagawa
Hiroshige Hayashizaki
Jonathan Lee
Ken Okada

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

SLSA Policy Verification Service (Gerrit)

unread,

May 21, 2026, 3:35:50 AM (4 days ago) May 21

to Ken Okada, Takashi Toyoshima, Jonathan Lee, Chromium LUCI CQ, Hiroshige Hayashizaki, Hiroki Nakagawa, Danil Somsikov, android-bu...@system.gserviceaccount.com, prerendering-reviews, devtools...@chromium.org, Code Review Nudger, chromium...@chromium.org, Anthi Orfanou, Chromium Metrics Reviews, blink-re...@chromium.org, gavin...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org, tburkar...@chromium.org, loading...@chromium.org, asvitkine...@chromium.org

Attention needed from Danil Somsikov, Hiroki Nakagawa, Hiroshige Hayashizaki, Jonathan Lee, Ken Okada and Takashi Toyoshima

SLSA Policy Verification Service voted SLSA-Policy-Verified+1

SLSA-Policy-Verified

+1

Open in Gerrit

Related details

Attention is currently required from:

Danil Somsikov
Hiroki Nakagawa
Hiroshige Hayashizaki
Jonathan Lee
Ken Okada

Takashi Toyoshima

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Ken Okada (Gerrit)

unread,

May 21, 2026, 12:04:13 PM (3 days ago) May 21

to AyeAye Python Dispatcher, SLSA Policy Verification Service, Takashi Toyoshima, Jonathan Lee, Chromium LUCI CQ, Hiroshige Hayashizaki, Hiroki Nakagawa, Danil Somsikov, android-bu...@system.gserviceaccount.com, prerendering-reviews, devtools...@chromium.org, Code Review Nudger, chromium...@chromium.org, Anthi Orfanou, Chromium Metrics Reviews, blink-re...@chromium.org, gavin...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org, tburkar...@chromium.org, loading...@chromium.org, asvitkine...@chromium.org

Attention needed from Danil Somsikov, Hiroki Nakagawa, Hiroshige Hayashizaki, Jonathan Lee and Takashi Toyoshima

Ken Okada added 2 comments

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Ken Okada . unresolved

Could you take a look? The diffs are almost only `GTEST_SKIP()`.

https://chromium-review.git.corp.google.com/c/chromium/src/+/7862661/1..6

Commit Message

Line 10, Patchset 3:

Takashi Toyoshima . resolved

Can you clarify what has changed from the past attempt?

Ken Okada

You can see the diff: https://chromium-review.git.corp.google.com/c/chromium/src/+/7862661/1..6

Open in Gerrit

Related details

Attention is currently required from:

Danil Somsikov
Hiroki Nakagawa
Hiroshige Hayashizaki
Jonathan Lee

Takashi Toyoshima

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Jonathan Lee (Gerrit)

unread,

May 21, 2026, 12:36:29 PM (3 days ago) May 21

to Ken Okada, AyeAye Python Dispatcher, SLSA Policy Verification Service, Takashi Toyoshima, Chromium LUCI CQ, Hiroshige Hayashizaki, Hiroki Nakagawa, Danil Somsikov, android-bu...@system.gserviceaccount.com, prerendering-reviews, devtools...@chromium.org, Code Review Nudger, chromium...@chromium.org, Anthi Orfanou, Chromium Metrics Reviews, blink-re...@chromium.org, gavin...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org, tburkar...@chromium.org, loading...@chromium.org, asvitkine...@chromium.org

Attention needed from Danil Somsikov, Hiroki Nakagawa, Hiroshige Hayashizaki, Ken Okada and Takashi Toyoshima

Jonathan Lee voted and added 1 comment

Votes added by Jonathan Lee

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 7 (Latest):

Jonathan Lee . resolved

`web_tests/` LGTM

Open in Gerrit

Related details

Attention is currently required from:

Danil Somsikov
Hiroki Nakagawa
Hiroshige Hayashizaki

Ken Okada
Takashi Toyoshima

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Takashi Toyoshima (Gerrit)

unread,

May 22, 2026, 2:01:00 AM (3 days ago) May 22

to Ken Okada, Jonathan Lee, AyeAye Python Dispatcher, SLSA Policy Verification Service, Chromium LUCI CQ, Hiroshige Hayashizaki, Hiroki Nakagawa, Danil Somsikov, android-bu...@system.gserviceaccount.com, prerendering-reviews, devtools...@chromium.org, Code Review Nudger, chromium...@chromium.org, Anthi Orfanou, Chromium Metrics Reviews, blink-re...@chromium.org, gavin...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org, tburkar...@chromium.org, loading...@chromium.org, asvitkine...@chromium.org

Attention needed from Danil Somsikov, Hiroki Nakagawa, Hiroshige Hayashizaki and Ken Okada

Takashi Toyoshima voted and added 2 comments

Votes added by Takashi Toyoshima

Code-Review

+1

2 comments

File content/browser/preloading/prefetch/prefetch_status.h

Line 26, Patchset 8 (Latest):// LINT.IfChange

Takashi Toyoshima . unresolved

Some of prerender's IFTTTs are early users, and their format is outdated. Can we add a reference name here so that XML side IFTTT can refer this block.

File tools/metrics/histograms/enums.xml

Line 23204, Patchset 8 (Latest):

<enum name="PrefetchProxyPrefetchStatus">
  <int value="0" label="DEPRECATED Prefetch Used, No Probe">
    The interceptor used a prefetch. (Deprecated M115)
  </int>
  <int value="1" label="DEPRECATED Prefetch Used, Probe Success">
    The interceptor used a prefetch after successfully probing the origin.
    (Deprecated M110)
  </int>
  <int value="2" label="Prefetch Not Used, Probe Failed">
    The interceptor was not able to use an available prefetch because the origin
    probe failed.
  </int>
  <int value="3" label="Prefetch Not Started">
    The url was eligible to be prefetched, but the network request was never
    made.
  </int>
  <int value="4" label="DEPRECATED Prefetch Not Eligible: Google Domain">
    The url was not eligible to be prefetched because it is a Google-owned
    domain. (Deprecated M115)
  </int>
  <int value="5" label="Prefetch Not Eligible: User Has Cookies">
    The url was not eligible to be prefetched because the user had cookies for
    that origin.
  </int>
  <int value="6" label="Prefetch Not Eligible: User Has ServiceWorker">
    The url was not eligible to be prefetched because there was a registered
    service worker for that origin.
  </int>
  <int value="7" label="Prefetch Not Eligible: Scheme Is Not HTTPS">
    The url was not eligible to be prefetched because its scheme was not
    https://.
  </int>
  <int value="8" label="DEPRECATED Prefetch Not Eligible: Host Is IP Address">
    The url was not eligible to be prefetched because its host was an IP
    address. (Deprecated M100)
  </int>
  <int value="9" label="Prefetch Not Eligible: Non-Default Storage Partition">
    The url was not eligible to be prefetched because it uses a non-default
    storage partition.
  </int>
  <int value="10" label="Prefetch Not Finished In Time">
    The network request was cancelled before it finished. This happens when
    there is a new navigation.
  </int>
  <int value="11" label="Prefetch Failed: Net Error">
    The prefetch failed because of a net error.
  </int>
  <int value="12" label="Prefetch Failed: Non 2XX Status">
    The prefetch failed with a non-2XX HTTP response code.
  </int>
  <int value="13" label="Prefetch Failed: Not HTML">
    The prefetch's Content-Type header was not html.
  </int>
  <int value="14" label="Prefetch Successful">
    The prefetch finished successfully but was never used.
  </int>
  <int value="15" label="DEPRECATED Navigated To Link Not On SRP">
    The navigation off of the Google SRP was to a url that was not on the SRP.
    (Deprecated M115)
  </int>
  <int value="16"
      label="DEPRECATED Prefetch Used, No Probe, Did NoStatePrefetch">
    The url was prefetched and No State Prerendered and committed without a
    probe to the origin. (Deprecated M115)
  </int>
  <int value="17"
      label="DEPRECATED Prefetch Used, Probe Success, Did NoStatePrefetch">
    The url was prefetched and No State Prerendered and committed with a
    successful probe to the origin. (Deprecated M115)
  </int>
  <int value="18"
      label="DEPRECATED Prefetch Not Used, Probe Failed, Did NoStatePrefetch">
    The url was prefetched and No State Prerendered but the origin probe failed
    and the prefetch was not used. (Deprecated M115)
  </int>
  <int value="19"
      label="DEPRECATED Prefetch Used, No Probe, NoStatePrefetch Attempt
             Denied">
    The url was prefetched but was not No State Prerendered despite attempting
    to do so and committed without a probe to the origin. (Deprecated M115)
  </int>
  <int value="20"
      label="DEPRECATED Prefetch Used, Probe Success, NoStatePrefetch Attempt
             Denied">
    The url was prefetched but was not No State Prerendered despite attempting
    to do so and committed with a successful probe to the origin. (Deprecated
    M115)
  </int>
  <int value="21"
      label="DEPRECATED Prefetch Not Used, Probe Failed, NoStatePrefetch
             Attempt Denied">
    The url was prefetched but was not No State Prerendered despite attempting
    to do so, and the origin probe failed and the prefetch was not used.
    (Deprecated M115)
  </int>
  <int value="22"
      label="DEPRECATED Prefetch Used, No Probe, NoStatePrefetch Not Started">
    The url was prefetched and eligible for NoStatePrerender but wasn't started
    and committed without a probe to the origin. (Deprecated M115)
  </int>
  <int value="23"
      label="DEPRECATED Prefetch Used, Probe Success, NoStatePrefetch Not
             Started">
    The url was prefetched and eligible for NoStatePrerender but wasn't started
    and committed with a successful probe to the origin. (Deprecated M115)
  </int>
  <int value="24"
      label="DEPRECATED Prefetch Not Used, Probe Failed, NoStatePrefetch Not
             Started">
    The url was prefetched and eligible for NoStatePrerender but wasn't started
    and the origin probe failed and the prefetch was not used. (Deprecated M115)
  </int>
  <int value="25" label="DEPRECATED Subresource throttled">
    (Deprecated M115)
  </int>
  <int value="26" label="DEPRECATED Prediction position not eligible">
    (Deprecated M115)
  </int>
  <int value="27" label="Prefetch Not Eligible: Retry-After not elasped"/>
  <int value="28" label="Connecting to the prefetch proxy previously failed"/>
  <int value="29" label="Decoy request"/>
  <int value="30" label="Stale prefetch"/>
  <int value="31" label="DEPRECATED Stale prefetch with NSP">
    (Deprecated M115)
  </int>
  <int value="32" label="DEPRECATED Stale prefetch, NSP attempt denied">
    (Deprecated M115)
  </int>
  <int value="33" label="DEPRECATED Stale prefetch, NSP not started">
    (Deprecated M115)
  </int>
  <int value="34" label="Prefetch Not Used, Cookies Changed">
    The url was prefetched but not used, because cookies were added to the URL
    at some point after the initial eligibility check.
  </int>
  <int value="35" label="DEPRECATED Prefetch failed, redirects disabled">
    The url was prefetched and was redirected; however, redirects were disabled,
    so the prefetch failed. (Deprecated M113)
  </int>
  <int value="36" label="Prefetch Not Eligible: Host Is Non Unique">
    The url was not eligible to be prefetched because its host was not unique
    (e.g., a non publicly routable IP address or a hostname which is not
    registry-controlled) but the prefetch was to be proxied.
  </int>
  <int value="37" label="Prefetch Not Eligible: Data Saver Enabled">
    The url was not eligible to be prefected because the user requested that the
    browser use less data.
  </int>
  <int value="38" label="Prefetch Not Eligible: Existing Proxy">
    The URL is not eligible to be prefetched, because in the default network
    context it is configured to use a proxy server.
  </int>
  <int value="39"
      label="DEPRECATED Prefetch Not Eligible: Browser Context Off The Record">
    The URL is not eligible to be prefetched because in the browser is in
    Incognito or Guest mode. (Deprecated M128)
  </int>
  <int value="40" label="Prefetch Heldback">
    The URL is eligible but heldback because it belongs to the Holdback group.
  </int>
  <int value="41" label="DEPRECATED Prefetch Allowed">
    The URL is eligible and not in the Holdback group (allowed to prefetch).
    (Deprecated M134)
  </int>
  <int value="42" label="Prefetch Response Used">
    The URL is prefetched successfully and the repsonse is used for the next
    navigation.
  </int>
  <int value="43" label="Prefetch Failed: Invalid Redirect">
    The prefetch was redirected and failed, because the redirect was invalid.
  </int>
  <int value="44" label="Prefetch Failed: Ineligible Redirect">
    The prefetch was redirect and failed, because the redirect URL was not
    eligible to be prefetched.
  </int>
  <int value="45" label="DEPRECATED Prefetch Failed: Per Page Limit Exceeded">
    The prefetch was eligible but rejected due to the per-page limit exceeded.
    (Deprecated M130)
  </int>
  <int value="46"
      label="Prefetch Not Eligible: Same-site Cross-origin Prefetch Required
             Proxy">
    The prefetch needed to fetch a same-site cross-origin URL and required the
    use of the prefetch proxy. These prefetches are blocked since the default
    network context cannot be configured to use the prefetch proxy for a single
    prefetch request. See crbug.com/1439986.
  </int>
  <int value="47" label="Prefetch Not Eligible: Battery Saver Enabled">
    The prefetch was not made because the `Battery Saver` setting was enabled.
  </int>
  <int value="48" label="Prefetch Not Eligible: Preloading Disabled">
    The prefetch was not made because preloading was disabled.
  </int>
  <int value="50" label="Prefetch Evicted: Candidate Removed">
    The prefetch was evicted to make room for a newer prefetch because the
    corresponding SpeculationCandidate was removed.
  </int>
  <int value="51" label="Prefetch Evicted: Old Prefetch">
    The prefetch was evicted to make room for a newer prefetch beacuse it was
    old.
  </int>
  <int value="52"
      label="Prefetch Not Eligible: Redirected from ServiceWorker-controlled
             URL">
    The prefetch was cancelled because it was redirected from a
    ServiceWorker-controlled URL.
  </int>
  <int value="53"
      label="Prefetch Not Eligible: Redirected to ServiceWorker-controlled URL">
    The prefetch was cancelled because it was redirected to a
    ServiceWorker-controlled URL.
  </int>
  <int value="54"
      label="Prefetch Not Eligible: User Has ServiceWorker with no fetch
             handler">
    The url was not eligible to be prefetched because there was a registered
    service worker with no fetch handler.
  </int>
  <int value="55" label="Prefetch Evicted: BrowsingData Removed">
    The prefetch was evicted because a user removed browsing data.
  </int>
  <int value="56" label="PrefetchCancelledOnUserNavigation">
    The prefetch canceled to prevent network congestion with user-initiated
    navigation.
  </int>
</enum>

Takashi Toyoshima . unresolved

Can you add a reversed IFTTT here to point the .h side declaration?

Open in Gerrit

Related details

Attention is currently required from:

Danil Somsikov
Hiroki Nakagawa
Hiroshige Hayashizaki
Ken Okada

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Hiroki Nakagawa (Gerrit)

unread,

May 22, 2026, 2:41:59 AM (3 days ago) May 22

to Ken Okada, Takashi Toyoshima, Jonathan Lee, AyeAye Python Dispatcher, SLSA Policy Verification Service, Chromium LUCI CQ, Hiroshige Hayashizaki, Danil Somsikov, android-bu...@system.gserviceaccount.com, prerendering-reviews, devtools...@chromium.org, Code Review Nudger, chromium...@chromium.org, Anthi Orfanou, Chromium Metrics Reviews, blink-re...@chromium.org, gavin...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org, tburkar...@chromium.org, loading...@chromium.org, asvitkine...@chromium.org

Attention needed from Danil Somsikov, Hiroshige Hayashizaki and Ken Okada

Hiroki Nakagawa voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Danil Somsikov
Hiroshige Hayashizaki
Ken Okada

satisfied_requirement

unsatisfied_requirement

open

diffy

Ken Okada (Gerrit)

unread,

May 22, 2026, 3:02:18 PM (2 days ago) May 22

to Hiroki Nakagawa, Takashi Toyoshima, Jonathan Lee, AyeAye Python Dispatcher, SLSA Policy Verification Service, Chromium LUCI CQ, Hiroshige Hayashizaki, Danil Somsikov, android-bu...@system.gserviceaccount.com, prerendering-reviews, devtools...@chromium.org, Code Review Nudger, chromium...@chromium.org, Anthi Orfanou, Chromium Metrics Reviews, blink-re...@chromium.org, gavin...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org, tburkar...@chromium.org, loading...@chromium.org, asvitkine...@chromium.org

Attention needed from Danil Somsikov and Hiroshige Hayashizaki

Ken Okada added 2 comments

File content/browser/preloading/prefetch/prefetch_status.h

Line 26, Patchset 8 (Latest):// LINT.IfChange

Takashi Toyoshima . resolved

Some of prerender's IFTTTs are early users, and their format is outdated. Can we add a reference name here so that XML side IFTTT can refer this block.

Ken Okada

Don in https://chromium-review.git.corp.google.com/c/chromium/src/+/7866607

File tools/metrics/histograms/enums.xml

Takashi Toyoshima . resolved

Can you add a reversed IFTTT here to point the .h side declaration?

Ken Okada

Done

Open in Gerrit

Related details

Attention is currently required from:

Danil Somsikov
Hiroshige Hayashizaki

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

Reland "Prefetch: Cancel unrelated prefetch" [chromium/src : main]

Takashi Toyoshima (Gerrit)

Takashi Toyoshima voted and added 1 comment

Votes added by Takashi Toyoshima

1 comment

Related details

SLSA Policy Verification Service (Gerrit)

SLSA Policy Verification Service voted SLSA-Policy-Verified+1

Related details

Ken Okada (Gerrit)

Ken Okada added 2 comments

Related details

Jonathan Lee (Gerrit)

Jonathan Lee voted and added 1 comment

Votes added by Jonathan Lee

1 comment

Related details

Takashi Toyoshima (Gerrit)

Takashi Toyoshima voted and added 2 comments

Votes added by Takashi Toyoshima

2 comments

Related details

Hiroki Nakagawa (Gerrit)

Hiroki Nakagawa voted Code-Review+1

Related details

Ken Okada (Gerrit)

Ken Okada added 2 comments

Related details