[M144] Handle permission element issues in devtools frontend [devtools/devtools-frontend : main]

0 views
Skip to first unread message

Andy Paicu (Gerrit)

unread,
Nov 27, 2025, 5:31:56 PM (4 days ago) Nov 27
to Danil Somsikov, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Danil Somsikov

Andy Paicu added 1 comment

Patchset-level comments
File-level comment, Patchset 10 (Latest):
Andy Paicu . resolved

Hi Danil, PTAL.

Open in Gerrit

Related details

Attention is currently required from:
  • Danil Somsikov
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I88e3116ce5e3727bda2f2c11da7dc18af670b5ce
Gerrit-Change-Number: 7208884
Gerrit-PatchSet: 10
Gerrit-Owner: Andy Paicu <andy...@chromium.org>
Gerrit-Reviewer: Andy Paicu <andy...@chromium.org>
Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Danil Somsikov <d...@chromium.org>
Gerrit-Comment-Date: Thu, 27 Nov 2025 22:31:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Simon Zünd (Gerrit)

unread,
2:13 AM (7 hours ago) 2:13 AM
to Andy Paicu, Danil Somsikov, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Andy Paicu

Simon Zünd voted and added 2 comments

Votes added by Simon Zünd

Code-Review+1

2 comments

Patchset-level comments
File-level comment, Patchset 11 (Latest):
Simon Zünd . resolved

lgtm

For the issue descriptions: Would it make sense to have DevRel or a technical writer have a look at these? Generally issue descriptions should be actionable. That is, they should contain some advice on how to fix things, not just that something is wrong.

File front_end/models/issues_manager/descriptions/permissionElementActivationDisabled.md
Line 1, Patchset 11 (Latest):# Activation Disabled
Simon Zünd . unresolved

nit: We generally use sentence case, not title case in headings/texts. Please update issue descriptions accordingly.

Open in Gerrit

Related details

Attention is currently required from:
  • Andy Paicu
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I88e3116ce5e3727bda2f2c11da7dc18af670b5ce
Gerrit-Change-Number: 7208884
Gerrit-PatchSet: 11
Gerrit-Owner: Andy Paicu <andy...@chromium.org>
Gerrit-Reviewer: Andy Paicu <andy...@chromium.org>
Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>
Gerrit-Reviewer: Simon Zünd <szu...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Andy Paicu <andy...@chromium.org>
Gerrit-Comment-Date: Mon, 01 Dec 2025 07:13:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Andy Paicu (Gerrit)

unread,
5:45 AM (3 hours ago) 5:45 AM
to Simon Zünd, Danil Somsikov, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Simon Zünd

Andy Paicu added 3 comments

Patchset-level comments
Simon Zünd . resolved

lgtm

For the issue descriptions: Would it make sense to have DevRel or a technical writer have a look at these? Generally issue descriptions should be actionable. That is, they should contain some advice on how to fix things, not just that something is wrong.

Andy Paicu

I have changed the descriptions to be actionable. These were previously console logs so they mostly got ported exactly as they are.

I don't (personally) think that additional input is necessary but I also don't know much about dev tools issues and the difference between them and console logs in terms of how devs perceive them.

File-level comment, Patchset 13 (Latest):
Andy Paicu . resolved

CL lost +1s, PTAL

File front_end/models/issues_manager/descriptions/permissionElementActivationDisabled.md
Line 1, Patchset 11:# Activation Disabled
Simon Zünd . resolved

nit: We generally use sentence case, not title case in headings/texts. Please update issue descriptions accordingly.

Andy Paicu

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Simon Zünd
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: devtools/devtools-frontend
    Gerrit-Branch: main
    Gerrit-Change-Id: I88e3116ce5e3727bda2f2c11da7dc18af670b5ce
    Gerrit-Change-Number: 7208884
    Gerrit-PatchSet: 13
    Gerrit-Owner: Andy Paicu <andy...@chromium.org>
    Gerrit-Reviewer: Andy Paicu <andy...@chromium.org>
    Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>
    Gerrit-Reviewer: Simon Zünd <szu...@chromium.org>
    Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Attention: Simon Zünd <szu...@chromium.org>
    Gerrit-Comment-Date: Mon, 01 Dec 2025 10:45:24 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Simon Zünd <szu...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Simon Zünd (Gerrit)

    unread,
    5:50 AM (3 hours ago) 5:50 AM
    to Andy Paicu, Danil Somsikov, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
    Attention needed from Andy Paicu

    Simon Zünd voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Andy Paicu
    Submit Requirements:
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: devtools/devtools-frontend
      Gerrit-Branch: main
      Gerrit-Change-Id: I88e3116ce5e3727bda2f2c11da7dc18af670b5ce
      Gerrit-Change-Number: 7208884
      Gerrit-PatchSet: 13
      Gerrit-Owner: Andy Paicu <andy...@chromium.org>
      Gerrit-Reviewer: Andy Paicu <andy...@chromium.org>
      Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>
      Gerrit-Reviewer: Simon Zünd <szu...@chromium.org>
      Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Attention: Andy Paicu <andy...@chromium.org>
      Gerrit-Comment-Date: Mon, 01 Dec 2025 10:50:48 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Danil Somsikov (Gerrit)

      unread,
      6:21 AM (3 hours ago) 6:21 AM
      to Andy Paicu, Simon Zünd, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
      Attention needed from Andy Paicu

      Danil Somsikov voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Andy Paicu
      Submit Requirements:
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: devtools/devtools-frontend
      Gerrit-Branch: main
      Gerrit-Change-Id: I88e3116ce5e3727bda2f2c11da7dc18af670b5ce
      Gerrit-Change-Number: 7208884
      Gerrit-PatchSet: 13
      Gerrit-Owner: Andy Paicu <andy...@chromium.org>
      Gerrit-Reviewer: Andy Paicu <andy...@chromium.org>
      Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>
      Gerrit-Reviewer: Simon Zünd <szu...@chromium.org>
      Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Attention: Andy Paicu <andy...@chromium.org>
      Gerrit-Comment-Date: Mon, 01 Dec 2025 11:20:58 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Andy Paicu (Gerrit)

      unread,
      6:25 AM (3 hours ago) 6:25 AM
      to Danil Somsikov, Simon Zünd, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org

      Andy Paicu voted and added 1 comment

      Votes added by Andy Paicu

      Commit-Queue+2

      1 comment

      Patchset-level comments
      Andy Paicu . resolved

      Thank you

      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: devtools/devtools-frontend
      Gerrit-Branch: main
      Gerrit-Change-Id: I88e3116ce5e3727bda2f2c11da7dc18af670b5ce
      Gerrit-Change-Number: 7208884
      Gerrit-PatchSet: 13
      Gerrit-Owner: Andy Paicu <andy...@chromium.org>
      Gerrit-Reviewer: Andy Paicu <andy...@chromium.org>
      Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>
      Gerrit-Reviewer: Simon Zünd <szu...@chromium.org>
      Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Comment-Date: Mon, 01 Dec 2025 11:24:59 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Devtools-frontend LUCI CQ (Gerrit)

      unread,
      6:26 AM (3 hours ago) 6:26 AM
      to Andy Paicu, Danil Somsikov, Simon Zünd, devtools-rev...@chromium.org

      Devtools-frontend LUCI CQ submitted the change

      Change information

      Commit message:
      [M144] Handle permission element issues in devtools frontend

      Follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/7198583

      This CL adds the necessary logic to display permission element issues
      in devtools.
      Bug: 461746278
      Change-Id: I88e3116ce5e3727bda2f2c11da7dc18af670b5ce
      Reviewed-by: Danil Somsikov <d...@chromium.org>
      Commit-Queue: Andy Paicu <andy...@chromium.org>
      Reviewed-by: Simon Zünd <szu...@chromium.org>
      Files:
      • M config/gni/devtools_grd_files.gni
      • M front_end/models/issues_manager/BUILD.gn
      • M front_end/models/issues_manager/Issue.ts
      • M front_end/models/issues_manager/IssueAggregator.test.ts
      • M front_end/models/issues_manager/IssueAggregator.ts
      • M front_end/models/issues_manager/IssuesManager.ts
      • A front_end/models/issues_manager/PermissionElementIssue.test.ts
      • A front_end/models/issues_manager/PermissionElementIssue.ts
      • A front_end/models/issues_manager/descriptions/permissionElementActivationDisabled.md
      • A front_end/models/issues_manager/descriptions/permissionElementActivationDisabledWithOccluder.md
      • A front_end/models/issues_manager/descriptions/permissionElementActivationDisabledWithOccluderParent.md
      • A front_end/models/issues_manager/descriptions/permissionElementCspFrameAncestorsMissing.md
      • A front_end/models/issues_manager/descriptions/permissionElementFencedFrameDisallowed.md
      • A front_end/models/issues_manager/descriptions/permissionElementFontSizeTooLarge.md
      • A front_end/models/issues_manager/descriptions/permissionElementFontSizeTooSmall.md
      • A front_end/models/issues_manager/descriptions/permissionElementGeolocationDeprecated.md
      • A front_end/models/issues_manager/descriptions/permissionElementInsetBoxShadowUnsupported.md
      • A front_end/models/issues_manager/descriptions/permissionElementInvalidDisplayStyle.md
      • A front_end/models/issues_manager/descriptions/permissionElementInvalidSizeValue.md
      • A front_end/models/issues_manager/descriptions/permissionElementInvalidType.md
      • A front_end/models/issues_manager/descriptions/permissionElementInvalidTypeActivation.md
      • A front_end/models/issues_manager/descriptions/permissionElementLowContrast.md
      • A front_end/models/issues_manager/descriptions/permissionElementNonOpaqueColor.md
      • A front_end/models/issues_manager/descriptions/permissionElementPaddingBottomUnsupported.md
      • A front_end/models/issues_manager/descriptions/permissionElementPaddingRightUnsupported.md
      • A front_end/models/issues_manager/descriptions/permissionElementPermissionsPolicyBlocked.md
      • A front_end/models/issues_manager/descriptions/permissionElementRegistrationFailed.md
      • A front_end/models/issues_manager/descriptions/permissionElementRequestInProgress.md
      • A front_end/models/issues_manager/descriptions/permissionElementSecurityChecksFailed.md
      • A front_end/models/issues_manager/descriptions/permissionElementTypeNotSupported.md
      • A front_end/models/issues_manager/descriptions/permissionElementUntrustedEvent.md
      • M front_end/models/issues_manager/issues_manager.ts
      • A front_end/panels/issues/AffectedPermissionElementsView.ts
      • M front_end/panels/issues/BUILD.gn
      • M front_end/panels/issues/IssueView.ts
      • M front_end/panels/issues/IssuesPane.ts
      • M front_end/ui/visual_logging/KnownContextValues.ts
      Change size: L
      Delta: 37 files changed, 645 insertions(+), 0 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Simon Zünd, +1 by Danil Somsikov
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: devtools/devtools-frontend
      Gerrit-Branch: main
      Gerrit-Change-Id: I88e3116ce5e3727bda2f2c11da7dc18af670b5ce
      Gerrit-Change-Number: 7208884
      Gerrit-PatchSet: 14
      Gerrit-Owner: Andy Paicu <andy...@chromium.org>
      Gerrit-Reviewer: Andy Paicu <andy...@chromium.org>
      Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>
      Gerrit-Reviewer: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Simon Zünd <szu...@chromium.org>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages