Chengzhong Wu (Gerrit)

unread,

Nov 3, 2025, 8:34:28 AM (4 days ago) Nov 3

to Leszek Swirski, V8 LUCI CQ, Fadi Meawad, alph+...@chromium.org, cbruni...@chromium.org, devtools-...@chromium.org, lpy+v8...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org

Attention needed from Leszek Swirski

Chengzhong Wu added 1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Chengzhong Wu . resolved

Hi Leszek, would you mind taking a look at this CL? This is the first CL that I have to enable building V8 with perfetto SDK. I will follow up with making the perfetto processor API in V8 tracing controllers optional with build time flags.

Thanks!

Open in Gerrit

Related details

Attention is currently required from:

Leszek Swirski

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Leszek Swirski (Gerrit)

unread,

Nov 3, 2025, 9:16:14 AM (4 days ago) Nov 3

to Chengzhong Wu, Camillo Bruni, V8 LUCI CQ, Fadi Meawad, alph+...@chromium.org, cbruni...@chromium.org, devtools-...@chromium.org, lpy+v8...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org

Attention needed from Camillo Bruni and Chengzhong Wu

Leszek Swirski added 2 comments

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Leszek Swirski . resolved

Camillo, can you PTAL at this? The motivation is that Node.js would have an easier time switching to perfetto if we used only the perfetto sdk, not the full perfetto lib

File include/v8config.h

Line 1067, Patchset 4 (Latest):#if defined(V8_USE_PERFETTO_SDK) && !defined(V8_USE_PERFETTO)

Leszek Swirski . unresolved

I think this can't happen, if you're already setting this with BUILD.gn

Open in Gerrit

Related details

Attention is currently required from:

Camillo Bruni
Chengzhong Wu

Submit Requirements:

Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Chengzhong Wu (Gerrit)

unread,

Nov 3, 2025, 9:19:05 AM (4 days ago) Nov 3

to Camillo Bruni, Leszek Swirski, V8 LUCI CQ, Fadi Meawad, alph+...@chromium.org, cbruni...@chromium.org, devtools-...@chromium.org, lpy+v8...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org

Attention needed from Camillo Bruni and Leszek Swirski

Chengzhong Wu added 1 comment

File include/v8config.h

Line 1067, Patchset 4 (Latest):#if defined(V8_USE_PERFETTO_SDK) && !defined(V8_USE_PERFETTO)

Leszek Swirski . unresolved

I think this can't happen, if you're already setting this with BUILD.gn

Chengzhong Wu

Node.js does not use `BUILD.gn` though. This is a fallback in case the embedder's build scripts did not implied `V8_USE_PERFETTO` with `V8_USE_PERFETTO_SDK` correctly.

Open in Gerrit

Related details

Attention is currently required from:

Camillo Bruni
Leszek Swirski

Submit Requirements:

Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Leszek Swirski (Gerrit)

unread,

Nov 3, 2025, 9:39:47 AM (4 days ago) Nov 3

to Chengzhong Wu, Camillo Bruni, V8 LUCI CQ, Fadi Meawad, alph+...@chromium.org, cbruni...@chromium.org, devtools-...@chromium.org, lpy+v8...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org

Attention needed from Camillo Bruni and Chengzhong Wu

Leszek Swirski added 1 comment

File include/v8config.h

Line 1067, Patchset 4 (Latest):#if defined(V8_USE_PERFETTO_SDK) && !defined(V8_USE_PERFETTO)

Leszek Swirski . unresolved

I think this can't happen, if you're already setting this with BUILD.gn

Chengzhong Wu

Node.js does not use `BUILD.gn` though. This is a fallback in case the embedder's build scripts did not implied `V8_USE_PERFETTO` with `V8_USE_PERFETTO_SDK` correctly.

Leszek Swirski

then you should report an `#error` if things are inconsistent so that that embedder fixes their build scripts, otherwise we might get into a state where someone doesn't include this header, and then can see `V8_USE_PERFETTO_SDK` without `V8_USE_PERFETTO`

Open in Gerrit

Related details

Attention is currently required from:

Camillo Bruni
Chengzhong Wu

Submit Requirements:

Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Camillo Bruni (Gerrit)

unread,

Nov 4, 2025, 3:41:00 AM (3 days ago) Nov 4

to Chengzhong Wu, Leszek Swirski, V8 LUCI CQ, Fadi Meawad, alph+...@chromium.org, cbruni...@chromium.org, devtools-...@chromium.org, lpy+v8...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org

Attention needed from Chengzhong Wu

Camillo Bruni added 3 comments

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Camillo Bruni . resolved

modulo missing compile-time warning for misconfigured ifdefs looking good.

File src/libplatform/tracing/tracing-controller.cc

Line 23, Patchset 4 (Latest):

#include "perfetto/ext/trace_processor/export_json.h"
#include "perfetto/trace_processor/trace_processor.h"

Camillo Bruni . unresolved

Just to confirm – node is fine with having these as separate deps?

File src/tracing/perfetto-sdk.h

Line 13, Patchset 4 (Latest):

// For now most of v8 uses legacy trace events.
// This must be defined before including any perfetto headers.
#define PERFETTO_ENABLE_LEGACY_TRACE_EVENTS 1

Camillo Bruni . resolved

hope we can slowly move away from the legacy trace events.

Open in Gerrit

Related details

Attention is currently required from:

Chengzhong Wu

Submit Requirements:

Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Chengzhong Wu (Gerrit)

unread,

Nov 4, 2025, 5:06:46 AM (3 days ago) Nov 4

to Camillo Bruni, Leszek Swirski, V8 LUCI CQ, Fadi Meawad, alph+...@chromium.org, cbruni...@chromium.org, devtools-...@chromium.org, lpy+v8...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org

Attention needed from Camillo Bruni and Leszek Swirski

Chengzhong Wu added 2 comments

File include/v8config.h

Line 1067, Patchset 4:#if defined(V8_USE_PERFETTO_SDK) && !defined(V8_USE_PERFETTO)

Leszek Swirski . resolved

I think this can't happen, if you're already setting this with BUILD.gn

Chengzhong Wu

Node.js does not use `BUILD.gn` though. This is a fallback in case the embedder's build scripts did not implied `V8_USE_PERFETTO` with `V8_USE_PERFETTO_SDK` correctly.

Leszek Swirski

then you should report an `#error` if things are inconsistent so that that embedder fixes their build scripts, otherwise we might get into a state where someone doesn't include this header, and then can see `V8_USE_PERFETTO_SDK` without `V8_USE_PERFETTO`

Chengzhong Wu

Thanks for suggestion, sounds better to me! Done.

File src/libplatform/tracing/tracing-controller.cc

Line 23, Patchset 4:

#include "perfetto/ext/trace_processor/export_json.h"
#include "perfetto/trace_processor/trace_processor.h"

Camillo Bruni . unresolved

Just to confirm – node is fine with having these as separate deps?

Chengzhong Wu

I will follow up with a CL to guard this behind another build flag, say `V8_USE_PERFETTO_JSON_EXPORT`. I think for Node.js, it is best to avoid output JSON format at all.

Open in Gerrit

Related details

Attention is currently required from:

Camillo Bruni
Leszek Swirski

Submit Requirements:

Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Camillo Bruni (Gerrit)

unread,

Nov 5, 2025, 12:12:21 PM (2 days ago) Nov 5

to Chengzhong Wu, Leszek Swirski, V8 LUCI CQ, Fadi Meawad, alph+...@chromium.org, cbruni...@chromium.org, devtools-...@chromium.org, lpy+v8...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org

Attention needed from Chengzhong Wu and Leszek Swirski

Camillo Bruni voted and added 1 comment

Votes added by Camillo Bruni

Code-Review

+1

1 comment

File src/libplatform/tracing/tracing-controller.cc

Line 23, Patchset 4:

#include "perfetto/ext/trace_processor/export_json.h"
#include "perfetto/trace_processor/trace_processor.h"

Camillo Bruni . resolved

Just to confirm – node is fine with having these as separate deps?

Chengzhong Wu

I will follow up with a CL to guard this behind another build flag, say `V8_USE_PERFETTO_JSON_EXPORT`. I think for Node.js, it is best to avoid output JSON format at all.

Camillo Bruni

Acknowledged

Open in Gerrit

Related details

Attention is currently required from:

Chengzhong Wu
Leszek Swirski

Submit Requirements:

Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

satisfied_requirement

open

diffy

Leszek Swirski (Gerrit)

unread,

Nov 6, 2025, 5:09:59 AM (20 hours ago) Nov 6

to Chengzhong Wu, Camillo Bruni, V8 LUCI CQ, Fadi Meawad, alph+...@chromium.org, cbruni...@chromium.org, devtools-...@chromium.org, lpy+v8...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org

Attention needed from Chengzhong Wu

Leszek Swirski voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Chengzhong Wu

Submit Requirements:

Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chengzhong Wu (Gerrit)

unread,

Nov 6, 2025, 5:42:52 AM (20 hours ago) Nov 6

to Leszek Swirski, Camillo Bruni, V8 LUCI CQ, Fadi Meawad, alph+...@chromium.org, cbruni...@chromium.org, devtools-...@chromium.org, lpy+v8...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org

Chengzhong Wu voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

V8 LUCI CQ (Gerrit)

unread,

Nov 6, 2025, 6:21:49 AM (19 hours ago) Nov 6

to Chengzhong Wu, Leszek Swirski, Camillo Bruni, Fadi Meawad, alph+...@chromium.org, cbruni...@chromium.org, devtools-...@chromium.org, lpy+v8...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org

V8 LUCI CQ submitted the change

Change information

Commit message:

[perfetto] Add V8_USE_PERFETTO_SDK build flag

Add a build time flag to use Perfetto SDK header `perfetto.h`.

Refs: https://github.com/nodejs/diagnostics/issues/654

Bug: 457135433

Change-Id: Ifefa3687d7bd7b1f1af78a681bb48ded39f84f57

Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7111260

Reviewed-by: Camillo Bruni <cbr...@chromium.org>

Reviewed-by: Leszek Swirski <les...@chromium.org>

Commit-Queue: Chengzhong Wu <cwu...@bloomberg.net>

Cr-Commit-Position: refs/heads/main@{#103565}

Files:

M BUILD.bazel
M BUILD.gn
M gni/v8.gni
M include/v8-trace-categories.h
M include/v8config.h
M src/builtins/builtins-trace.cc
M src/d8/d8.cc
M src/libplatform/tracing/tracing-controller.cc
M src/tracing/code-data-source.cc
M src/tracing/code-data-source.h
M src/tracing/code-trace-context.h
M src/tracing/perfetto-logger.cc
A src/tracing/perfetto-sdk.h
M src/tracing/trace-categories.h
M src/tracing/trace-event.h
M src/tracing/traced-value.cc

Change size: M

Delta: 16 files changed, 84 insertions(+), 39 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Leszek Swirski, +1 by Camillo Bruni

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[perfetto] Add V8_USE_PERFETTO_SDK build flag [v8/v8 : main]

Chengzhong Wu (Gerrit)

Chengzhong Wu added 1 comment

Related details

Leszek Swirski (Gerrit)

Leszek Swirski added 2 comments

Related details

Chengzhong Wu (Gerrit)

Chengzhong Wu added 1 comment

Related details

Leszek Swirski (Gerrit)

Leszek Swirski added 1 comment

Related details

Camillo Bruni (Gerrit)

Camillo Bruni added 3 comments

Related details

Chengzhong Wu (Gerrit)

Chengzhong Wu added 2 comments

Related details

Camillo Bruni (Gerrit)

Camillo Bruni voted and added 1 comment

Votes added by Camillo Bruni

1 comment

Related details

Leszek Swirski (Gerrit)

Leszek Swirski voted Code-Review+1

Related details

Chengzhong Wu (Gerrit)

Chengzhong Wu voted Commit-Queue+2

Related details

V8 LUCI CQ (Gerrit)

V8 LUCI CQ submitted the change

Change information