Lazy load the instance [devtools/devtools-frontend : main]

0 views

Skip to first unread message

Nikolay Vitkov (Gerrit)

unread,

Mar 23, 2026, 2:26:02 PM (17 hours ago) Mar 23

to Simon Zünd, devtools-rev...@chromium.org

Attention needed from Simon Zünd

Nikolay Vitkov voted Auto-Submit+1

Auto-Submit

Open in Gerrit

Related details

Attention is currently required from:

Simon Zünd

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Simon Zünd (Gerrit)

unread,

1:22 AM (6 hours ago) 1:22 AM

to Nikolay Vitkov, devtools-rev...@chromium.org

Attention needed from Nikolay Vitkov

Simon Zünd added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Simon Zünd . unresolved

This feels like such an odd type in the first place.

Would it be possible to just turn this into a simple interface? Construct it inline in `HeapProfilerPanel` constructor and stash it as a prop on the panel. We already store the flattened list of the types in the `super`. And then just pass it through to `HeapSnapshotView` in some manner?