[object_ui] Split 'evaluateAndBuildPreview' in JavaScriptREPL [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Simon Zünd (Gerrit)
4:38 AM (11 hours ago) 4:38 AM
to Devtools-frontend LUCI CQ, Philip Pfaffe, devtools-rev...@chromium.org
Attention needed from Philip Pfaffe
Simon Zünd added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File front_end/ui/legacy/components/object_ui/RemoteObjectPreviewFormatter.ts
Line 259, Patchset 2 (Latest):
/* eslint-disable-next-line @devtools/no-lit-render-outside-of-view */
render(html`<span>${result.exceptionDetails.text} ${exception}</span>`, fragment);Simon Zünd . unresolved
These changed from the copied version. Previously it was:
```ts
fragment.createChild('span').textContent = result.exceptionDetails.text + ' ' + exception;
```
Related details
Attention is currently required from:
- Philip Pfaffe
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Philip Pfaffe (Gerrit)
4:44 AM (10 hours ago) 4:44 AM
to Simon Zünd, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Simon Zünd
Philip Pfaffe voted and added 1 comment![]( "Open in Gerrit")
Votes added by Philip Pfaffe
| Code-Review | +1 |
1 comment
File front_end/ui/legacy/components/object_ui/RemoteObjectPreviewFormatter.ts
Line 259, Patchset 2 (Latest):
/* eslint-disable-next-line @devtools/no-lit-render-outside-of-view */
render(html`<span>${result.exceptionDetails.text} ${exception}</span>`, fragment);Simon Zünd . resolved
These changed from the copied version. Previously it was:
```ts
fragment.createChild('span').textContent = result.exceptionDetails.text + ' ' + exception;
```
Attention is currently required from:
- Simon Zünd
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Simon Zünd (Gerrit)
4:52 AM (10 hours ago) 4:52 AM
to Philip Pfaffe, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Simon Zünd voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devtools-frontend LUCI CQ (Gerrit)
5:07 AM (10 hours ago) 5:07 AM
to Simon Zünd, Philip Pfaffe, devtools-rev...@chromium.org
Devtools-frontend LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[object_ui] Split 'evaluateAndBuildPreview' in JavaScriptREPL
This CL splits the 'evaluate' part from the 'evaluateAndBuildPreview'.
We want to disentangle business logic from UI logic in
ConsolePinPane.ts and having a method that does both eval plus
presentation makes this harder.
Note that we pass the `ExecutionContext` to `evaluate` on purpose:
This way, the function has no dependency on UI whatsoever and we could
potentially move this code lower in our layering (e.g. to 'models/').
R=pfa...@chromium.org
Bug: 457388389,407750444
Change-Id: I85ac703679a4df9590fc81430b1de0e4f1a811a2
Commit-Queue: Simon Zünd <szu...@chromium.org>
Reviewed-by: Philip Pfaffe <pfa...@chromium.org>
Files:
- M front_end/ui/legacy/components/object_ui/JavaScriptREPL.ts
- M front_end/ui/legacy/components/object_ui/RemoteObjectPreviewFormatter.ts
Change size: M
Delta: 2 files changed, 53 insertions(+), 38 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Philip Pfaffe
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages