Piotr Paulski (Gerrit)

unread,

Sep 12, 2025, 6:32:34 AM (12 days ago) Sep 12

to Natallia Harshunova, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org

Attention needed from Natallia Harshunova

Piotr Paulski voted and added 1 comment

Votes added by Piotr Paulski

Auto-Submit

+1

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Piotr Paulski . resolved

This is very similar to a bug you fixed in the Elements panel, PTAL :-)

Open in Gerrit

Related details

Attention is currently required from:

Natallia Harshunova

Submit Requirements:

Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Natallia Harshunova (Gerrit)

unread,

Sep 12, 2025, 6:37:16 AM (12 days ago) Sep 12

to Piotr Paulski, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org

Attention needed from Piotr Paulski

Natallia Harshunova voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Piotr Paulski

Submit Requirements:

Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Piotr Paulski (Gerrit)

unread,

Sep 12, 2025, 8:59:29 AM (12 days ago) Sep 12

to Natallia Harshunova, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org

Attention needed from Natallia Harshunova

Piotr Paulski voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

Natallia Harshunova

Submit Requirements:

Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Nikolay Vitkov (Gerrit)

unread,

Sep 12, 2025, 11:06:38 AM (12 days ago) Sep 12

to Piotr Paulski, Natallia Harshunova, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org

Attention needed from Natallia Harshunova and Piotr Paulski

Nikolay Vitkov added 1 comment

Commit Message

Line 26, Patchset 2 (Latest):Test: Manually verified the fix.

Nikolay Vitkov . unresolved

Super nit: The fix/change and other footer should be last thing in the commit (some times it even fails PRESUBMIT)

Open in Gerrit

Related details

Attention is currently required from:

Natallia Harshunova
Piotr Paulski

Submit Requirements:

Code-Owners
Code-Review

No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alex Rudenko (Gerrit)

unread,

Sep 16, 2025, 7:09:28 AM (8 days ago) Sep 16

to Piotr Paulski, Nikolay Vitkov, Natallia Harshunova, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org

Attention needed from Natallia Harshunova and Piotr Paulski

Alex Rudenko added 1 comment

File front_end/panels/sources/SourcesPanel.ts

Line 1197, Patchset 2 (Latest): vertically = this.splitWidget.element.offsetWidth < 680;

Alex Rudenko . unresolved

can we keep the UI.InspectorView.InspectorView.instance() before this line to keep the side-effect and land this for now?

Open in Gerrit

Related details

Attention is currently required from:

Natallia Harshunova
Piotr Paulski

Submit Requirements:

Code-Owners
Code-Review
No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Piotr Paulski (Gerrit)

unread,

Sep 16, 2025, 9:07:30 AM (8 days ago) Sep 16

to Alex Rudenko, Nikolay Vitkov, Natallia Harshunova, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org

Attention needed from Alex Rudenko, Natallia Harshunova and Nikolay Vitkov

Piotr Paulski voted and added 2 comments

Votes added by Piotr Paulski

Auto-Submit

+1

2 comments

Commit Message

Line 26, Patchset 2:Test: Manually verified the fix.

Nikolay Vitkov . resolved

Super nit: The fix/change and other footer should be last thing in the commit (some times it even fails PRESUBMIT)

Piotr Paulski

Done

File front_end/panels/sources/SourcesPanel.ts

Line 1197, Patchset 2: vertically = this.splitWidget.element.offsetWidth < 680;

Alex Rudenko . unresolved

can we keep the UI.InspectorView.InspectorView.instance() before this line to keep the side-effect and land this for now?

Piotr Paulski

If that will solve the issue, sure!
will try it in a moment.

Open in Gerrit

Related details

Attention is currently required from:

Alex Rudenko
Natallia Harshunova
Nikolay Vitkov

Submit Requirements:

Code-Owners
Code-Review
No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Piotr Paulski (Gerrit)

unread,

Sep 16, 2025, 9:48:43 AM (8 days ago) Sep 16

to Alex Rudenko, Nikolay Vitkov, Natallia Harshunova, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org

Attention needed from Piotr Paulski

Piotr Paulski added 1 comment

File front_end/panels/sources/SourcesPanel.ts

Line 1197, Patchset 2: vertically = this.splitWidget.element.offsetWidth < 680;

Alex Rudenko . unresolved

can we keep the UI.InspectorView.InspectorView.instance() before this line to keep the side-effect and land this for now?

Piotr Paulski

If that will solve the issue, sure!
will try it in a moment.

Piotr Paulski

I tested locally, it didn't solve the issue.

Open in Gerrit

Related details

Attention is currently required from:

Piotr Paulski

Submit Requirements:

Code-Owners
Code-Review
No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alex Rudenko (Gerrit)

unread,

Sep 23, 2025, 4:42:06 AM (22 hours ago) Sep 23

to Piotr Paulski, Nikolay Vitkov, Natallia Harshunova, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org

Attention needed from Piotr Paulski

Alex Rudenko added 1 comment

File front_end/panels/sources/SourcesPanel.ts

Line 1197, Patchset 2: vertically = this.splitWidget.element.offsetWidth < 680;

Alex Rudenko . resolved

can we keep the UI.InspectorView.InspectorView.instance() before this line to keep the side-effect and land this for now?

Piotr Paulski

If that will solve the issue, sure!
will try it in a moment.

Piotr Paulski

I tested locally, it didn't solve the issue.

Alex Rudenko

Done

Open in Gerrit

Related details

Attention is currently required from:

Piotr Paulski

Submit Requirements:

Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Piotr Paulski (Gerrit)

unread,

Sep 23, 2025, 11:15:57 AM (15 hours ago) Sep 23

to Alex Rudenko, Nikolay Vitkov, Natallia Harshunova, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org

Piotr Paulski voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Devtools-frontend LUCI CQ (Gerrit)

unread,

Sep 23, 2025, 11:43:06 AM (15 hours ago) Sep 23

to Piotr Paulski, Alex Rudenko, Nikolay Vitkov, Natallia Harshunova, devtools-rev...@chromium.org

Devtools-frontend LUCI CQ submitted the change

Unreviewed changes

1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:

Fix SourcesPanel responsive layout with vertical drawer.

The SourcesPanel's responsive layout failed to trigger correctly when
Vertical Drawer Orientation feature was enabled and the drawer was in
vertical orientation.

The layout logic was incorrectly based on the total width of the
Inspector window, rather than the available width for the SourcesPanel
itself. When the drawer was open in vertical orientation, it reduced the
panel's available space, but the layout did not adapt because the
overall window width remained unchanged.

This change updates the layout logic to be responsive to the
SourcesPanel's own container width. This ensures that its side-pane
components correctly move below the main editor pane when space is
limited by the vertical drawer, matching the behavior of a narrowed
window.



Test: Manually verified the fix.

1. Open the Sources panel and
show the drawer vertically.
2. Narrow the main window or widen the vertical drawer.
3. Verify the Sources panel switches to its responsive, narrow-layout
mode as expected.

Fixed: 444604613

Change-Id: I8e41e600e5783e84579cbcc2e62aaa2285bc90be

Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6943170

Commit-Queue: Piotr Paulski <piotrp...@chromium.org>

Reviewed-by: Natallia Harshunova <nhars...@chromium.org>

Auto-Submit: Piotr Paulski <piotrp...@chromium.org>

Files:

M front_end/panels/sources/SourcesPanel.ts

Change size: XS

Delta: 1 file changed, 1 insertion(+), 1 deletion(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Natallia Harshunova

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Fix SourcesPanel responsive layout with vertical drawer. [devtools/devtools-frontend : main]

Piotr Paulski (Gerrit)

Piotr Paulski voted and added 1 comment

Votes added by Piotr Paulski

1 comment

Related details

Natallia Harshunova (Gerrit)

Natallia Harshunova voted

Related details

Piotr Paulski (Gerrit)

Piotr Paulski voted Commit-Queue+2

Related details

Nikolay Vitkov (Gerrit)

Nikolay Vitkov added 1 comment

Related details

Alex Rudenko (Gerrit)

Alex Rudenko added 1 comment

Related details

Piotr Paulski (Gerrit)

Piotr Paulski voted and added 2 comments

Votes added by Piotr Paulski

2 comments

Related details

Piotr Paulski (Gerrit)

Piotr Paulski added 1 comment

Related details

Alex Rudenko (Gerrit)

Alex Rudenko added 1 comment

Related details

Piotr Paulski (Gerrit)

Piotr Paulski voted Commit-Queue+2

Related details

Devtools-frontend LUCI CQ (Gerrit)

Devtools-frontend LUCI CQ submitted the change

Unreviewed changes

Change information