[handles] Migration to direct handles, part 5 [v8/v8 : main]
6 views
Skip to first unread message
Nikolaos Papaspyrou (Gerrit)
Aug 8, 2024, 8:20:54 PM8/8/24
to Omer Katz, V8 LUCI CQ, Hannes Payer, devtools-...@chromium.org, dmercadi...@chromium.org, jgrube...@chromium.org, leszek...@chromium.org, marja...@chromium.org, mlippau...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org, was...@google.com
Attention needed from Omer Katz
Nikolaos Papaspyrou added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Nikolaos Papaspyrou . unresolved
- Patchset #1 contains the automatic changes: `s/Handle/DirectHandle/`.
This is the largest part of this CL, you can ignore it in the review.
- Patchset #2 contains changes that were necessary for the CL to compile and pass the tests.
- Patchset #3 contains some polishing.
Related details
Attention is currently required from:
- Omer Katz
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Omer Katz (Gerrit)
Aug 9, 2024, 1:36:53 AM8/9/24
to Nikolaos Papaspyrou, V8 LUCI CQ, Hannes Payer, devtools-...@chromium.org, dmercadi...@chromium.org, jgrube...@chromium.org, leszek...@chromium.org, marja...@chromium.org, mlippau...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org, was...@google.com
Attention needed from Nikolaos Papaspyrou
Omer Katz voted and added 2 comments![]( "Open in Gerrit")
Votes added by Omer Katz
| Code-Review | +1 |
2 comments
Patchset-level comments
Omer Katz . resolved
lgtm
Nikolaos Papaspyrou . resolved
- Patchset #1 contains the automatic changes: `s/Handle/DirectHandle/`.
This is the largest part of this CL, you can ignore it in the review.
- Patchset #2 contains changes that were necessary for the CL to compile and pass the tests.
- Patchset #3 contains some polishing.
Attention is currently required from:
- Nikolaos Papaspyrou
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nikolaos Papaspyrou (Gerrit)
Aug 9, 2024, 11:54:30 AM8/9/24
to Leszek Swirski, Omer Katz, V8 LUCI CQ, Hannes Payer, devtools-...@chromium.org, dmercadi...@chromium.org, jgrube...@chromium.org, leszek...@chromium.org, marja...@chromium.org, mlippau...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org, was...@google.com
Attention needed from Leszek Swirski
Nikolaos Papaspyrou added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Nikolaos Papaspyrou . resolved
Leszek, could you PTAL?
Usually mlippautz stamps these, but it's quite large and will have even more conflicts until he's back.
The first comment explains what the 3 patchsets contain.
Related details
Attention is currently required from:
- Leszek Swirski
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Leszek Swirski (Gerrit)
Aug 12, 2024, 3:55:24 AM8/12/24
to Nikolaos Papaspyrou, Omer Katz, V8 LUCI CQ, Hannes Payer, devtools-...@chromium.org, dmercadi...@chromium.org, jgrube...@chromium.org, leszek...@chromium.org, marja...@chromium.org, mlippau...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org, was...@google.com
Attention needed from Nikolaos Papaspyrou
Leszek Swirski voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Nikolaos Papaspyrou
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nikolaos Papaspyrou (Gerrit)
Aug 12, 2024, 9:35:38 AM8/12/24
to Leszek Swirski, Omer Katz, V8 LUCI CQ, Hannes Payer, devtools-...@chromium.org, dmercadi...@chromium.org, jgrube...@chromium.org, leszek...@chromium.org, marja...@chromium.org, mlippau...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org, was...@google.com
Nikolaos Papaspyrou voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Aug 12, 2024, 9:42:27 AM8/12/24
to Nikolaos Papaspyrou, Leszek Swirski, Omer Katz, Hannes Payer, devtools-...@chromium.org, dmercadi...@chromium.org, jgrube...@chromium.org, leszek...@chromium.org, marja...@chromium.org, mlippau...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org, was...@google.com
V8 LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: src/init/bootstrapper.cc
Insertions: 4, Deletions: 5.
@@ -408,17 +408,33 @@
}
#endif // DEBUG
+Handle<SharedFunctionInfo> CreateSharedFunctionInfoForBuiltin(
+ Isolate* isolate, Handle<String> name, Builtin builtin, int len,
+ bool adapt) {
+ Handle<SharedFunctionInfo> info =
+ isolate->factory()->NewSharedFunctionInfoForBuiltin(name, builtin);
+ info->set_language_mode(LanguageMode::kStrict);
+
+ info->set_length(len);
+ if (adapt) {
+ info->set_internal_formal_parameter_count(JSParameterCount(len));
+ } else {
+ info->DontAdaptArguments();
+ }
+
+ return info;
+}
+
V8_NOINLINE Handle<JSFunction> CreateFunctionForBuiltin(Isolate* isolate,
Handle<String> name,
Handle<Map> map,
- Builtin builtin) {
- Factory* factory = isolate->factory();
+ Builtin builtin,
+ int len, bool adapt) {
Handle<NativeContext> context(isolate->native_context());
DCHECK(IsFunctionMapOrSpecialBuiltin(map, builtin, context));
Handle<SharedFunctionInfo> info =
- factory->NewSharedFunctionInfoForBuiltin(name, builtin);
- info->set_language_mode(LanguageMode::kStrict);
+ CreateSharedFunctionInfoForBuiltin(isolate, name, builtin, len, adapt);
return Factory::JSFunctionBuilder{isolate, info, context}
.set_map(map)
@@ -428,7 +444,8 @@
V8_NOINLINE Handle<JSFunction> CreateFunctionForBuiltinWithPrototype(
Isolate* isolate, Handle<String> name, Builtin builtin,
Handle<HeapObject> prototype, InstanceType type, int instance_size,
- int inobject_properties, MutableMode prototype_mutability) {
+ int inobject_properties, MutableMode prototype_mutability, int len,
+ bool adapt) {
Factory* factory = isolate->factory();
Handle<NativeContext> context(isolate->native_context());
Handle<Map> map =
@@ -438,8 +455,7 @@
DCHECK(IsFunctionMapOrSpecialBuiltin(map, builtin, context));
Handle<SharedFunctionInfo> info =
- factory->NewSharedFunctionInfoForBuiltin(name, builtin);
- info->set_language_mode(LanguageMode::kStrict);
+ CreateSharedFunctionInfoForBuiltin(isolate, name, builtin, len, adapt);
info->set_expected_nof_properties(inobject_properties);
Handle<JSFunction> result =
@@ -478,15 +494,14 @@
}
V8_NOINLINE Handle<JSFunction> CreateFunctionForBuiltinWithoutPrototype(
- Isolate* isolate, Handle<String> name, Builtin builtin) {
- Factory* factory = isolate->factory();
+ Isolate* isolate, Handle<String> name, Builtin builtin, int len,
+ bool adapt) {
Handle<NativeContext> context(isolate->native_context());
Handle<Map> map = isolate->strict_function_without_prototype_map();
DCHECK(IsFunctionMapOrSpecialBuiltin(map, builtin, context));
Handle<SharedFunctionInfo> info =
- factory->NewSharedFunctionInfoForBuiltin(name, builtin);
- info->set_language_mode(LanguageMode::kStrict);
+ CreateSharedFunctionInfoForBuiltin(isolate, name, builtin, len, adapt);
return Factory::JSFunctionBuilder{isolate, info, context}
.set_map(map)
@@ -495,12 +510,13 @@
V8_NOINLINE Handle<JSFunction> CreateFunction(
Isolate* isolate, Handle<String> name, InstanceType type, int instance_size,
- int inobject_properties, Handle<HeapObject> prototype, Builtin builtin) {
+ int inobject_properties, Handle<HeapObject> prototype, Builtin builtin,
+ int len, bool adapt) {
DCHECK(Builtins::HasJSLinkage(builtin));
Handle<JSFunction> result = CreateFunctionForBuiltinWithPrototype(
isolate, name, builtin, prototype, type, instance_size,
- inobject_properties, IMMUTABLE);
+ inobject_properties, IMMUTABLE, len, adapt);
// Make the JSFunction's prototype object fast.
JSObject::MakePrototypesFast(handle(result->prototype(), isolate),
@@ -514,19 +530,21 @@
V8_NOINLINE Handle<JSFunction> CreateFunction(
Isolate* isolate, const char* name, InstanceType type, int instance_size,
- int inobject_properties, Handle<HeapObject> prototype, Builtin builtin) {
- return CreateFunction(isolate,
- isolate->factory()->InternalizeUtf8String(name), type,
- instance_size, inobject_properties, prototype, builtin);
+ int inobject_properties, Handle<HeapObject> prototype, Builtin builtin,
+ int len, bool adapt) {
+ return CreateFunction(
+ isolate, isolate->factory()->InternalizeUtf8String(name), type,
+ instance_size, inobject_properties, prototype, builtin, len, adapt);
}
V8_NOINLINE Handle<JSFunction> InstallFunction(
Isolate* isolate, Handle<JSObject> target, Handle<String> name,
InstanceType type, int instance_size, int inobject_properties,
- Handle<HeapObject> prototype, Builtin call) {
+ Handle<HeapObject> prototype, Builtin call, int len, bool adapt) {
DCHECK(Builtins::HasJSLinkage(call));
- Handle<JSFunction> function = CreateFunction(
- isolate, name, type, instance_size, inobject_properties, prototype, call);
+ Handle<JSFunction> function =
+ CreateFunction(isolate, name, type, instance_size, inobject_properties,
+ prototype, call, len, adapt);
JSObject::AddProperty(isolate, target, name, function, DONT_ENUM);
return function;
}
@@ -534,10 +552,10 @@
V8_NOINLINE Handle<JSFunction> InstallFunction(
Isolate* isolate, Handle<JSObject> target, const char* name,
InstanceType type, int instance_size, int inobject_properties,
- Handle<HeapObject> prototype, Builtin call) {
- return InstallFunction(isolate, target,
- isolate->factory()->InternalizeUtf8String(name), type,
- instance_size, inobject_properties, prototype, call);
+ Handle<HeapObject> prototype, Builtin call, int len, bool adapt) {
+ return InstallFunction(
+ isolate, target, isolate->factory()->InternalizeUtf8String(name), type,
+ instance_size, inobject_properties, prototype, call, len, adapt);
}
// This sets a constructor instance type on the constructor map which will be
@@ -573,17 +591,10 @@
DCHECK(Builtins::HasJSLinkage(call));
name = String::Flatten(isolate, name, AllocationType::kOld);
Handle<JSFunction> fun =
- CreateFunctionForBuiltinWithoutPrototype(isolate, name, call);
+ CreateFunctionForBuiltinWithoutPrototype(isolate, name, call, len, adapt);
// Make the resulting JSFunction object fast.
JSObject::MakePrototypesFast(fun, kStartAtReceiver, isolate);
fun->shared()->set_native(true);
-
- if (adapt) {
- fun->shared()->set_internal_formal_parameter_count(JSParameterCount(len));
- } else {
- fun->shared()->DontAdaptArguments();
- }
- fun->shared()->set_length(len);
return fun;
}
@@ -760,9 +771,9 @@
// Allocate the empty function as the prototype for function according to
// ES#sec-properties-of-the-function-prototype-object
- Handle<JSFunction> empty_function =
- CreateFunctionForBuiltin(isolate(), factory()->empty_string(),
- empty_function_map, Builtin::kEmptyFunction);
+ Handle<JSFunction> empty_function = CreateFunctionForBuiltin(
+ isolate(), factory()->empty_string(), empty_function_map,
+ Builtin::kEmptyFunction, 0, false);
empty_function_map->SetConstructor(*empty_function);
native_context()->set_empty_function(*empty_function);
@@ -775,7 +786,6 @@
ReadOnlyRoots roots{isolate()};
Tagged<SharedFunctionInfo> sfi = empty_function->shared();
sfi->set_raw_scope_info(roots.empty_function_scope_info());
- sfi->DontAdaptArguments();
sfi->SetScript(isolate(), roots, *script, 1);
sfi->UpdateFunctionMapIndex();
@@ -817,8 +827,7 @@
}
Handle<String> name = factory()->empty_string();
Handle<JSFunction> function = CreateFunctionForBuiltinWithoutPrototype(
- isolate(), name, Builtin::kStrictPoisonPillThrower);
- function->shared()->DontAdaptArguments();
+ isolate(), name, Builtin::kStrictPoisonPillThrower, 0, true);
// %ThrowTypeError% must have a name property with an empty string value. Per
// spec, ThrowTypeError's name is non-configurable, unlike ordinary functions'
@@ -896,11 +905,10 @@
int inobject_properties = JSObject::kInitialGlobalObjectUnusedPropertiesCount;
int instance_size = JSObject::kHeaderSize + kTaggedSize * inobject_properties;
- DirectHandle<JSFunction> object_fun = CreateFunction(
- isolate_, factory->Object_string(), JS_OBJECT_TYPE, instance_size,
- inobject_properties, factory->null_value(), Builtin::kObjectConstructor);
- object_fun->shared()->set_length(1);
- object_fun->shared()->DontAdaptArguments();
+ DirectHandle<JSFunction> object_fun =
+ CreateFunction(isolate_, factory->Object_string(), JS_OBJECT_TYPE,
+ instance_size, inobject_properties, factory->null_value(),
+ Builtin::kObjectConstructor, 1, false);
native_context()->set_object_function(*object_fun);
{
@@ -1391,7 +1399,7 @@
factory()->NewFunctionPrototype(isolate()->object_function());
js_global_object_function = CreateFunctionForBuiltinWithPrototype(
isolate(), name, Builtin::kIllegal, prototype, JS_GLOBAL_OBJECT_TYPE,
- JSGlobalObject::kHeaderSize, 0, MUTABLE);
+ JSGlobalObject::kHeaderSize, 0, MUTABLE, 0, true);
#ifdef DEBUG
LookupIterator it(isolate(), prototype, factory()->constructor_string(),
LookupIterator::OWN_SKIP_INTERCEPTOR);
@@ -1422,7 +1430,7 @@
global_proxy_function = CreateFunctionForBuiltinWithPrototype(
isolate(), name, Builtin::kIllegal, factory()->the_hole_value(),
JS_GLOBAL_PROXY_TYPE, JSGlobalProxy::SizeWithEmbedderFields(0), 0,
- MUTABLE);
+ MUTABLE, 0, true);
} else {
DirectHandle<ObjectTemplateInfo> data =
v8::Utils::OpenDirectHandle(*global_proxy_template);
@@ -1510,11 +1518,10 @@
const int in_object_properties = 3;
const int kErrorObjectSize =
JSObject::kHeaderSize + in_object_properties * kTaggedSize;
- Handle<JSFunction> error_fun = InstallFunction(
- isolate, global, name, JS_ERROR_TYPE, kErrorObjectSize,
- in_object_properties, factory->the_hole_value(), error_constructor);
- error_fun->shared()->DontAdaptArguments();
- error_fun->shared()->set_length(error_function_length);
+ Handle<JSFunction> error_fun =
+ InstallFunction(isolate, global, name, JS_ERROR_TYPE, kErrorObjectSize,
+ in_object_properties, factory->the_hole_value(),
+ error_constructor, error_function_length, false);
if (context_index == Context::ERROR_FUNCTION_INDEX) {
SimpleInstallFunction(isolate, error_fun, "captureStackTrace",
@@ -1634,9 +1641,7 @@
Handle<JSFunction> obj_func = InstallFunction( \
isolate, temporal, #N, JS_TEMPORAL_##U##_TYPE, \
JSTemporal##N::kHeaderSize, 0, isolate->factory()->the_hole_value(), \
- Builtin::kTemporal##N##Constructor); \
- obj_func->shared()->set_length(NUM_ARGS); \
- obj_func->shared()->DontAdaptArguments(); \
+ Builtin::kTemporal##N##Constructor, NUM_ARGS, false); \
InstallWithIntrinsicDefaultProto(isolate, obj_func, \
Context::JS_TEMPORAL_##U##_FUNCTION_INDEX); \
Handle<JSObject> prototype(Cast<JSObject>(obj_func->instance_prototype()), \
@@ -2418,12 +2423,10 @@
Handle<JSFunction> function_fun =
InstallFunction(isolate_, global, "Function", JS_FUNCTION_TYPE,
JSFunction::kSizeWithPrototype, 0, prototype,
- Builtin::kFunctionConstructor);
+ Builtin::kFunctionConstructor, 1, false);
// Function instances are sloppy by default.
function_fun->set_prototype_or_initial_map(*isolate_->sloppy_function_map(),
kReleaseStore);
- function_fun->shared()->DontAdaptArguments();
- function_fun->shared()->set_length(1);
InstallWithIntrinsicDefaultProto(isolate_, function_fun,
Context::FUNCTION_FUNCTION_INDEX);
native_context()->set_function_prototype(*prototype);
@@ -2473,14 +2476,12 @@
DirectHandle<JSFunction> array_prototype_to_string_fun;
{ // --- A r r a y ---
+ // This seems a bit hackish, but we need to make sure Array.length is 1.
+ int length = 1;
Handle<JSFunction> array_function = InstallFunction(
isolate_, global, "Array", JS_ARRAY_TYPE, JSArray::kHeaderSize, 0,
- isolate_->initial_object_prototype(), Builtin::kArrayConstructor);
- array_function->shared()->DontAdaptArguments();
-
- // This seems a bit hackish, but we need to make sure Array.length
- // is 1.
- array_function->shared()->set_length(1);
+ isolate_->initial_object_prototype(), Builtin::kArrayConstructor,
+ length, false);
Handle<Map> initial_map(array_function->initial_map(), isolate());
@@ -2673,7 +2674,7 @@
DirectHandle<JSFunction> array_iterator_function =
CreateFunction(isolate_, factory->ArrayIterator_string(),
JS_ARRAY_ITERATOR_TYPE, JSArrayIterator::kHeaderSize, 0,
- array_iterator_prototype, Builtin::kIllegal);
+ array_iterator_prototype, Builtin::kIllegal, 0, true);
array_iterator_function->shared()->set_native(false);
native_context()->set_initial_array_iterator_map(
@@ -2683,12 +2684,11 @@
}
{ // --- N u m b e r ---
- Handle<JSFunction> number_fun = InstallFunction(
- isolate_, global, "Number", JS_PRIMITIVE_WRAPPER_TYPE,
- JSPrimitiveWrapper::kHeaderSize, 0,
- isolate_->initial_object_prototype(), Builtin::kNumberConstructor);
- number_fun->shared()->DontAdaptArguments();
- number_fun->shared()->set_length(1);
+ Handle<JSFunction> number_fun =
+ InstallFunction(isolate_, global, "Number", JS_PRIMITIVE_WRAPPER_TYPE,
+ JSPrimitiveWrapper::kHeaderSize, 0,
+ isolate_->initial_object_prototype(),
+ Builtin::kNumberConstructor, 1, false);
InstallWithIntrinsicDefaultProto(isolate_, number_fun,
Context::NUMBER_FUNCTION_INDEX);
@@ -2768,12 +2768,11 @@
}
{ // --- B o o l e a n ---
- Handle<JSFunction> boolean_fun = InstallFunction(
- isolate_, global, "Boolean", JS_PRIMITIVE_WRAPPER_TYPE,
- JSPrimitiveWrapper::kHeaderSize, 0,
- isolate_->initial_object_prototype(), Builtin::kBooleanConstructor);
- boolean_fun->shared()->DontAdaptArguments();
- boolean_fun->shared()->set_length(1);
+ Handle<JSFunction> boolean_fun =
+ InstallFunction(isolate_, global, "Boolean", JS_PRIMITIVE_WRAPPER_TYPE,
+ JSPrimitiveWrapper::kHeaderSize, 0,
+ isolate_->initial_object_prototype(),
+ Builtin::kBooleanConstructor, 1, false);
InstallWithIntrinsicDefaultProto(isolate_, boolean_fun,
Context::BOOLEAN_FUNCTION_INDEX);
@@ -2795,12 +2794,11 @@
}
{ // --- S t r i n g ---
- Handle<JSFunction> string_fun = InstallFunction(
- isolate_, global, "String", JS_PRIMITIVE_WRAPPER_TYPE,
- JSPrimitiveWrapper::kHeaderSize, 0,
- isolate_->initial_object_prototype(), Builtin::kStringConstructor);
- string_fun->shared()->DontAdaptArguments();
- string_fun->shared()->set_length(1);
+ Handle<JSFunction> string_fun =
+ InstallFunction(isolate_, global, "String", JS_PRIMITIVE_WRAPPER_TYPE,
+ JSPrimitiveWrapper::kHeaderSize, 0,
+ isolate_->initial_object_prototype(),
+ Builtin::kStringConstructor, 1, false);
InstallWithIntrinsicDefaultProto(isolate_, string_fun,
Context::STRING_FUNCTION_INDEX);
@@ -2993,7 +2991,7 @@
DirectHandle<JSFunction> string_iterator_function = CreateFunction(
isolate_, factory->InternalizeUtf8String("StringIterator"),
JS_STRING_ITERATOR_TYPE, JSStringIterator::kHeaderSize, 0,
- string_iterator_prototype, Builtin::kIllegal);
+ string_iterator_prototype, Builtin::kIllegal, 0, true);
string_iterator_function->shared()->set_native(false);
native_context()->set_initial_string_iterator_map(
string_iterator_function->initial_map());
@@ -3002,12 +3000,10 @@
}
{ // --- S y m b o l ---
- Handle<JSFunction> symbol_fun =
- InstallFunction(isolate_, global, "Symbol", JS_PRIMITIVE_WRAPPER_TYPE,
- JSPrimitiveWrapper::kHeaderSize, 0,
- factory->the_hole_value(), Builtin::kSymbolConstructor);
- symbol_fun->shared()->set_length(0);
- symbol_fun->shared()->DontAdaptArguments();
+ Handle<JSFunction> symbol_fun = InstallFunction(
+ isolate_, global, "Symbol", JS_PRIMITIVE_WRAPPER_TYPE,
+ JSPrimitiveWrapper::kHeaderSize, 0, factory->the_hole_value(),
+ Builtin::kSymbolConstructor, 0, false);
native_context()->set_symbol_function(*symbol_fun);
// Install the Symbol.for and Symbol.keyFor functions.
@@ -3069,11 +3065,9 @@
{ // --- D a t e ---
Handle<JSFunction> date_fun = InstallFunction(
isolate_, global, "Date", JS_DATE_TYPE, JSDate::kHeaderSize, 0,
- factory->the_hole_value(), Builtin::kDateConstructor);
+ factory->the_hole_value(), Builtin::kDateConstructor, 7, false);
InstallWithIntrinsicDefaultProto(isolate_, date_fun,
Context::DATE_FUNCTION_INDEX);
- date_fun->shared()->set_length(7);
- date_fun->shared()->DontAdaptArguments();
// Install the Date.now, Date.parse and Date.UTC functions.
SimpleInstallFunction(isolate_, date_fun, "now", Builtin::kDateNow, 0,
@@ -3204,14 +3198,10 @@
Handle<JSFunction> promise_fun = InstallFunction(
isolate_, global, "Promise", JS_PROMISE_TYPE,
JSPromise::kSizeWithEmbedderFields, 0, factory->the_hole_value(),
- Builtin::kPromiseConstructor);
+ Builtin::kPromiseConstructor, 1, true);
InstallWithIntrinsicDefaultProto(isolate_, promise_fun,
Context::PROMISE_FUNCTION_INDEX);
- DirectHandle<SharedFunctionInfo> shared(promise_fun->shared(), isolate_);
- shared->set_internal_formal_parameter_count(JSParameterCount(1));
- shared->set_length(1);
-
InstallSpeciesGetter(isolate_, promise_fun);
DirectHandle<JSFunction> promise_all = InstallFunctionWithBuiltinId(
@@ -3275,12 +3265,9 @@
isolate_, global, "RegExp", JS_REG_EXP_TYPE,
JSRegExp::kHeaderSize + JSRegExp::kInObjectFieldCount * kTaggedSize,
JSRegExp::kInObjectFieldCount, factory->the_hole_value(),
- Builtin::kRegExpConstructor);
+ Builtin::kRegExpConstructor, 2, true);
InstallWithIntrinsicDefaultProto(isolate_, regexp_fun,
Context::REGEXP_FUNCTION_INDEX);
- DirectHandle<SharedFunctionInfo> shared(regexp_fun->shared(), isolate_);
- shared->set_internal_formal_parameter_count(JSParameterCount(2));
- shared->set_length(2);
{
// Setup %RegExpPrototype%.
@@ -3487,7 +3474,7 @@
DirectHandle<JSFunction> regexp_string_iterator_function = CreateFunction(
isolate(), "RegExpStringIterator", JS_REG_EXP_STRING_ITERATOR_TYPE,
JSRegExpStringIterator::kHeaderSize, 0,
- regexp_string_iterator_prototype, Builtin::kIllegal);
+ regexp_string_iterator_prototype, Builtin::kIllegal, 0, true);
regexp_string_iterator_function->shared()->set_native(false);
native_context()->set_initial_regexp_string_iterator_prototype_map(
regexp_string_iterator_function->initial_map());
@@ -3679,9 +3666,7 @@
Handle<JSFunction> date_time_format_constructor = InstallFunction(
isolate_, intl, "DateTimeFormat", JS_DATE_TIME_FORMAT_TYPE,
JSDateTimeFormat::kHeaderSize, 0, factory->the_hole_value(),
- Builtin::kDateTimeFormatConstructor);
- date_time_format_constructor->shared()->set_length(0);
- date_time_format_constructor->shared()->DontAdaptArguments();
+ Builtin::kDateTimeFormatConstructor, 0, false);
InstallWithIntrinsicDefaultProto(
isolate_, date_time_format_constructor,
Context::INTL_DATE_TIME_FORMAT_FUNCTION_INDEX);
@@ -3718,9 +3703,7 @@
Handle<JSFunction> number_format_constructor = InstallFunction(
isolate_, intl, "NumberFormat", JS_NUMBER_FORMAT_TYPE,
JSNumberFormat::kHeaderSize, 0, factory->the_hole_value(),
- Builtin::kNumberFormatConstructor);
- number_format_constructor->shared()->set_length(0);
- number_format_constructor->shared()->DontAdaptArguments();
+ Builtin::kNumberFormatConstructor, 0, false);
InstallWithIntrinsicDefaultProto(
isolate_, number_format_constructor,
Context::INTL_NUMBER_FORMAT_FUNCTION_INDEX);
@@ -3753,10 +3736,10 @@
}
{ // -- C o l l a t o r
- Handle<JSFunction> collator_constructor = InstallFunction(
- isolate_, intl, "Collator", JS_COLLATOR_TYPE, JSCollator::kHeaderSize,
- 0, factory->the_hole_value(), Builtin::kCollatorConstructor);
- collator_constructor->shared()->DontAdaptArguments();
+ Handle<JSFunction> collator_constructor =
+ InstallFunction(isolate_, intl, "Collator", JS_COLLATOR_TYPE,
+ JSCollator::kHeaderSize, 0, factory->the_hole_value(),
+ Builtin::kCollatorConstructor, 0, false);
InstallWithIntrinsicDefaultProto(isolate_, collator_constructor,
Context::INTL_COLLATOR_FUNCTION_INDEX);
@@ -3781,8 +3764,7 @@
Handle<JSFunction> v8_break_iterator_constructor = InstallFunction(
isolate_, intl, "v8BreakIterator", JS_V8_BREAK_ITERATOR_TYPE,
JSV8BreakIterator::kHeaderSize, 0, factory->the_hole_value(),
- Builtin::kV8BreakIteratorConstructor);
- v8_break_iterator_constructor->shared()->DontAdaptArguments();
+ Builtin::kV8BreakIteratorConstructor, 0, false);
SimpleInstallFunction(
isolate_, v8_break_iterator_constructor, "supportedLocalesOf",
@@ -3817,8 +3799,7 @@
Handle<JSFunction> plural_rules_constructor = InstallFunction(
isolate_, intl, "PluralRules", JS_PLURAL_RULES_TYPE,
JSPluralRules::kHeaderSize, 0, factory->the_hole_value(),
- Builtin::kPluralRulesConstructor);
- plural_rules_constructor->shared()->DontAdaptArguments();
+ Builtin::kPluralRulesConstructor, 0, false);
InstallWithIntrinsicDefaultProto(
isolate_, plural_rules_constructor,
Context::INTL_PLURAL_RULES_FUNCTION_INDEX);
@@ -3848,9 +3829,7 @@
Handle<JSFunction> relative_time_format_fun = InstallFunction(
isolate(), intl, "RelativeTimeFormat", JS_RELATIVE_TIME_FORMAT_TYPE,
JSRelativeTimeFormat::kHeaderSize, 0, factory->the_hole_value(),
- Builtin::kRelativeTimeFormatConstructor);
- relative_time_format_fun->shared()->set_length(0);
- relative_time_format_fun->shared()->DontAdaptArguments();
+ Builtin::kRelativeTimeFormatConstructor, 0, false);
InstallWithIntrinsicDefaultProto(
isolate_, relative_time_format_fun,
Context::INTL_RELATIVE_TIME_FORMAT_FUNCTION_INDEX);
@@ -3881,9 +3860,7 @@
Handle<JSFunction> list_format_fun = InstallFunction(
isolate(), intl, "ListFormat", JS_LIST_FORMAT_TYPE,
JSListFormat::kHeaderSize, 0, factory->the_hole_value(),
- Builtin::kListFormatConstructor);
- list_format_fun->shared()->set_length(0);
- list_format_fun->shared()->DontAdaptArguments();
+ Builtin::kListFormatConstructor, 0, false);
InstallWithIntrinsicDefaultProto(
isolate_, list_format_fun, Context::INTL_LIST_FORMAT_FUNCTION_INDEX);
@@ -3909,11 +3886,9 @@
{ // -- L o c a l e
Handle<JSFunction> locale_fun = InstallFunction(
isolate(), intl, "Locale", JS_LOCALE_TYPE, JSLocale::kHeaderSize, 0,
- factory->the_hole_value(), Builtin::kLocaleConstructor);
+ factory->the_hole_value(), Builtin::kLocaleConstructor, 1, false);
InstallWithIntrinsicDefaultProto(isolate(), locale_fun,
Context::INTL_LOCALE_FUNCTION_INDEX);
- locale_fun->shared()->set_length(1);
- locale_fun->shared()->DontAdaptArguments();
// Setup %LocalePrototype%.
Handle<JSObject> prototype(
@@ -3978,9 +3953,7 @@
Handle<JSFunction> display_names_fun = InstallFunction(
isolate(), intl, "DisplayNames", JS_DISPLAY_NAMES_TYPE,
JSDisplayNames::kHeaderSize, 0, factory->the_hole_value(),
- Builtin::kDisplayNamesConstructor);
- display_names_fun->shared()->set_length(2);
- display_names_fun->shared()->DontAdaptArguments();
+ Builtin::kDisplayNamesConstructor, 2, false);
InstallWithIntrinsicDefaultProto(
isolate(), display_names_fun,
Context::INTL_DISPLAY_NAMES_FUNCTION_INDEX);
@@ -4008,9 +3981,7 @@
Handle<JSFunction> segmenter_fun = InstallFunction(
isolate(), intl, "Segmenter", JS_SEGMENTER_TYPE,
JSSegmenter::kHeaderSize, 0, factory->the_hole_value(),
- Builtin::kSegmenterConstructor);
- segmenter_fun->shared()->set_length(0);
- segmenter_fun->shared()->DontAdaptArguments();
+ Builtin::kSegmenterConstructor, 0, false);
InstallWithIntrinsicDefaultProto(isolate_, segmenter_fun,
Context::INTL_SEGMENTER_FUNCTION_INDEX);
SimpleInstallFunction(isolate(), segmenter_fun, "supportedLocalesOf",
@@ -4041,10 +4012,8 @@
.ToHandleChecked();
DirectHandle<JSFunction> segments_fun = CreateFunction(
isolate(), name_string, JS_SEGMENTS_TYPE, JSSegments::kHeaderSize,
- 0, prototype, Builtin::kIllegal);
+ 0, prototype, Builtin::kIllegal, 0, false);
segments_fun->shared()->set_native(false);
- segments_fun->shared()->set_length(0);
- segments_fun->shared()->DontAdaptArguments();
SimpleInstallFunction(isolate(), prototype, "containing",
Builtin::kSegmentsPrototypeContaining, 1, false);
InstallFunctionAtSymbol(isolate_, prototype, factory->iterator_symbol(),
@@ -4074,9 +4043,10 @@
Handle<String> name_string =
Name::ToFunctionName(isolate(), factory->SegmentIterator_string())
.ToHandleChecked();
- DirectHandle<JSFunction> segment_iterator_fun = CreateFunction(
- isolate(), name_string, JS_SEGMENT_ITERATOR_TYPE,
- JSSegmentIterator::kHeaderSize, 0, prototype, Builtin::kIllegal);
+ DirectHandle<JSFunction> segment_iterator_fun =
+ CreateFunction(isolate(), name_string, JS_SEGMENT_ITERATOR_TYPE,
+ JSSegmentIterator::kHeaderSize, 0, prototype,
+ Builtin::kIllegal, 0, true);
segment_iterator_fun->shared()->set_native(false);
DirectHandle<Map> segment_iterator_map(
segment_iterator_fun->initial_map(), isolate());
@@ -4238,12 +4208,12 @@
}
{ // -- T y p e d A r r a y
- Handle<JSFunction> typed_array_fun = CreateFunction(
- isolate_, factory->InternalizeUtf8String("TypedArray"),
- JS_TYPED_ARRAY_TYPE, JSTypedArray::kHeaderSize, 0,
- factory->the_hole_value(), Builtin::kTypedArrayBaseConstructor);
+ Handle<JSFunction> typed_array_fun =
+ CreateFunction(isolate_, factory->InternalizeUtf8String("TypedArray"),
+ JS_TYPED_ARRAY_TYPE, JSTypedArray::kHeaderSize, 0,
+ factory->the_hole_value(),
+ Builtin::kTypedArrayBaseConstructor, 0, true);
typed_array_fun->shared()->set_native(false);
- typed_array_fun->shared()->set_length(0);
InstallSpeciesGetter(isolate_, typed_array_fun);
native_context()->set_typed_array_function(*typed_array_fun);
@@ -4360,11 +4330,9 @@
Handle<JSFunction> data_view_fun = InstallFunction(
isolate_, global, "DataView", JS_DATA_VIEW_TYPE,
JSDataView::kSizeWithEmbedderFields, 0, factory->the_hole_value(),
- Builtin::kDataViewConstructor);
+ Builtin::kDataViewConstructor, 1, false);
InstallWithIntrinsicDefaultProto(isolate_, data_view_fun,
Context::DATA_VIEW_FUN_INDEX);
- data_view_fun->shared()->set_length(1);
- data_view_fun->shared()->DontAdaptArguments();
// Setup %DataViewPrototype%.
Handle<JSObject> prototype(
@@ -4435,14 +4403,10 @@
{ // -- M a p
Handle<JSFunction> js_map_fun = InstallFunction(
isolate_, global, "Map", JS_MAP_TYPE, JSMap::kHeaderSize, 0,
- factory->the_hole_value(), Builtin::kMapConstructor);
+ factory->the_hole_value(), Builtin::kMapConstructor, 0, false);
InstallWithIntrinsicDefaultProto(isolate_, js_map_fun,
Context::JS_MAP_FUN_INDEX);
- DirectHandle<SharedFunctionInfo> shared(js_map_fun->shared(), isolate_);
- shared->DontAdaptArguments();
- shared->set_length(0);
-
SimpleInstallFunction(isolate_, js_map_fun, "groupBy", Builtin::kMapGroupBy,
2, true);
@@ -4497,12 +4461,10 @@
}
{ // -- B i g I n t
- Handle<JSFunction> bigint_fun =
- InstallFunction(isolate_, global, "BigInt", JS_PRIMITIVE_WRAPPER_TYPE,
- JSPrimitiveWrapper::kHeaderSize, 0,
- factory->the_hole_value(), Builtin::kBigIntConstructor);
- bigint_fun->shared()->DontAdaptArguments();
- bigint_fun->shared()->set_length(1);
+ Handle<JSFunction> bigint_fun = InstallFunction(
+ isolate_, global, "BigInt", JS_PRIMITIVE_WRAPPER_TYPE,
+ JSPrimitiveWrapper::kHeaderSize, 0, factory->the_hole_value(),
+ Builtin::kBigIntConstructor, 1, false);
InstallWithIntrinsicDefaultProto(isolate_, bigint_fun,
Context::BIGINT_FUNCTION_INDEX);
@@ -4537,14 +4499,10 @@
{ // -- S e t
Handle<JSFunction> js_set_fun = InstallFunction(
isolate_, global, "Set", JS_SET_TYPE, JSSet::kHeaderSize, 0,
- factory->the_hole_value(), Builtin::kSetConstructor);
+ factory->the_hole_value(), Builtin::kSetConstructor, 0, false);
InstallWithIntrinsicDefaultProto(isolate_, js_set_fun,
Context::JS_SET_FUN_INDEX);
- DirectHandle<SharedFunctionInfo> shared(js_set_fun->shared(), isolate_);
- shared->DontAdaptArguments();
- shared->set_length(0);
-
// Setup %SetPrototype%.
Handle<JSObject> prototype(Cast<JSObject>(js_set_fun->instance_prototype()),
isolate());
@@ -4625,14 +4583,10 @@
{ // -- W e a k M a p
Handle<JSFunction> cons = InstallFunction(
isolate_, global, "WeakMap", JS_WEAK_MAP_TYPE, JSWeakMap::kHeaderSize,
- 0, factory->the_hole_value(), Builtin::kWeakMapConstructor);
+ 0, factory->the_hole_value(), Builtin::kWeakMapConstructor, 0, false);
InstallWithIntrinsicDefaultProto(isolate_, cons,
Context::JS_WEAK_MAP_FUN_INDEX);
- DirectHandle<SharedFunctionInfo> shared(cons->shared(), isolate_);
- shared->DontAdaptArguments();
- shared->set_length(0);
-
// Setup %WeakMapPrototype%.
Handle<JSObject> prototype(Cast<JSObject>(cons->instance_prototype()),
isolate());
@@ -4664,14 +4618,10 @@
{ // -- W e a k S e t
Handle<JSFunction> cons = InstallFunction(
isolate_, global, "WeakSet", JS_WEAK_SET_TYPE, JSWeakSet::kHeaderSize,
- 0, factory->the_hole_value(), Builtin::kWeakSetConstructor);
+ 0, factory->the_hole_value(), Builtin::kWeakSetConstructor, 0, false);
InstallWithIntrinsicDefaultProto(isolate_, cons,
Context::JS_WEAK_SET_FUN_INDEX);
- DirectHandle<SharedFunctionInfo> shared(cons->shared(), isolate_);
- shared->DontAdaptArguments();
- shared->set_length(0);
-
// Setup %WeakSetPrototype%.
Handle<JSObject> prototype(Cast<JSObject>(cons->instance_prototype()),
isolate());
@@ -4704,15 +4654,12 @@
proxy_function_map->set_is_constructor(true);
Handle<String> name = factory->Proxy_string();
- Handle<JSFunction> proxy_function = CreateFunctionForBuiltin(
- isolate(), name, proxy_function_map, Builtin::kProxyConstructor);
+ Handle<JSFunction> proxy_function =
+ CreateFunctionForBuiltin(isolate(), name, proxy_function_map,
+ Builtin::kProxyConstructor, 2, true);
isolate_->proxy_map()->SetConstructor(*proxy_function);
- proxy_function->shared()->set_internal_formal_parameter_count(
- JSParameterCount(2));
- proxy_function->shared()->set_length(2);
-
native_context()->set_proxy_function(*proxy_function);
JSObject::AddProperty(isolate_, global, name, proxy_function, DONT_ENUM);
@@ -4805,14 +4752,12 @@
Handle<JSFunction> finalization_registry_fun = InstallFunction(
isolate_, global, factory->FinalizationRegistry_string(),
JS_FINALIZATION_REGISTRY_TYPE, JSFinalizationRegistry::kHeaderSize, 0,
- factory->the_hole_value(), Builtin::kFinalizationRegistryConstructor);
+ factory->the_hole_value(), Builtin::kFinalizationRegistryConstructor, 1,
+ false);
InstallWithIntrinsicDefaultProto(
isolate_, finalization_registry_fun,
Context::JS_FINALIZATION_REGISTRY_FUNCTION_INDEX);
- finalization_registry_fun->shared()->DontAdaptArguments();
- finalization_registry_fun->shared()->set_length(1);
-
Handle<JSObject> finalization_registry_prototype(
Cast<JSObject>(finalization_registry_fun->instance_prototype()),
isolate());
@@ -4840,13 +4785,10 @@
{ // -- W e a k R e f
Handle<JSFunction> weak_ref_fun = InstallFunction(
isolate_, global, "WeakRef", JS_WEAK_REF_TYPE, JSWeakRef::kHeaderSize,
- 0, factory->the_hole_value(), Builtin::kWeakRefConstructor);
+ 0, factory->the_hole_value(), Builtin::kWeakRefConstructor, 1, false);
InstallWithIntrinsicDefaultProto(isolate_, weak_ref_fun,
Context::JS_WEAK_REF_FUNCTION_INDEX);
- weak_ref_fun->shared()->DontAdaptArguments();
- weak_ref_fun->shared()->set_length(1);
-
Handle<JSObject> weak_ref_prototype(
Cast<JSObject>(weak_ref_fun->instance_prototype()), isolate());
@@ -4861,7 +4803,7 @@
DirectHandle<JSFunction> function = CreateFunctionForBuiltinWithPrototype(
isolate(), arguments_string, Builtin::kIllegal,
isolate()->initial_object_prototype(), JS_ARGUMENTS_OBJECT_TYPE,
- JSSloppyArgumentsObject::kSize, 2, MUTABLE);
+ JSSloppyArgumentsObject::kSize, 2, MUTABLE, 0, true);
DirectHandle<Map> map(function->initial_map(), isolate());
// Create the descriptor array for the arguments object.
@@ -4954,7 +4896,8 @@
// Create a function for the context extension objects.
DirectHandle<JSFunction> context_extension_fun = CreateFunction(
isolate_, factory->empty_string(), JS_CONTEXT_EXTENSION_OBJECT_TYPE,
- JSObject::kHeaderSize, 0, factory->the_hole_value(), Builtin::kIllegal);
+ JSObject::kHeaderSize, 0, factory->the_hole_value(), Builtin::kIllegal,
+ 0, true);
native_context()->set_context_extension_function(*context_extension_fun);
}
@@ -4988,12 +4931,9 @@
Handle<JSFunction> result = InstallFunction(
isolate(), global, name, JS_TYPED_ARRAY_TYPE,
JSTypedArray::kSizeWithEmbedderFields, 0, factory()->the_hole_value(),
- Builtin::kTypedArrayConstructor);
+ Builtin::kTypedArrayConstructor, 3, false);
result->initial_map()->set_elements_kind(elements_kind);
- result->shared()->DontAdaptArguments();
- result->shared()->set_length(3);
-
CHECK(JSObject::SetPrototype(isolate(), result, typed_array_function, false,
kDontThrow)
.FromJust());
@@ -5134,11 +5074,9 @@
Handle<JSFunction> generator_function_function = CreateFunction(
isolate, "GeneratorFunction", JS_FUNCTION_TYPE,
JSFunction::kSizeWithPrototype, 0, generator_function_prototype,
- Builtin::kGeneratorFunctionConstructor);
+ Builtin::kGeneratorFunctionConstructor, 1, false);
generator_function_function->set_prototype_or_initial_map(
native_context->generator_function_map(), kReleaseStore);
- generator_function_function->shared()->DontAdaptArguments();
- generator_function_function->shared()->set_length(1);
InstallWithIntrinsicDefaultProto(
isolate, generator_function_function,
Context::GENERATOR_FUNCTION_FUNCTION_INDEX);
@@ -5165,11 +5103,9 @@
Handle<JSFunction> async_generator_function_function = CreateFunction(
isolate, "AsyncGeneratorFunction", JS_FUNCTION_TYPE,
JSFunction::kSizeWithPrototype, 0, async_generator_function_prototype,
- Builtin::kAsyncGeneratorFunctionConstructor);
+ Builtin::kAsyncGeneratorFunctionConstructor, 1, false);
async_generator_function_function->set_prototype_or_initial_map(
native_context->async_generator_function_map(), kReleaseStore);
- async_generator_function_function->shared()->DontAdaptArguments();
- async_generator_function_function->shared()->set_length(1);
InstallWithIntrinsicDefaultProto(
isolate, async_generator_function_function,
Context::ASYNC_GENERATOR_FUNCTION_FUNCTION_INDEX);
@@ -5207,7 +5143,7 @@
// Setup SetIterator constructor.
DirectHandle<JSFunction> set_iterator_function = CreateFunction(
isolate, "SetIterator", JS_SET_VALUE_ITERATOR_TYPE,
- JSSetIterator::kHeaderSize, 0, prototype, Builtin::kIllegal);
+ JSSetIterator::kHeaderSize, 0, prototype, Builtin::kIllegal, 0, true);
set_iterator_function->shared()->set_native(false);
Handle<Map> set_value_iterator_map(set_iterator_function->initial_map(),
@@ -5240,7 +5176,7 @@
// Setup MapIterator constructor.
DirectHandle<JSFunction> map_iterator_function = CreateFunction(
isolate, "MapIterator", JS_MAP_KEY_ITERATOR_TYPE,
- JSMapIterator::kHeaderSize, 0, prototype, Builtin::kIllegal);
+ JSMapIterator::kHeaderSize, 0, prototype, Builtin::kIllegal, 0, true);
map_iterator_function->shared()->set_native(false);
Handle<Map> map_key_iterator_map(map_iterator_function->initial_map(),
@@ -5268,11 +5204,9 @@
Handle<JSFunction> async_function_constructor = CreateFunction(
isolate, "AsyncFunction", JS_FUNCTION_TYPE,
JSFunction::kSizeWithPrototype, 0, async_function_prototype,
- Builtin::kAsyncFunctionConstructor);
+ Builtin::kAsyncFunctionConstructor, 1, false);
async_function_constructor->set_prototype_or_initial_map(
native_context->async_function_map(), kReleaseStore);
- async_function_constructor->shared()->DontAdaptArguments();
- async_function_constructor->shared()->set_length(1);
InstallWithIntrinsicDefaultProto(isolate, async_function_constructor,
Context::ASYNC_FUNCTION_FUNCTION_INDEX);
@@ -5314,8 +5248,7 @@
DirectHandle<JSFunction> callsite_fun = CreateFunction(
isolate(), "CallSite", JS_OBJECT_TYPE, JSObject::kHeaderSize, 0,
- factory->the_hole_value(), Builtin::kUnsupportedThrower);
- callsite_fun->shared()->DontAdaptArguments();
+ factory->the_hole_value(), Builtin::kUnsupportedThrower, 0, false);
isolate()->native_context()->set_callsite_function(*callsite_fun);
// Setup CallSite.prototype.
@@ -5462,9 +5395,7 @@
native_context()->initial_iterator_prototype(), isolate());
Handle<JSFunction> iterator_function = InstallFunction(
isolate(), global, "Iterator", JS_OBJECT_TYPE, JSObject::kHeaderSize, 0,
- iterator_prototype, Builtin::kIteratorConstructor);
- iterator_function->shared()->DontAdaptArguments();
- iterator_function->shared()->set_length(0);
+ iterator_prototype, Builtin::kIteratorConstructor, 0, false);
SimpleInstallFunction(isolate(), iterator_function, "from",
Builtin::kIteratorFrom, 1, true);
InstallWithIntrinsicDefaultProto(isolate(), iterator_function,
@@ -5626,9 +5557,7 @@
DirectHandle<JSFunction> shadow_realm_fun =
InstallFunction(isolate_, global, "ShadowRealm", JS_SHADOW_REALM_TYPE,
JSShadowRealm::kHeaderSize, 0, factory->the_hole_value(),
- Builtin::kShadowRealmConstructor);
- shadow_realm_fun->shared()->set_length(0);
- shadow_realm_fun->shared()->DontAdaptArguments();
+ Builtin::kShadowRealmConstructor, 0, false);
// Setup %ShadowRealmPrototype%.
Handle<JSObject> prototype(
@@ -5710,12 +5639,10 @@
Handle<JSFunction> shared_struct_type_fun = CreateFunctionForBuiltin(
isolate(), name,
isolate()->strict_function_with_readonly_prototype_map(),
- Builtin::kSharedStructTypeConstructor);
+ Builtin::kSharedStructTypeConstructor, 1, false);
JSObject::MakePrototypesFast(shared_struct_type_fun, kStartAtReceiver,
isolate());
shared_struct_type_fun->shared()->set_native(true);
- shared_struct_type_fun->shared()->DontAdaptArguments();
- shared_struct_type_fun->shared()->set_length(1);
JSObject::AddProperty(isolate(), global, "SharedStructType",
shared_struct_type_fun, DONT_ENUM);
@@ -5839,11 +5766,9 @@
Handle<JSFunction> disposable_stack_function = InstallFunction(
isolate(), global, "DisposableStack", JS_SYNC_DISPOSABLE_STACK_TYPE,
JSSyncDisposableStack::kHeaderSize, 0, sync_disposable_stack_prototype,
- Builtin::kDisposableStackConstructor);
+ Builtin::kDisposableStackConstructor, 0, false);
InstallWithIntrinsicDefaultProto(isolate(), disposable_stack_function,
Context::JS_DISPOSABLE_STACK_FUNCTION_INDEX);
- disposable_stack_function->shared()->DontAdaptArguments();
- disposable_stack_function->shared()->set_length(0);
SimpleInstallFunction(isolate(), sync_disposable_stack_prototype, "use",
Builtin::kDisposableStackPrototypeUse, 1, true);
SimpleInstallFunction(isolate(), sync_disposable_stack_prototype, "dispose",
@@ -5969,9 +5894,7 @@
Handle<JSFunction> duration_format_fun = InstallFunction(
isolate(), intl, "DurationFormat", JS_DURATION_FORMAT_TYPE,
JSDurationFormat::kHeaderSize, 0, factory()->the_hole_value(),
- Builtin::kDurationFormatConstructor);
- duration_format_fun->shared()->set_length(0);
- duration_format_fun->shared()->DontAdaptArguments();
+ Builtin::kDurationFormatConstructor, 0, false);
InstallWithIntrinsicDefaultProto(
isolate(), duration_format_fun,
Context::INTL_DURATION_FORMAT_FUNCTION_INDEX);
@@ -6008,9 +5931,7 @@
Handle<JSFunction> array_buffer_fun =
CreateFunction(isolate(), name, JS_ARRAY_BUFFER_TYPE,
JSArrayBuffer::kSizeWithEmbedderFields, 0, prototype,
- Builtin::kArrayBufferConstructor);
- array_buffer_fun->shared()->DontAdaptArguments();
- array_buffer_fun->shared()->set_length(1);
+ Builtin::kArrayBufferConstructor, 1, false);
// Install the "constructor" property on the {prototype}.
JSObject::AddProperty(isolate(), prototype, factory()->constructor_string(),
```
Change information
Commit message:
[handles] Migration to direct handles, part 5
This CL migrates a large number of handles to direct handles. The
changes are only relevant for builds with v8_enable_direct_handle=true.
Bug: 42203211
Cq-Include-Trybots: luci.v8.try:v8_linux64_css_dbg
Change-Id: I57d35b99ec3bd83bc2ba5590ad18021bc4e34592
Reviewed-by: Omer Katz <omer...@chromium.org>
Commit-Queue: Nikolaos Papaspyrou <niko...@chromium.org>
Reviewed-by: Leszek Swirski <les...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#95576}
Files:
- M src/api/api-arguments-inl.h
- M src/api/api-natives.cc
- M src/api/api.cc
- M src/ast/scopes.cc
- M src/ast/scopes.h
- M src/baseline/baseline-batch-compiler.cc
- M src/baseline/baseline-batch-compiler.h
- M src/builtins/accessors.cc
- M src/builtins/builtins-api.cc
- M src/builtins/builtins-array.cc
- M src/builtins/builtins-async-disposable-stack.cc
- M src/builtins/builtins-atomics-synchronization.cc
- M src/builtins/builtins-console.cc
- M src/builtins/builtins-function.cc
- M src/builtins/builtins-intl.cc
- M src/builtins/builtins-sharedarraybuffer.cc
- M src/builtins/setup-builtins-internal.cc
- M src/codegen/compilation-cache.cc
- M src/codegen/compilation-cache.h
- M src/codegen/compiler.cc
- M src/codegen/compiler.h
- M src/compiler/basic-block-instrumentor.cc
- M src/compiler/heap-refs.cc
- M src/compiler/js-call-reducer.cc
- M src/compiler/pipeline.cc
- M src/compiler/turboshaft/operations.h
- M src/compiler/wasm-compiler.cc
- M src/debug/debug-coverage.cc
- M src/debug/debug-interface.cc
- M src/debug/debug-scopes.cc
- M src/debug/debug-wasm-objects.cc
- M src/debug/debug.cc
- M src/debug/debug.h
- M src/deoptimizer/translated-state.cc
- M src/diagnostics/disassembler.cc
- M src/execution/frames.cc
- M src/execution/futex-emulation.cc
- M src/execution/isolate.cc
- M src/execution/isolate.h
- M src/execution/messages.cc
- M src/execution/tiering-manager.cc
- M src/execution/tiering-manager.h
- M src/heap/factory.cc
- M src/heap/factory.h
- M src/heap/memory-measurement.cc
- M src/heap/setup-heap-internal.cc
- M src/ic/ic.cc
- M src/ic/ic.h
- M src/init/bootstrapper.cc
- M src/interpreter/interpreter.cc
- M src/json/json-parser.cc
- M src/json/json-parser.h
- M src/json/json-stringifier.cc
- M src/logging/log.cc
- M src/maglev/maglev-compilation-info.cc
- M src/objects/call-site-info.cc
- M src/objects/call-site-info.h
- M src/objects/elements.cc
- M src/objects/elements.h
- M src/objects/feedback-vector.cc
- M src/objects/intl-objects.cc
- M src/objects/intl-objects.h
- M src/objects/js-atomics-synchronization.cc
- M src/objects/js-atomics-synchronization.h
- M src/objects/js-break-iterator.cc
- M src/objects/js-date-time-format.cc
- M src/objects/js-duration-format.cc
- M src/objects/js-function.cc
- M src/objects/js-function.h
- M src/objects/js-list-format.cc
- M src/objects/js-locale.cc
- M src/objects/js-number-format.cc
- M src/objects/js-objects-inl.h
- M src/objects/js-objects.cc
- M src/objects/js-objects.h
- M src/objects/js-relative-time-format.cc
- M src/objects/js-segment-iterator.cc
- M src/objects/js-segmenter.cc
- M src/objects/js-struct.cc
- M src/objects/js-temporal-objects.cc
- M src/objects/js-temporal-objects.h
- M src/objects/keys.cc
- M src/objects/keys.h
- M src/objects/literal-objects.cc
- M src/objects/lookup.cc
- M src/objects/map.cc
- M src/objects/map.h
- M src/objects/objects.cc
- M src/objects/objects.h
- M src/objects/ordered-hash-table.cc
- M src/objects/ordered-hash-table.h
- M src/objects/script.h
- M src/objects/source-text-module.cc
- M src/objects/templates.cc
- M src/objects/transitions.cc
- M src/objects/transitions.h
- M src/objects/value-serializer.cc
- M src/parsing/parser.cc
- M src/parsing/parser.h
- M src/parsing/parsing.cc
- M src/parsing/parsing.h
- M src/profiler/sampling-heap-profiler.cc
- M src/regexp/regexp.cc
- M src/regexp/regexp.h
- M src/runtime/runtime-array.cc
- M src/runtime/runtime-atomics.cc
- M src/runtime/runtime-bigint.cc
- M src/runtime/runtime-classes.cc
- M src/runtime/runtime-debug.cc
- M src/runtime/runtime-internal.cc
- M src/runtime/runtime-object.cc
- M src/runtime/runtime-regexp.cc
- M src/runtime/runtime-scopes.cc
- M src/runtime/runtime-test.cc
- M src/runtime/runtime-wasm.cc
- M src/snapshot/code-serializer.cc
- M src/wasm/c-api.cc
- M src/wasm/module-compiler.cc
- M src/wasm/module-instantiate.cc
- M src/wasm/wasm-debug.cc
- M src/wasm/wasm-engine.cc
- M src/wasm/wasm-engine.h
- M src/wasm/wasm-js.cc
- M src/wasm/wasm-module.cc
- M src/wasm/wasm-objects.cc
- M src/wasm/wasm-objects.h
- M src/wasm/wasm-serialization.cc
- M test/cctest/compiler/function-tester.h
- M test/cctest/compiler/test-code-generator.cc
- M test/cctest/compiler/test-run-native-calls.cc
- M test/cctest/compiler/test-run-variables.cc
- M test/cctest/heap/test-compaction.cc
- M test/cctest/heap/test-heap.cc
- M test/cctest/heap/test-memory-measurement.cc
- M test/cctest/test-api.cc
- M test/cctest/test-code-stub-assembler.cc
- M test/cctest/test-debug.cc
- M test/cctest/test-field-type-tracking.cc
- M test/cctest/test-func-name-inference.cc
- M test/cctest/test-heap-profiler.cc
- M test/cctest/test-inobject-slack-tracking.cc
- M test/cctest/test-js-weak-refs.cc
- M test/cctest/test-orderedhashtable.cc
- M test/cctest/test-serialize.cc
- M test/cctest/test-strings.cc
- M test/cctest/wasm/test-run-wasm-wrappers.cc
- M test/cctest/wasm/test-wasm-breakpoints.cc
- M test/cctest/wasm/test-wasm-stack.cc
- M test/cctest/wasm/test-wasm-trap-position.cc
- M test/cctest/wasm/wasm-run-utils.cc
- M test/fuzzer/regexp.cc
- M test/fuzzer/wasm-deopt.cc
- M test/unittests/api/deserialize-unittest.cc
- M test/unittests/codegen/code-pages-unittest.cc
- M test/unittests/compiler/compiler-unittest.cc
- M test/unittests/compiler/function-tester.h
- M test/unittests/compiler/run-jscalls-unittest.cc
- M test/unittests/execution/microtask-queue-unittest.cc
- M test/unittests/heap/heap-unittest.cc
- M test/unittests/heap/local-factory-unittest.cc
- M test/unittests/heap/local-handles-unittest.cc
- M test/unittests/heap/persistent-handles-unittest.cc
- M test/unittests/heap/shared-heap-unittest.cc
- M test/unittests/interpreter/constant-array-builder-unittest.cc
- M test/unittests/interpreter/interpreter-unittest.cc
- M test/unittests/numbers/bigint-unittest.cc
- M test/unittests/numbers/conversions-unittest.cc
- M test/unittests/objects/concurrent-prototype-unittest.cc
- M test/unittests/objects/elements-kind-unittest.cc
- M test/unittests/objects/hashcode-unittest.cc
- M test/unittests/objects/object-unittest.cc
- M test/unittests/objects/value-serializer-unittest.cc
- M test/unittests/parser/parsing-unittest.cc
- M test/unittests/parser/preparser-unittest.cc
- M test/unittests/regexp/regexp-fuzzer.cc
- M test/unittests/regexp/regexp-unittest.cc
- M test/unittests/regress/regress-crbug-1056054-unittest.cc
Change size: XL
Delta: 177 files changed, 1065 insertions(+), 988 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Leszek Swirski, +1 by Omer Katz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Deepti Gandluri (Gerrit)
Aug 12, 2024, 4:48:29 PM8/12/24
to V8 LUCI CQ, Nikolaos Papaspyrou, Leszek Swirski, Omer Katz, Hannes Payer, devtools-...@chromium.org, dmercadi...@chromium.org, jgrube...@chromium.org, leszek...@chromium.org, marja...@chromium.org, mlippau...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org, was...@google.com
Deepti Gandluri has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages