Introduce DevtoolsSession::{Add,Remove}ScriptToEvaluateOnNewDocument [chromium/src : main]
gwsq (Gerrit)
Message from gwsq![]( "Open in Gerrit")
From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: ff...@chromium.org
📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).
IPC reviewer(s): ff...@chromium.org
Reviewer source(s):
ff...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)
Related details
- Dmitry Gozman
- Fred Shih
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dmitry Gozman (Gerrit)
Dmitry Gozman voted Code-Review+1![]( "Open in Gerrit")
- Andrey Kosyakov
- Fred Shih
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fred Shih (Gerrit)
Fred Shih added 2 comments![]( "Open in Gerrit")
Hello! Sorry for the delay, I missed this.
Mojo reviews should contain the implementation. I do understand that it'd be nicer to to stage changes in smaller CLs, but we're supposed to check the impl along the interface definition.
(I also don't have access to the bug).
string source;
string world_name;
bool include_command_line_api;some comments would be nice :)
Related details
- Andrey Kosyakov
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrey Kosyakov (Gerrit)
Andrey Kosyakov voted and added 2 comments![]( "Open in Gerrit")
Votes added by Andrey Kosyakov
| Commit-Queue | +0 |
Hello! Sorry for the delay, I missed this.
Mojo reviews should contain the implementation. I do understand that it'd be nicer to to stage changes in smaller CLs, but we're supposed to check the impl along the interface definition.
(I also don't have access to the bug).
I cc'ed you on the bug. Please note the actual implementation is on the stacked CL. There's also a "big picture" PoC CL if you prefer to see it all at once:
https://chromium-review.git.corp.google.com/c/chromium/src/+/7789702
Please also note these are browser-to-renderer only calls.
string source;
string world_name;
bool include_command_line_api;some comments would be nice :)
- Fred Shih
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fred Shih (Gerrit)
Fred Shih added 1 comment![]( "Open in Gerrit")
Andrey KosyakovHello! Sorry for the delay, I missed this.
Mojo reviews should contain the implementation. I do understand that it'd be nicer to to stage changes in smaller CLs, but we're supposed to check the impl along the interface definition.
(I also don't have access to the bug).
I cc'ed you on the bug. Please note the actual implementation is on the stacked CL. There's also a "big picture" PoC CL if you prefer to see it all at once:
https://chromium-review.git.corp.google.com/c/chromium/src/+/7789702
Please also note these are browser-to-renderer only calls.
thanks! I'm actively reading through it. I'm not very familiar with this part of the code, so please give me some time.
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |