[temporal] Mark all Temporal methods as having no side-effects [v8/v8 : main]
0 views
Skip to first unread message
Manish Goregaokar (Gerrit)
Nov 4, 2025, 11:40:41 AM (2 days ago) Nov 4
to Leszek Swirski, AyeAye, devtools-...@chromium.org
Attention needed from Leszek Swirski
Manish Goregaokar voted and added 1 comment![]( "Open in Gerrit")
Votes added by Manish Goregaokar
| Auto-Submit | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Manish Goregaokar . resolved
I wasn't sure if there was an easy way to write a "hit all methods" test given that Temporal has a much wider variety of APIs.
And I wasn't sure if it was needed. But I'm happy to add testing if someone tells me which form of test is desired.
Related details
Attention is currently required from:
- Leszek Swirski
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Leszek Swirski (Gerrit)
Nov 5, 2025, 5:15:44 AM (yesterday) Nov 5
to Manish Goregaokar, AyeAye, devtools-...@chromium.org
Attention needed from Manish Goregaokar
Leszek Swirski voted![]( "Open in Gerrit")
Attention is currently required from:
- Manish Goregaokar
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Nov 5, 2025, 5:55:16 AM (yesterday) Nov 5
to Manish Goregaokar, Leszek Swirski, AyeAye, devtools-...@chromium.org
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[temporal] Mark all Temporal methods as having no side-effects
Followup from https://chromium-review.googlesource.com/c/v8/v8/+/7111926/4
Note that Temporal.Now stuff reads from system time, so it will change
behavior, but it seems like `Date()` is marked as having no side effects
so this is as well.
Bug: 401065166
Change-Id: I8090d3da8cc95e26a8ae8d9e68e3f6526a6a6964
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7117353
Commit-Queue: Leszek Swirski <les...@chromium.org>
Auto-Submit: Manish Goregaokar <manis...@google.com>
Reviewed-by: Leszek Swirski <les...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#103525}
Files:
- M src/debug/debug-evaluate.cc
- M test/debugger/debug/side-effect/debug-evaluate-no-side-effect-builtins-2.js
Change size: M
Delta: 2 files changed, 238 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Leszek Swirski
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages