[SEH] Don't dialog after default search engine search. [chromium/src : main]

0 views
Skip to first unread message

Daniel Soromou (Gerrit)

unread,
Jan 29, 2026, 1:56:50 PM (12 days ago) Jan 29
to Justin Donnelly, Mirko Bonadei, Jerome Jiang, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chrome-intelligence-te...@google.com, penghuan...@chromium.org, fgal...@chromium.org, cblume...@chromium.org, feature-me...@chromium.org, jz...@chromium.org, chrome-intell...@chromium.org, mar...@chromium.org, mac-r...@chromium.org, devtools...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org
Attention needed from Justin Donnelly

Daniel Soromou voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Justin Donnelly
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id3c1e541aa8448b738fe94a1c00e2b4ad51c03d2
Gerrit-Change-Number: 7517486
Gerrit-PatchSet: 6
Gerrit-Owner: Daniel Soromou <koreta...@chromium.org>
Gerrit-Reviewer: Daniel Soromou <koreta...@chromium.org>
Gerrit-Reviewer: Justin Donnelly <jdon...@chromium.org>
Gerrit-CC: Jerome Jiang <ji...@chromium.org>
Gerrit-CC: Mirko Bonadei <mbon...@chromium.org>
Gerrit-Attention: Justin Donnelly <jdon...@chromium.org>
Gerrit-Comment-Date: Thu, 29 Jan 2026 18:56:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Justin Donnelly (Gerrit)

unread,
Jan 29, 2026, 4:26:31 PM (12 days ago) Jan 29
to Daniel Soromou, Justin Donnelly, Mirko Bonadei, Jerome Jiang, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chrome-intelligence-te...@google.com, penghuan...@chromium.org, fgal...@chromium.org, cblume...@chromium.org, feature-me...@chromium.org, jz...@chromium.org, chrome-intell...@chromium.org, mar...@chromium.org, mac-r...@chromium.org, devtools...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org
Attention needed from Daniel Soromou

Justin Donnelly added 1 comment

Patchset-level comments
File-level comment, Patchset 8 (Latest):
Justin Donnelly . resolved

Hi Daniel, this code looks fine, since kSearchEngineExplicitChoiceDialog is currently default false. But I don't understand how it relates to the CL description. The description sounds like it's *adding* a guard based on kSearchEngineExplicitChoiceDialog when in fact it's doing the opposite.

Can you update the CL description to describe the change more accurately? Or is there something I'm misunderstanding here?

Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Soromou
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id3c1e541aa8448b738fe94a1c00e2b4ad51c03d2
Gerrit-Change-Number: 7517486
Gerrit-PatchSet: 8
Gerrit-Owner: Daniel Soromou <koreta...@chromium.org>
Gerrit-Reviewer: Daniel Soromou <koreta...@chromium.org>
Gerrit-Reviewer: Justin Donnelly <jdon...@chromium.org>
Gerrit-CC: Jerome Jiang <ji...@chromium.org>
Gerrit-CC: Mirko Bonadei <mbon...@chromium.org>
Gerrit-Attention: Daniel Soromou <koreta...@chromium.org>
Gerrit-Comment-Date: Thu, 29 Jan 2026 21:26:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniel Soromou (Gerrit)

unread,
Feb 3, 2026, 11:12:24 AM (7 days ago) Feb 3
to Justin Donnelly, Mirko Bonadei, Jerome Jiang, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chrome-intelligence-te...@google.com, penghuan...@chromium.org, fgal...@chromium.org, cblume...@chromium.org, feature-me...@chromium.org, jz...@chromium.org, chrome-intell...@chromium.org, mar...@chromium.org, mac-r...@chromium.org, devtools...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org
Attention needed from Justin Donnelly

Daniel Soromou added 1 comment

Patchset-level comments
File-level comment, Patchset 8:
Justin Donnelly . unresolved

Hi Daniel, this code looks fine, since kSearchEngineExplicitChoiceDialog is currently default false. But I don't understand how it relates to the CL description. The description sounds like it's *adding* a guard based on kSearchEngineExplicitChoiceDialog when in fact it's doing the opposite.

Can you update the CL description to describe the change more accurately? Or is there something I'm misunderstanding here?

Daniel Soromou

Ok sure, I have updated the description.

Open in Gerrit

Related details

Attention is currently required from:
  • Justin Donnelly
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id3c1e541aa8448b738fe94a1c00e2b4ad51c03d2
    Gerrit-Change-Number: 7517486
    Gerrit-PatchSet: 11
    Gerrit-Owner: Daniel Soromou <koreta...@chromium.org>
    Gerrit-Reviewer: Daniel Soromou <koreta...@chromium.org>
    Gerrit-Reviewer: Justin Donnelly <jdon...@chromium.org>
    Gerrit-CC: Jerome Jiang <ji...@chromium.org>
    Gerrit-CC: Mirko Bonadei <mbon...@chromium.org>
    Gerrit-Attention: Justin Donnelly <jdon...@chromium.org>
    Gerrit-Comment-Date: Tue, 03 Feb 2026 16:12:17 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Justin Donnelly <jdon...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Justin Donnelly (Gerrit)

    unread,
    Feb 4, 2026, 12:00:17 PM (6 days ago) Feb 4
    to Daniel Soromou, Justin Donnelly, Mirko Bonadei, Jerome Jiang, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chrome-intelligence-te...@google.com, penghuan...@chromium.org, fgal...@chromium.org, cblume...@chromium.org, feature-me...@chromium.org, jz...@chromium.org, chrome-intell...@chromium.org, mar...@chromium.org, mac-r...@chromium.org, devtools...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org
    Attention needed from Daniel Soromou

    Justin Donnelly voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Daniel Soromou
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id3c1e541aa8448b738fe94a1c00e2b4ad51c03d2
    Gerrit-Change-Number: 7517486
    Gerrit-PatchSet: 11
    Gerrit-Owner: Daniel Soromou <koreta...@chromium.org>
    Gerrit-Reviewer: Daniel Soromou <koreta...@chromium.org>
    Gerrit-Reviewer: Justin Donnelly <jdon...@chromium.org>
    Gerrit-CC: Jerome Jiang <ji...@chromium.org>
    Gerrit-CC: Mirko Bonadei <mbon...@chromium.org>
    Gerrit-Attention: Daniel Soromou <koreta...@chromium.org>
    Gerrit-Comment-Date: Wed, 04 Feb 2026 17:00:07 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Daniel Soromou (Gerrit)

    unread,
    Feb 4, 2026, 12:04:25 PM (6 days ago) Feb 4
    to Justin Donnelly, Mirko Bonadei, Jerome Jiang, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chrome-intelligence-te...@google.com, penghuan...@chromium.org, fgal...@chromium.org, cblume...@chromium.org, feature-me...@chromium.org, jz...@chromium.org, chrome-intell...@chromium.org, mar...@chromium.org, mac-r...@chromium.org, devtools...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org

    Daniel Soromou added 1 comment

    Patchset-level comments
    File-level comment, Patchset 8:
    Justin Donnelly . resolved

    Hi Daniel, this code looks fine, since kSearchEngineExplicitChoiceDialog is currently default false. But I don't understand how it relates to the CL description. The description sounds like it's *adding* a guard based on kSearchEngineExplicitChoiceDialog when in fact it's doing the opposite.

    Can you update the CL description to describe the change more accurately? Or is there something I'm misunderstanding here?

    Daniel Soromou

    Ok sure, I have updated the description.

    Daniel Soromou

    Done

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Id3c1e541aa8448b738fe94a1c00e2b4ad51c03d2
      Gerrit-Change-Number: 7517486
      Gerrit-PatchSet: 11
      Gerrit-Owner: Daniel Soromou <koreta...@chromium.org>
      Gerrit-Reviewer: Daniel Soromou <koreta...@chromium.org>
      Gerrit-Reviewer: Justin Donnelly <jdon...@chromium.org>
      Gerrit-CC: Jerome Jiang <ji...@chromium.org>
      Gerrit-CC: Mirko Bonadei <mbon...@chromium.org>
      Gerrit-Comment-Date: Wed, 04 Feb 2026 17:04:18 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Justin Donnelly <jdon...@chromium.org>
      Comment-In-Reply-To: Daniel Soromou <koreta...@chromium.org>
      satisfied_requirement
      open
      diffy

      Daniel Soromou (Gerrit)

      unread,
      Feb 4, 2026, 12:04:35 PM (6 days ago) Feb 4
      to Justin Donnelly, Mirko Bonadei, Jerome Jiang, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chrome-intelligence-te...@google.com, penghuan...@chromium.org, fgal...@chromium.org, cblume...@chromium.org, feature-me...@chromium.org, jz...@chromium.org, chrome-intell...@chromium.org, mar...@chromium.org, mac-r...@chromium.org, devtools...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org

      Daniel Soromou voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Id3c1e541aa8448b738fe94a1c00e2b4ad51c03d2
      Gerrit-Change-Number: 7517486
      Gerrit-PatchSet: 11
      Gerrit-Owner: Daniel Soromou <koreta...@chromium.org>
      Gerrit-Reviewer: Daniel Soromou <koreta...@chromium.org>
      Gerrit-Reviewer: Justin Donnelly <jdon...@chromium.org>
      Gerrit-CC: Jerome Jiang <ji...@chromium.org>
      Gerrit-CC: Mirko Bonadei <mbon...@chromium.org>
      Gerrit-Comment-Date: Wed, 04 Feb 2026 17:04:28 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Daniel Soromou (Gerrit)

      unread,
      10:13 AM (2 hours ago) 10:13 AM
      to Justin Donnelly, Mirko Bonadei, Jerome Jiang, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chrome-intelligence-te...@google.com, penghuan...@chromium.org, fgal...@chromium.org, cblume...@chromium.org, feature-me...@chromium.org, jz...@chromium.org, chrome-intell...@chromium.org, mar...@chromium.org, mac-r...@chromium.org, devtools...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org

      Daniel Soromou abandoned this change.

      View Change

      Abandoned Moved it in the next CL.

      Daniel Soromou abandoned this change

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: abandon
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Id3c1e541aa8448b738fe94a1c00e2b4ad51c03d2
      Gerrit-Change-Number: 7517486
      Gerrit-PatchSet: 12
      satisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages