Remove various speculation rules feature flags. [chromium/src : main]
0 views
Skip to first unread message
Jeremy Roman (Gerrit)
Jun 26, 2024, 8:20:22 PM (3 days ago) Jun 26
to Jeremy Roman, Adithya Srinivasan, Vladimir Levin, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, prerendering-reviews, Yoav Weiss (@Shopify), blink-...@chromium.org, chasej...@chromium.org, devtools-re...@chromium.org, gavin...@chromium.org, gavinp+p...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, tburkar...@chromium.org
Attention needed from Adithya Srinivasan and Vladimir Levin
Jeremy Roman voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jeremy Roman
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Jeremy Roman . resolved
adithyas for primary review
vmpstr for VirtualTestSuites
Related details
Attention is currently required from:
- Adithya Srinivasan
- Vladimir Levin
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vladimir Levin (Gerrit)
Jun 26, 2024, 8:49:33 PM (3 days ago) Jun 26
to Jeremy Roman, Adithya Srinivasan, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, prerendering-reviews, Yoav Weiss (@Shopify), blink-...@chromium.org, chasej...@chromium.org, devtools-re...@chromium.org, gavin...@chromium.org, gavinp+p...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, tburkar...@chromium.org
Attention needed from Adithya Srinivasan and Jeremy Roman
Vladimir Levin voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Adithya Srinivasan
- Jeremy Roman
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jeremy Roman (Gerrit)
Jun 27, 2024, 10:36:46 AM (3 days ago) Jun 27
to Jeremy Roman, Vladimir Levin, Adithya Srinivasan, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, prerendering-reviews, Yoav Weiss (@Shopify), blink-...@chromium.org, chasej...@chromium.org, devtools-re...@chromium.org, gavin...@chromium.org, gavinp+p...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, tburkar...@chromium.org
Attention needed from Adithya Srinivasan
Jeremy Roman added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Jeremy Roman . resolved
will address test failures, please hold 😊
Related details
Attention is currently required from:
- Adithya Srinivasan
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Adithya Srinivasan (Gerrit)
Jun 27, 2024, 10:42:37 AM (3 days ago) Jun 27
to Jeremy Roman, Vladimir Levin, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, prerendering-reviews, Yoav Weiss (@Shopify), blink-...@chromium.org, chasej...@chromium.org, devtools-re...@chromium.org, gavin...@chromium.org, gavinp+p...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, tburkar...@chromium.org
Adithya Srinivasan added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Adithya Srinivasan . resolved
test failures look real so I'll wait for them to be fixed
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Adithya Srinivasan (Gerrit)
Jun 27, 2024, 10:43:07 AM (3 days ago) Jun 27
to Jeremy Roman, Vladimir Levin, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, prerendering-reviews, Yoav Weiss (@Shopify), blink-...@chromium.org, chasej...@chromium.org, devtools-re...@chromium.org, gavin...@chromium.org, gavinp+p...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, tburkar...@chromium.org
Attention needed from Jeremy Roman
Adithya Srinivasan added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Jeremy Roman . resolved
will address test failures, please hold 😊
Adithya Srinivasan
oh just saw this oops 😊
Related details
Attention is currently required from:
- Jeremy Roman
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jeremy Roman (Gerrit)
Jun 27, 2024, 1:59:13 PM (3 days ago) Jun 27
to Jeremy Roman, Vladimir Levin, Adithya Srinivasan, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, prerendering-reviews, Yoav Weiss (@Shopify), blink-...@chromium.org, chasej...@chromium.org, devtools-re...@chromium.org, gavin...@chromium.org, gavinp+p...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, tburkar...@chromium.org
Attention needed from Adithya Srinivasan
Jeremy Roman added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Adithya Srinivasan
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Adithya Srinivasan (Gerrit)
Jun 27, 2024, 4:39:12 PM (3 days ago) Jun 27
to Jeremy Roman, Vladimir Levin, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, prerendering-reviews, Yoav Weiss (@Shopify), blink-...@chromium.org, chasej...@chromium.org, devtools-re...@chromium.org, gavin...@chromium.org, gavinp+p...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, tburkar...@chromium.org
Attention needed from Jeremy Roman
Adithya Srinivasan voted and added 1 comment![]( "Open in Gerrit")
Votes added by Adithya Srinivasan
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Jeremy Roman
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jeremy Roman (Gerrit)
Jun 27, 2024, 5:29:05 PM (3 days ago) Jun 27
to Jeremy Roman, Adithya Srinivasan, Vladimir Levin, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, prerendering-reviews, Yoav Weiss (@Shopify), blink-...@chromium.org, chasej...@chromium.org, devtools-re...@chromium.org, gavin...@chromium.org, gavinp+p...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, tburkar...@chromium.org
Jeremy Roman voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 27, 2024, 5:33:42 PM (3 days ago) Jun 27
to Jeremy Roman, Adithya Srinivasan, Vladimir Levin, chromium...@chromium.org, devtools...@chromium.org, prerendering-reviews, Yoav Weiss (@Shopify), blink-...@chromium.org, chasej...@chromium.org, devtools-re...@chromium.org, gavin...@chromium.org, gavinp+p...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, tburkar...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Remove various speculation rules feature flags.
These have been shipped for a few months:
* SpeculationRulesDocumentRules
* SpeculationRulesDocumentRulesSelectorMatches
* SpeculationRulesEagerness
* SpeculationRulesFetchFromHeader
* SpeculationRulesImplicitSource
The new flaky test check is skipped because this test is not new
(it just no longer needs to be covered by a virtual test suite).
Bug: 1371522,1406595,1366940,1517696
Validate-Test-Flakiness: skip
Change-Id: I9d46c09ab5a3bf633395d70b1511f27faaf4bd73
Reviewed-by: Adithya Srinivasan <adit...@chromium.org>
Commit-Queue: Jeremy Roman <jbr...@chromium.org>
Reviewed-by: Vladimir Levin <vmp...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1320649}
Files:
- M content/browser/preloading/prerender/prerender_browsertest.cc
- M third_party/blink/renderer/core/speculation_rules/build.gni
- M third_party/blink/renderer/core/speculation_rules/document_rule_predicate.cc
- M third_party/blink/renderer/core/speculation_rules/document_speculation_rules.cc
- M third_party/blink/renderer/core/speculation_rules/document_speculation_rules.h
- M third_party/blink/renderer/core/speculation_rules/speculation_rule_set.cc
- M third_party/blink/renderer/core/speculation_rules/speculation_rule_set_test.cc
- D third_party/blink/renderer/core/speculation_rules/speculation_rules_features.cc
- D third_party/blink/renderer/core/speculation_rules/speculation_rules_features.h
- M third_party/blink/renderer/core/speculation_rules/speculation_rules_header.cc
- M third_party/blink/renderer/core/speculation_rules/speculation_rules_header_test.cc
- M third_party/blink/renderer/core/speculation_rules/speculation_rules_origin_trial_test.cc
- M third_party/blink/renderer/core/url_pattern/url_pattern_histogram_test.cc
- M third_party/blink/renderer/platform/runtime_enabled_features.json5
- M third_party/blink/web_tests/VirtualTestSuites
- R third_party/blink/web_tests/http/tests/inspector-protocol/preload/preloading-attempt-sources-updated-expected.txt
- D third_party/blink/web_tests/virtual/preload-devtools/README.md
Change size: L
Delta: 17 files changed, 30 insertions(+), 454 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Adithya Srinivasan, +1 by Vladimir Levin
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages