Michael Wilson (Gerrit)

unread,

Jul 2, 2024, 12:23:18 PMJul 2

to Changhao Han, Rune Lillesveen, Alex Rudenko, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, devtools...@chromium.org

Attention needed from Alex Rudenko, Changhao Han and Rune Lillesveen

Michael Wilson has uploaded the change for review

Michael Wilson would like Changhao Han, Rune Lillesveen, Alex Rudenko and Chromium LUCI CQ to review this change.

Commit message

Revert "[inspector] Add active position try rule index and pass it to inspector"

This reverts commit 5e84130e78ca65c940ad57d2fbc3a02dfd06f701.

Reason for revert: This appears to be be the cause of consistent
build failures on mac-arm64 for test
inspector-protocol/css/css-get-position-try.js

See crbug.com/350730710

Original change's description:
> [inspector] Add active position try rule index and pass it to inspector
>
> This CL adds the following things:
> - the successful (active) position try rule index to
>   SuccessfulPositionOption;
> - an API in OutOfFlowData to return the active position try rule index
>   added above;
> - necessary bits in the inspector to mark which position try rule is
>   active.
>
> Bug: 40246493
> Change-Id: Ib8857d83ef573dd64b8da71bb0363fd0429080bc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5643490
> Reviewed-by: Alex Rudenko <alexr...@chromium.org>
> Commit-Queue: Changhao Han <chang...@chromium.org>
> Reviewed-by: Rune Lillesveen <fut...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1322147}

Bug: 40246493

Change-Id: I4e1ab6e64c4cc788c6d0202ecc0cac9507016ee1

Change diff

Change information

Files:

M third_party/blink/public/devtools_protocol/browser_protocol.pdl
M third_party/blink/renderer/core/css/out_of_flow_data.cc
M third_party/blink/renderer/core/css/out_of_flow_data.h
M third_party/blink/renderer/core/css/successful_position_option.cc
M third_party/blink/renderer/core/css/successful_position_option.h
M third_party/blink/renderer/core/inspector/inspector_css_agent.cc
M third_party/blink/renderer/core/inspector/inspector_style_sheet.cc
M third_party/blink/renderer/core/inspector/inspector_style_sheet.h
M third_party/blink/renderer/core/layout/out_of_flow_layout_part.cc
M third_party/blink/web_tests/inspector-protocol/css/css-get-position-try-expected.txt
M third_party/blink/web_tests/inspector-protocol/css/css-get-position-try.js
M third_party/blink/web_tests/inspector-protocol/resources/css-helper.js

Change size: M

Delta: 12 files changed, 22 insertions(+), 134 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

Alex Rudenko
Changhao Han
Rune Lillesveen

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Rubber Stamper (Gerrit)

unread,

Jul 2, 2024, 12:24:16 PMJul 2

to AyeAye, Changhao Han, Rune Lillesveen, Alex Rudenko, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, devtools...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, devtools-re...@chromium.org, zol...@webkit.org, blink-re...@chromium.org, blink-...@chromium.org, apavlo...@chromium.org

Attention needed from Alex Rudenko, Changhao Han and Rune Lillesveen

Rubber Stamper voted Bot-Commit+1

Bot-Commit

+1

Open in Gerrit

Related details

Attention is currently required from:

Alex Rudenko
Changhao Han
Rune Lillesveen

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Michael Wilson (Gerrit)

unread,

Jul 2, 2024, 12:26:23 PMJul 2

to Rubber Stamper, AyeAye, Changhao Han, Rune Lillesveen, Alex Rudenko, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, devtools...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, devtools-re...@chromium.org, zol...@webkit.org, blink-re...@chromium.org, blink-...@chromium.org, apavlo...@chromium.org

Attention needed from Alex Rudenko, Changhao Han and Rune Lillesveen

Michael Wilson voted

Commit-Queue	+2
Owners-Override	+1

Open in Gerrit

Related details

Attention is currently required from:

Alex Rudenko
Changhao Han
Rune Lillesveen

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jul 2, 2024, 1:17:31 PMJul 2

to Rubber Stamper, AyeAye, Changhao Han, Rune Lillesveen, Alex Rudenko, Alexis Menard, chromium...@chromium.org, devtools...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, devtools-re...@chromium.org, zol...@webkit.org, blink-re...@chromium.org, blink-...@chromium.org, apavlo...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Revert "[inspector] Add active position try rule index and pass it to inspector"

This reverts commit 5e84130e78ca65c940ad57d2fbc3a02dfd06f701.

Reason for revert: This appears to be be the cause of consistent
build failures on mac-arm64 for test
inspector-protocol/css/css-get-position-try.js

See crbug.com/350730710

Original change's description:
> [inspector] Add active position try rule index and pass it to inspector
>
> This CL adds the following things:
> - the successful (active) position try rule index to
>   SuccessfulPositionOption;
> - an API in OutOfFlowData to return the active position try rule index
>   added above;
> - necessary bits in the inspector to mark which position try rule is
>   active.
>
> Bug: 40246493
> Change-Id: Ib8857d83ef573dd64b8da71bb0363fd0429080bc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5643490
> Reviewed-by: Alex Rudenko <alexr...@chromium.org>
> Commit-Queue: Changhao Han <chang...@chromium.org>
> Reviewed-by: Rune Lillesveen <fut...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1322147}

Bug: 40246493

Bug: 350730710

Change-Id: I4e1ab6e64c4cc788c6d0202ecc0cac9507016ee1

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5672812

Owners-Override: Michael Wilson <mjwi...@chromium.org>

Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>

Commit-Queue: Michael Wilson <mjwi...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1322268}

Files:

M third_party/blink/public/devtools_protocol/browser_protocol.pdl
M third_party/blink/renderer/core/css/out_of_flow_data.cc
M third_party/blink/renderer/core/css/out_of_flow_data.h
M third_party/blink/renderer/core/css/successful_position_option.cc
M third_party/blink/renderer/core/css/successful_position_option.h
M third_party/blink/renderer/core/inspector/inspector_css_agent.cc
M third_party/blink/renderer/core/inspector/inspector_style_sheet.cc
M third_party/blink/renderer/core/inspector/inspector_style_sheet.h
M third_party/blink/renderer/core/layout/out_of_flow_layout_part.cc
M third_party/blink/web_tests/inspector-protocol/css/css-get-position-try-expected.txt
M third_party/blink/web_tests/inspector-protocol/css/css-get-position-try.js
M third_party/blink/web_tests/inspector-protocol/resources/css-helper.js

Change size: M

Delta: 12 files changed, 22 insertions(+), 134 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: Bot-Commit+1 by Rubber Stamper

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

สมศักดิ์ มีแสงเพ็ชร (Gerrit)

unread,

Jul 5, 2024, 8:15:54 PMJul 5

to Chromium LUCI CQ, Rubber Stamper, AyeAye, Changhao Han, Rune Lillesveen, Alex Rudenko, Alexis Menard, chromium...@chromium.org, devtools...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, devtools-re...@chromium.org, zol...@webkit.org, blink-re...@chromium.org, blink-...@chromium.org, apavlo...@chromium.org

สมศักดิ์ มีแสงเพ็ชร added 1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

สมศักดิ์ มีแสงเพ็ชร . resolved

Revert "[inspector] Add active position

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

Revert "[inspector] Add active position try rule index and pass it to inspector" [chromium/src : main]

Michael Wilson (Gerrit)

Michael Wilson has uploaded the change for review

Commit message

Change diff

Change information

Related details

Rubber Stamper (Gerrit)

Rubber Stamper voted Bot-Commit+1

Related details

Michael Wilson (Gerrit)

Michael Wilson voted

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information

สมศักดิ์ มีแสงเพ็ชร (Gerrit)

สมศักดิ์ มีแสงเพ็ชร added 1 comment

Related details