[FedCM] Remove obsolete FederatedAuthRequestResults [chromium/src : main]
0 views
Skip to first unread message
Nicolás Peña (Gerrit)
Feb 9, 2026, 5:14:00 PMFeb 9
to Christian Biesinger, Chromium Metrics Reviews, AyeAye, asvitkine...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org, yigu+...@chromium.org, npm+...@chromium.org, devtools...@chromium.org
New activity on the change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicolás Peña (Gerrit)
Feb 9, 2026, 5:14:08 PMFeb 9
to Christian Biesinger, Chromium Metrics Reviews, AyeAye, asvitkine...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org, yigu+...@chromium.org, npm+...@chromium.org, devtools...@chromium.org
Attention needed from Christian Biesinger
Nicolás Peña voted Commit-Queue+1![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Christian Biesinger (Gerrit)
Feb 9, 2026, 5:41:15 PMFeb 9
to Nicolás Peña, Christian Biesinger, Chromium LUCI CQ, Chromium Metrics Reviews, AyeAye, asvitkine...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org, yigu+...@chromium.org, npm+...@chromium.org, devtools...@chromium.org
Attention needed from Nicolás Peña
Christian Biesinger voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Nicolás Peña
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicolás Peña (Gerrit)
Feb 9, 2026, 5:52:20 PMFeb 9
to Andrey Kosyakov, Chromium IPC Reviews, Christian Biesinger, Chromium LUCI CQ, Chromium Metrics Reviews, AyeAye, asvitkine...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org, yigu+...@chromium.org, npm+...@chromium.org, devtools...@chromium.org
Attention needed from Andrey Kosyakov and Chromium IPC Reviews
Nicolás Peña added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Nicolás Peña . resolved
+caseq for devtools and devtools_protocol.
+ipc_reviewer for inspector_issue.mojom
Related details
Attention is currently required from:
- Andrey Kosyakov
- Chromium IPC Reviews
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
gwsq (Gerrit)
Feb 9, 2026, 5:56:54 PMFeb 9
to Nicolás Peña, Chromium IPC Reviews, Giovanni Ortuno Urquidi, Andrey Kosyakov, Christian Biesinger, Chromium LUCI CQ, Chromium Metrics Reviews, AyeAye, asvitkine...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org, yigu+...@chromium.org, npm+...@chromium.org, devtools...@chromium.org
Attention needed from Andrey Kosyakov and Giovanni Ortuno Urquidi
Message from gwsq![]( "Open in Gerrit")
From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: ort...@chromium.org
📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).
IPC reviewer(s): ort...@chromium.org
Reviewer source(s):
ort...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)
Related details
Attention is currently required from:
- Andrey Kosyakov
- Giovanni Ortuno Urquidi
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrey Kosyakov (Gerrit)
Feb 9, 2026, 6:20:22 PMFeb 9
to Nicolás Peña, Chromium IPC Reviews, Giovanni Ortuno Urquidi, Christian Biesinger, Chromium LUCI CQ, Chromium Metrics Reviews, AyeAye, asvitkine...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org, yigu+...@chromium.org, npm+...@chromium.org, devtools...@chromium.org
Attention needed from Giovanni Ortuno Urquidi and Nicolás Peña
Andrey Kosyakov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Andrey Kosyakov
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Giovanni Ortuno Urquidi
- Nicolás Peña
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Giovanni Ortuno Urquidi (Gerrit)
Feb 10, 2026, 11:03:41 AMFeb 10
to Nicolás Peña, Giovanni Ortuno Urquidi, Andrey Kosyakov, Chromium IPC Reviews, Christian Biesinger, Chromium LUCI CQ, Chromium Metrics Reviews, AyeAye, asvitkine...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org, yigu+...@chromium.org, npm+...@chromium.org, devtools...@chromium.org
Attention needed from Nicolás Peña
Giovanni Ortuno Urquidi voted and added 1 comment![]( "Open in Gerrit")
Votes added by Giovanni Ortuno Urquidi
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Nicolás Peña
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicolás Peña (Gerrit)
Feb 10, 2026, 11:56:54 AMFeb 10
to Giovanni Ortuno Urquidi, Andrey Kosyakov, Chromium IPC Reviews, Christian Biesinger, Chromium LUCI CQ, Chromium Metrics Reviews, AyeAye, asvitkine...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org, yigu+...@chromium.org, npm+...@chromium.org, devtools...@chromium.org
Nicolás Peña voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Feb 10, 2026, 12:00:32 PMFeb 10
to Nicolás Peña, Giovanni Ortuno Urquidi, Andrey Kosyakov, Chromium IPC Reviews, Christian Biesinger, Chromium Metrics Reviews, AyeAye, asvitkine...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org, yigu+...@chromium.org, npm+...@chromium.org, devtools...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[FedCM] Remove obsolete FederatedAuthRequestResults
This change removes several FederatedAuthRequestResult enum values that
are no longer used: kClientMetadata*, kThirdPartyCookiesBlocked, and
kInvalidFieldsSpecified. The corresponding mappings in DevTools
instrumentation, metrics, and user-facing messages are also updated.
NO_IFTTT=spacing changes
Change-Id: Ife3314a12f29d05f03d6d6b432f7559109b5ea43
Reviewed-by: Christian Biesinger <cbies...@chromium.org>
Reviewed-by: Andrey Kosyakov <ca...@chromium.org>
Reviewed-by: Giovanni Ortuno Urquidi <ort...@chromium.org>
Commit-Queue: Nicolás Peña <n...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1582564}
Files:
- M content/browser/devtools/devtools_instrumentation.cc
- M content/browser/webid/mappers.cc
- M content/browser/webid/metrics.h
- M content/browser/webid/webid_utils.cc
- M third_party/blink/public/devtools_protocol/domains/Audits.pdl
- M third_party/blink/public/mojom/devtools/inspector_issue.mojom
- M tools/metrics/histograms/metadata/blink/enums.xml
Change size: M
Delta: 7 files changed, 12 insertions(+), 89 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Giovanni Ortuno Urquidi, +1 by Andrey Kosyakov, +1 by Christian Biesinger
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages