Prompts: Eng Vision gotchas and DevTools module merging guide [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Paul Irish (Gerrit)
10:28 AM (2 hours ago) 10:28 AM
to Jack Franklin, devtools-rev...@chromium.org
Attention needed from Jack Franklin
Paul Irish voted and added 1 comment![]( "Open in Gerrit")
Votes added by Paul Irish
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
File agents/prompts/ui-widgets.md
Line 60, Patchset 1:
## Refactoring Legacy ComponentsPaul Irish . unresolved
Rude of me to do this but.. I have limited exp with this stuff.
This guidance is sourced from looking at most of the UI eng vision commits. And I asked my agent to doublecheck and verify that it jives with the landed CLs.
So jack, either you can review my slop or.. I'll just remove these additions. :)
Related details
Attention is currently required from:
- Jack Franklin
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jack Franklin (Gerrit)
10:33 AM (2 hours ago) 10:33 AM
to Paul Irish, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Paul Irish
Jack Franklin voted and added 2 comments![]( "Open in Gerrit")
Votes added by Jack Franklin
| Code-Review | +1 |
2 comments
Patchset-level comments
File agents/prompts/ui-widgets.md
Line 60, Patchset 1:
## Refactoring Legacy ComponentsPaul Irish . resolved
Rude of me to do this but.. I have limited exp with this stuff.
This guidance is sourced from looking at most of the UI eng vision commits. And I asked my agent to doublecheck and verify that it jives with the landed CLs.
So jack, either you can review my slop or.. I'll just remove these additions. :)
Attention is currently required from:
- Paul Irish
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paul Irish (Gerrit)
10:35 AM (2 hours ago) 10:35 AM
to Jack Franklin, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Paul Irish voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devtools-frontend LUCI CQ (Gerrit)
10:53 AM (2 hours ago) 10:53 AM
to Paul Irish, Jack Franklin, devtools-rev...@chromium.org
Devtools-frontend LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Prompts: Eng Vision gotchas and DevTools module merging guide
Bug: none
Change-Id: I1d611cd0b0c43d8e3a9a164a2ecb082e2131797b
Reviewed-by: Jack Franklin <jacktf...@chromium.org>
Auto-Submit: Paul Irish <paul...@chromium.org>
Commit-Queue: Paul Irish <paul...@chromium.org>
Files:
- A agents/prompts/merging-devtools-module.md
- M agents/prompts/ui-widgets.md
Change size: M
Delta: 2 files changed, 193 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Jack Franklin
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages