Avoid JS reentry in value-mirror [v8/v8 : main]

1 view
Skip to first unread message

Yang Guo (Gerrit)

unread,
Mar 2, 2026, 6:42:46 AMMar 2
to Simon Zünd, V8 LUCI CQ, AyeAye, devtools-...@chromium.org, v8-re...@googlegroups.com
Attention needed from Simon Zünd

Yang Guo voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Simon Zünd
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I913983cfe4cf03a0216ad576e329bd9d2c4e7cdb
Gerrit-Change-Number: 7623393
Gerrit-PatchSet: 1
Gerrit-Owner: Yang Guo <yan...@chromium.org>
Gerrit-Reviewer: Simon Zünd <szu...@chromium.org>
Gerrit-Reviewer: Yang Guo <yan...@chromium.org>
Gerrit-Attention: Simon Zünd <szu...@chromium.org>
Gerrit-Comment-Date: Mon, 02 Mar 2026 11:42:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Simon Zünd (Gerrit)

unread,
Mar 2, 2026, 7:40:04 AMMar 2
to Yang Guo, V8 LUCI CQ, AyeAye, devtools-...@chromium.org, v8-re...@googlegroups.com
Attention needed from Yang Guo

Simon Zünd voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Yang Guo
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I913983cfe4cf03a0216ad576e329bd9d2c4e7cdb
Gerrit-Change-Number: 7623393
Gerrit-PatchSet: 1
Gerrit-Owner: Yang Guo <yan...@chromium.org>
Gerrit-Reviewer: Simon Zünd <szu...@chromium.org>
Gerrit-Reviewer: Yang Guo <yan...@chromium.org>
Gerrit-Attention: Yang Guo <yan...@chromium.org>
Gerrit-Comment-Date: Mon, 02 Mar 2026 12:39:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
Mar 2, 2026, 7:41:39 AMMar 2
to Yang Guo, Simon Zünd, AyeAye, devtools-...@chromium.org, v8-re...@googlegroups.com

V8 LUCI CQ submitted the change

Change information

Commit message:
Avoid JS reentry in value-mirror
Fixed: 48890217
Change-Id: I913983cfe4cf03a0216ad576e329bd9d2c4e7cdb
Commit-Queue: Simon Zünd <szu...@chromium.org>
Auto-Submit: Yang Guo <yan...@chromium.org>
Reviewed-by: Simon Zünd <szu...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#105519}
Files:
  • M src/inspector/value-mirror.cc
  • A test/inspector/runtime/regress-488790217-expected.txt
  • A test/inspector/runtime/regress-488790217.js
Change size: L
Delta: 3 files changed, 456 insertions(+), 32 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Simon Zünd
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I913983cfe4cf03a0216ad576e329bd9d2c4e7cdb
Gerrit-Change-Number: 7623393
Gerrit-PatchSet: 2
Gerrit-Owner: Yang Guo <yan...@chromium.org>
Gerrit-Reviewer: Simon Zünd <szu...@chromium.org>
open
diffy
satisfied_requirement

Eric Leese (Gerrit)

unread,
May 22, 2026, 11:20:48 AM (2 days ago) May 22
to Yang Guo, v8-s...@luci-project-accounts.iam.gserviceaccount.com, Simon Zünd, android-bu...@system.gserviceaccount.com, devtools-...@chromium.org, v8-re...@googlegroups.com

Eric Leese has created a revert of this change

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: revert
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I913983cfe4cf03a0216ad576e329bd9d2c4e7cdb
Gerrit-Change-Number: 7623393
Gerrit-PatchSet: 2
Gerrit-Owner: Yang Guo <yan...@chromium.org>
Gerrit-Reviewer: Simon Zünd <szu...@chromium.org>
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages