Add visual logging contexts to Issues panel for comment anchoring [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Alex Rudenko (Gerrit)
Aug 18, 2026, 3:43:30 AM (yesterday) Aug 18
to devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, devtools-rev...@chromium.org
Alex Rudenko voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
Aug 18, 2026, 3:57:05 AM (yesterday) Aug 18
to devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, devtools-rev...@chromium.org
Alex Rudenko added 1 comment![]( "Open in Gerrit")
File front_end/panels/issues/AffectedCookiesView.ts
Line 125, Patchset 2 (Latest):
row.setAttribute('jslog', `${VisualLogging.tableRow('affected-cookie')}`);Alex Rudenko . unresolved
Since this is inside `AffectedRawCookieLinesView`, consider using `'affected-raw-cookie'` here to distinguish it from regular cookies (assuming `CommentAnchorResolver` needs them to be distinct). If you do make this change, don't forget to also add `'affected-raw-cookie'` to `KnownContextValues.ts`.
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
Aug 18, 2026, 5:16:17 AM (yesterday) Aug 18
to devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, devtools-rev...@chromium.org
Alex Rudenko added 1 comment![]( "Open in Gerrit")
File front_end/panels/issues/AffectedCookiesView.ts
Line 125, Patchset 2:
row.setAttribute('jslog', `${VisualLogging.tableRow('affected-cookie')}`);Alex Rudenko . resolved
Since this is inside `AffectedRawCookieLinesView`, consider using `'affected-raw-cookie'` here to distinguish it from regular cookies (assuming `CommentAnchorResolver` needs them to be distinct). If you do make this change, don't forget to also add `'affected-raw-cookie'` to `KnownContextValues.ts`.
Alex Rudenko
Done
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
Aug 18, 2026, 11:11:02 AM (23 hours ago) Aug 18
to Yulun Zeng, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, devtools-rev...@chromium.org
Attention needed from Yulun Zeng
Alex Rudenko voted Commit-Queue+1![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
Aug 18, 2026, 12:11:29 PM (22 hours ago) Aug 18
to Yulun Zeng, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, devtools-rev...@chromium.org
Attention needed from Yulun Zeng
Alex Rudenko voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Yulun Zeng
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yulun Zeng (Gerrit)
3:45 AM (6 hours ago) 3:45 AM
to Alex Rudenko, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, devtools-rev...@chromium.org
Attention needed from Alex Rudenko
Yulun Zeng voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Alex Rudenko
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
5:41 AM (4 hours ago) 5:41 AM
to Yulun Zeng, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, devtools-rev...@chromium.org
Alex Rudenko voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
5:55 AM (4 hours ago) 5:55 AM
to Alex Rudenko, Yulun Zeng, android-bu...@system.gserviceaccount.com, devtools-rev...@chromium.org
devtools-fro...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Add visual logging contexts to Issues panel for comment anchoring
Add jslog contexts to IssueView ('issue-description',
'affected-resources', 'affected-request' with data-network-request-id),
AffectedElementsView ('affected-element' with data-backend-node-id),
and AffectedCookiesView ('affected-cookie') to support
CommentAnchorResolver.
Bug: 542928776
Change-Id: I2583d62b88dc0b4b00eec2b6ffa5d1c092256c09
TAG=agy
CONV=fdf66637-1abc-41a3-afd9-c4f8272a49c8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/8257557
Reviewed-by: Yulun Zeng <yul...@chromium.org>
Commit-Queue: Alex Rudenko <alexr...@chromium.org>
Files:
- M front_end/panels/issues/AffectedCookiesView.ts
- M front_end/panels/issues/AffectedElementsView.ts
- M front_end/panels/issues/IssueView.ts
- M front_end/ui/visual_logging/KnownContextValues.ts
Change size: S
Delta: 4 files changed, 20 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Yulun Zeng
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages