[Fonts] Fix PUA test codepoints: use valid PUA instead of noncharacters [chromium/src : main]
0 views
Skip to first unread message
Sejal Anand (Gerrit)
May 5, 2026, 4:50:13 AMMay 5
to Gaurav Kumar, Dileep Maurya, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, mac-r...@chromium.org
Attention needed from Dileep Maurya and Gaurav Kumar
Sejal Anand added 1 comment![]( "Open in Gerrit")
Commit Message
Line 15, Patchset 2 (Latest):
Refer : https://learn.microsoft.com/en-us/globalization/encoding/puaSejal Anand . resolved
LGTM! The "Refer" link in the commit message could also cite the Unicode Standard itself (§23.7 defines noncharacters) alongside the Microsoft link, but this is not blocking.
Related details
Attention is currently required from:
- Dileep Maurya
- Gaurav Kumar
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sejal Anand (Gerrit)
May 5, 2026, 4:50:41 AMMay 5
to Gaurav Kumar, Dileep Maurya, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, mac-r...@chromium.org
Attention needed from Dileep Maurya and Gaurav Kumar
Sejal Anand voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Dileep Maurya
- Gaurav Kumar
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gaurav Kumar (Gerrit)
May 14, 2026, 2:15:46 PMMay 14
to Sejal Anand, Dileep Maurya, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, mac-r...@chromium.org
Attention needed from Dileep Maurya
Gaurav Kumar voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Dileep Maurya
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
May 14, 2026, 3:54:48 PMMay 14
to Gaurav Kumar, Sejal Anand, Dileep Maurya, chromium...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, mac-r...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[Fonts] Fix PUA test codepoints: use valid PUA instead of noncharacters
The fallback-pua-first-candidate test used U+FFFFF and U+10FFFF, which
are noncharacters (General_Category=Cn), not Private Use Area codepoints
(General_Category=Co). Replace them with U+FFFFD and U+10FFFD, the last
valid PUA codepoints in Planes 15 and 16 respectively, so the test
actually exercises PUA behavior.
Refer : https://learn.microsoft.com/en-us/globalization/encoding/pua
Bug: 469837478
Change-Id: Ia7141dca16ddc55c8c87ebf9bb51b125d666c46a
Reviewed-by: Sejal Anand <sejal...@microsoft.com>
Commit-Queue: Gaurav Kumar <gaur...@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1630722}
Files:
- M third_party/blink/web_tests/inspector-protocol/layout-fonts/fallback-pua-first-candidate.js
- M third_party/blink/web_tests/platform/linux/inspector-protocol/layout-fonts/fallback-pua-first-candidate-expected.txt
- M third_party/blink/web_tests/platform/mac/inspector-protocol/layout-fonts/fallback-pua-first-candidate-expected.txt
- M third_party/blink/web_tests/platform/win/inspector-protocol/layout-fonts/fallback-pua-first-candidate-expected.txt
Change size: S
Delta: 4 files changed, 9 insertions(+), 9 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Sejal Anand
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages