Fix RangeError during AST parsing in SourceMapScopesInfo [devtools/devtools-frontend : main]

[Simon Zünd (Gerrit)]

Attention needed from Philip Pfaffe

Simon Zünd voted and added 1 comment

Votes added by Simon Zünd

Commit-Queue

+1

1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Simon Zünd . resolved

PTAL, for very large source maps (e.g. dart), the call stack will still take a while on the first pause to show up, so we might have to show a spinner there at some point or show the untranslated stack trace for a bit until the translation is ready.

Any sub-sequent pause will be very fast though, since the scope tree is handled.

Open in Gerrit

Related details

Attention is currently required from:

• Philip Pfaffe

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: devtools/devtools-frontend

Gerrit-Branch: main

Gerrit-Change-Id: I384e4d1e5eaf8faa4485558b7868c6e8600c4fb5

Gerrit-Change-Number: 7693621

Gerrit-PatchSet: 2

Gerrit-Owner: Simon Zünd <szu...@chromium.org>

Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>

Gerrit-Reviewer: Simon Zünd <szu...@chromium.org>

Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Philip Pfaffe <pfa...@chromium.org>

Gerrit-Comment-Date: Tue, 24 Mar 2026 10:34:49 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes