[cleanup] Prefixes for `eslint-plugin-lit` [devtools/devtools-frontend : main]

0 views
Skip to first unread message

Benedikt Meurer (Gerrit)

unread,
Nov 4, 2025, 2:11:30 AM (3 days ago) Nov 4
to Nikolay Vitkov, Danil Somsikov, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Danil Somsikov and Nikolay Vitkov

Benedikt Meurer voted and added 1 comment

Votes added by Benedikt Meurer

Code-Review+1

1 comment

Commit Message
Line 12, Patchset 2 (Latest):Bug: none
Benedikt Meurer . unresolved

I suppose you're trying to bring `eslint-plugin-lit` to the codebase here? Can we have a tracking issue for all the CLs related to this please?

Open in Gerrit

Related details

Attention is currently required from:
  • Danil Somsikov
  • Nikolay Vitkov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I404479707a463246ba751683a49794cb56e18cc8
Gerrit-Change-Number: 7112283
Gerrit-PatchSet: 2
Gerrit-Owner: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-Reviewer: Benedikt Meurer <bme...@chromium.org>
Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>
Gerrit-Reviewer: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-Attention: Danil Somsikov <d...@chromium.org>
Gerrit-Comment-Date: Tue, 04 Nov 2025 07:11:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Nikolay Vitkov (Gerrit)

unread,
Nov 4, 2025, 5:38:30 AM (3 days ago) Nov 4
to Danil Somsikov, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Danil Somsikov

Nikolay Vitkov added 2 comments

File front_end/panels/css_overview/CSSOverviewCompletedView.ts
Line 505, Patchset 1 (Parent): <div class="contrast-warning hidden" $="apca">
Nikolay Vitkov . unresolved

Left over from the Fragment impl.

File front_end/panels/recorder/components/StepView.ts
Line 459, Patchset 1: <svg slot="icon" width="24" height="24" class="icon">
Nikolay Vitkov . unresolved

The first one always takes precedent.

Open in Gerrit

Related details

Attention is currently required from:
  • Danil Somsikov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I404479707a463246ba751683a49794cb56e18cc8
Gerrit-Change-Number: 7112283
Gerrit-PatchSet: 2
Gerrit-Owner: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-Reviewer: Benedikt Meurer <bme...@chromium.org>
Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>
Gerrit-Reviewer: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Danil Somsikov <d...@chromium.org>
Gerrit-Comment-Date: Tue, 04 Nov 2025 10:38:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Nikolay Vitkov (Gerrit)

unread,
Nov 4, 2025, 5:42:54 AM (3 days ago) Nov 4
to Danil Somsikov, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Danil Somsikov

Nikolay Vitkov added 3 comments

Commit Message
Line 12, Patchset 2:Bug: none
Benedikt Meurer . resolved

I suppose you're trying to bring `eslint-plugin-lit` to the codebase here? Can we have a tracking issue for all the CLs related to this please?

Nikolay Vitkov

Done

File front_end/panels/css_overview/CSSOverviewCompletedView.ts
Line 505, Patchset 1 (Parent): <div class="contrast-warning hidden" $="apca">
Nikolay Vitkov . resolved

Left over from the Fragment impl.

Nikolay Vitkov

Done

File front_end/panels/recorder/components/StepView.ts
Line 459, Patchset 1: <svg slot="icon" width="24" height="24" class="icon">
Nikolay Vitkov . resolved

The first one always takes precedent.

Nikolay Vitkov

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Danil Somsikov
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: devtools/devtools-frontend
    Gerrit-Branch: main
    Gerrit-Change-Id: I404479707a463246ba751683a49794cb56e18cc8
    Gerrit-Change-Number: 7112283
    Gerrit-PatchSet: 3
    Gerrit-Owner: Nikolay Vitkov <nvi...@chromium.org>
    Gerrit-Reviewer: Benedikt Meurer <bme...@chromium.org>
    Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>
    Gerrit-Reviewer: Nikolay Vitkov <nvi...@chromium.org>
    Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Attention: Danil Somsikov <d...@chromium.org>
    Gerrit-Comment-Date: Tue, 04 Nov 2025 10:42:49 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Benedikt Meurer <bme...@chromium.org>
    Comment-In-Reply-To: Nikolay Vitkov <nvi...@chromium.org>
    satisfied_requirement
    open
    diffy

    Nikolay Vitkov (Gerrit)

    unread,
    Nov 4, 2025, 5:55:59 AM (3 days ago) Nov 4
    to Danil Somsikov, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
    Attention needed from Danil Somsikov

    Nikolay Vitkov voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Danil Somsikov
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: devtools/devtools-frontend
    Gerrit-Branch: main
    Gerrit-Change-Id: I404479707a463246ba751683a49794cb56e18cc8
    Gerrit-Change-Number: 7112283
    Gerrit-PatchSet: 3
    Gerrit-Owner: Nikolay Vitkov <nvi...@chromium.org>
    Gerrit-Reviewer: Benedikt Meurer <bme...@chromium.org>
    Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>
    Gerrit-Reviewer: Nikolay Vitkov <nvi...@chromium.org>
    Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Attention: Danil Somsikov <d...@chromium.org>
    Gerrit-Comment-Date: Tue, 04 Nov 2025 10:55:54 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Devtools-frontend LUCI CQ (Gerrit)

    unread,
    Nov 4, 2025, 6:01:12 AM (3 days ago) Nov 4
    to Nikolay Vitkov, Benedikt Meurer, Danil Somsikov, devtools-rev...@chromium.org

    Devtools-frontend LUCI CQ submitted the change

    Unreviewed changes

    2 is the latest approved patch-set.
    No files were changed between the latest approved patch-set and the submitted one.

    Change information

    Commit message:
    [cleanup] Prefixes for `eslint-plugin-lit`

    Cleans up some error detected by the plugin that make should be
    fixed whether or not we introduce the plugin.
    Bug: 457654458
    Change-Id: I404479707a463246ba751683a49794cb56e18cc8
    Reviewed-by: Benedikt Meurer <bme...@chromium.org>
    Commit-Queue: Nikolay Vitkov <nvi...@chromium.org>
    Files:
    • M eslint.config.mjs
    • M front_end/panels/animation/AnimationTimeline.ts
    • M front_end/panels/css_overview/CSSOverviewCompletedView.ts
    • M front_end/panels/linear_memory_inspector/components/LinearMemoryInspector.ts
    • M front_end/panels/linear_memory_inspector/components/LinearMemoryNavigator.ts
    • M front_end/panels/network/components/EditableSpan.ts
    • M front_end/panels/recorder/components/StepView.ts
    • M front_end/panels/settings/emulation/components/UserAgentClientHintsForm.ts
    • M front_end/panels/timeline/components/SidebarSingleInsightSet.ts
    • M front_end/panels/utils/utils.ts
    • M front_end/ui/components/panel_feedback/PreviewToggle.ts
    • M front_end/ui/legacy/UIUtils.test.ts
    Change size: M
    Delta: 12 files changed, 39 insertions(+), 32 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Benedikt Meurer
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: devtools/devtools-frontend
    Gerrit-Branch: main
    Gerrit-Change-Id: I404479707a463246ba751683a49794cb56e18cc8
    Gerrit-Change-Number: 7112283
    Gerrit-PatchSet: 4
    Gerrit-Owner: Nikolay Vitkov <nvi...@chromium.org>
    Gerrit-Reviewer: Benedikt Meurer <bme...@chromium.org>
    Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>
    Gerrit-Reviewer: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Nikolay Vitkov <nvi...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages