Erik Chen (Gerrit)

unread,

Apr 10, 2026, 4:02:22 PM (5 days ago) Apr 10

to Darryl James, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Nikhil Nayunigari, andysjl...@chromium.org, arc-review...@google.com, asumane...@google.com, browser-comp...@chromium.org, chadduffin+w...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, dfried...@chromium.org, dkrahn...@chromium.org, dtraino...@chromium.org, ejcaruso+wa...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, hidehik...@chromium.org, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, khmel...@chromium.org, khorimoto+w...@chromium.org, mfoltz+wa...@chromium.org, mickeybu...@chromium.org, net-r...@chromium.org, nwoked...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, rginda...@chromium.org, rrsilva+wat...@google.com, stevenjb+wa...@chromium.org, tbarzi...@chromium.org, translat...@chromium.org, vakh+safe_br...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, yhanada+...@chromium.org, zackha...@chromium.org

Attention needed from Darryl James

Erik Chen voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

Darryl James

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Erik Chen (Gerrit)

unread,

Apr 10, 2026, 4:27:18 PM (5 days ago) Apr 10

to Lei Zhang, Joe Downing, Dana Fried, Tom Lukaszewicz, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Nikhil Nayunigari, andysjl...@chromium.org, arc-review...@google.com, asumane...@google.com, browser-comp...@chromium.org, chadduffin+w...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, dfried...@chromium.org, dkrahn...@chromium.org, dtraino...@chromium.org, ejcaruso+wa...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, hidehik...@chromium.org, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, khmel...@chromium.org, khorimoto+w...@chromium.org, mfoltz+wa...@chromium.org, mickeybu...@chromium.org, net-r...@chromium.org, nwoked...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, rginda...@chromium.org, rrsilva+wat...@google.com, stevenjb+wa...@chromium.org, tbarzi...@chromium.org, translat...@chromium.org, vakh+safe_br...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, yhanada+...@chromium.org, zackha...@chromium.org

Attention needed from Dana Fried, Joe Downing, Lei Zhang and Tom Lukaszewicz

Erik Chen added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Erik Chen . resolved

thestig: PTAL components/os_crypt
joedow: PTAL remoting

Open in Gerrit

Related details

Attention is currently required from:

Dana Fried
Joe Downing
Lei Zhang
Tom Lukaszewicz

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Joe Downing (Gerrit)

unread,

Apr 10, 2026, 4:29:29 PM (5 days ago) Apr 10

to Erik Chen, Lei Zhang, Dana Fried, Tom Lukaszewicz, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Nikhil Nayunigari, andysjl...@chromium.org, arc-review...@google.com, asumane...@google.com, browser-comp...@chromium.org, chadduffin+w...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, dfried...@chromium.org, dkrahn...@chromium.org, dtraino...@chromium.org, ejcaruso+wa...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, hidehik...@chromium.org, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, khmel...@chromium.org, khorimoto+w...@chromium.org, mfoltz+wa...@chromium.org, mickeybu...@chromium.org, net-r...@chromium.org, nwoked...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, rginda...@chromium.org, rrsilva+wat...@google.com, stevenjb+wa...@chromium.org, tbarzi...@chromium.org, translat...@chromium.org, vakh+safe_br...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, yhanada+...@chromium.org, zackha...@chromium.org

Attention needed from Dana Fried, Erik Chen, Lei Zhang and Tom Lukaszewicz

Joe Downing voted and added 1 comment

Votes added by Joe Downing

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Joe Downing . resolved

lgtm for remoting

Open in Gerrit

Related details

Attention is currently required from:

Dana Fried
Erik Chen
Lei Zhang
Tom Lukaszewicz

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Dana Fried (Gerrit)

unread,

Apr 10, 2026, 4:35:33 PM (5 days ago) Apr 10

to Erik Chen, Joe Downing, Lei Zhang, Tom Lukaszewicz, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Nikhil Nayunigari, andysjl...@chromium.org, arc-review...@google.com, asumane...@google.com, browser-comp...@chromium.org, chadduffin+w...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, dfried...@chromium.org, dkrahn...@chromium.org, dtraino...@chromium.org, ejcaruso+wa...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, hidehik...@chromium.org, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, khmel...@chromium.org, khorimoto+w...@chromium.org, mfoltz+wa...@chromium.org, mickeybu...@chromium.org, net-r...@chromium.org, nwoked...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, rginda...@chromium.org, rrsilva+wat...@google.com, stevenjb+wa...@chromium.org, tbarzi...@chromium.org, translat...@chromium.org, vakh+safe_br...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, yhanada+...@chromium.org, zackha...@chromium.org

Attention needed from Erik Chen, Lei Zhang and Tom Lukaszewicz

Dana Fried voted and added 1 comment

Votes added by Dana Fried

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Dana Fried . resolved

Actually this was pretty chill.

Open in Gerrit

Related details

Attention is currently required from:

satisfied_requirement

unsatisfied_requirement

open

diffy

Tom Lukaszewicz (Gerrit)

unread,

Apr 12, 2026, 2:25:25 PM (3 days ago) Apr 12

to Erik Chen, Dana Fried, Joe Downing, Lei Zhang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Nikhil Nayunigari, andysjl...@chromium.org, arc-review...@google.com, asumane...@google.com, browser-comp...@chromium.org, chadduffin+w...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, dfried...@chromium.org, dkrahn...@chromium.org, dtraino...@chromium.org, ejcaruso+wa...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, hidehik...@chromium.org, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, khmel...@chromium.org, khorimoto+w...@chromium.org, mfoltz+wa...@chromium.org, mickeybu...@chromium.org, net-r...@chromium.org, nwoked...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, rginda...@chromium.org, rrsilva+wat...@google.com, stevenjb+wa...@chromium.org, tbarzi...@chromium.org, translat...@chromium.org, vakh+safe_br...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, yhanada+...@chromium.org, zackha...@chromium.org

Attention needed from Erik Chen and Lei Zhang

Tom Lukaszewicz voted and added 1 comment

Votes added by Tom Lukaszewicz

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Tom Lukaszewicz . resolved

lgtm!

Open in Gerrit

Related details

Attention is currently required from:

Erik Chen
Lei Zhang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

Apr 13, 2026, 12:56:47 PM (2 days ago) Apr 13

to Erik Chen, Lei Zhang, Tom Lukaszewicz, Dana Fried, Joe Downing, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Nikhil Nayunigari, andysjl...@chromium.org, arc-review...@google.com, asumane...@google.com, browser-comp...@chromium.org, chadduffin+w...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, dfried...@chromium.org, dkrahn...@chromium.org, dtraino...@chromium.org, ejcaruso+wa...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, hidehik...@chromium.org, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, khmel...@chromium.org, khorimoto+w...@chromium.org, mfoltz+wa...@chromium.org, mickeybu...@chromium.org, net-r...@chromium.org, nwoked...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, rginda...@chromium.org, rrsilva+wat...@google.com, stevenjb+wa...@chromium.org, tbarzi...@chromium.org, translat...@chromium.org, vakh+safe_br...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, yhanada+...@chromium.org, zackha...@chromium.org

Attention needed from Erik Chen

Lei Zhang voted and added 2 comments

Votes added by Lei Zhang

Code-Review

+1

2 comments

File chrome/browser/net/BUILD.gn

Line 253, Patchset 3 (Latest): if (is_win) {

Lei Zhang . unresolved

Move above enable_extensions_core - group platform conditionals.

Line 289, Patchset 3 (Latest): if (chrome_root_store_cert_management_ui) {

Lei Zhang . unresolved

Move above enable_extensions_core to sort feature flag based conditionals.

Open in Gerrit

Related details

Attention is currently required from:

Erik Chen

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

Apr 13, 2026, 12:57:17 PM (2 days ago) Apr 13

to Erik Chen, Lei Zhang, Tom Lukaszewicz, Dana Fried, Joe Downing, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Nikhil Nayunigari, andysjl...@chromium.org, arc-review...@google.com, asumane...@google.com, browser-comp...@chromium.org, chadduffin+w...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, dfried...@chromium.org, dkrahn...@chromium.org, dtraino...@chromium.org, ejcaruso+wa...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, hidehik...@chromium.org, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, khmel...@chromium.org, khorimoto+w...@chromium.org, mfoltz+wa...@chromium.org, mickeybu...@chromium.org, net-r...@chromium.org, nwoked...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, rginda...@chromium.org, rrsilva+wat...@google.com, stevenjb+wa...@chromium.org, tbarzi...@chromium.org, translat...@chromium.org, vakh+safe_br...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, yhanada+...@chromium.org, zackha...@chromium.org

Attention needed from Erik Chen

Lei Zhang added 1 comment

File components/os_crypt/sync/BUILD.gn

Line 13, Patchset 3 (Latest): "//chrome/browser",

Lei Zhang . unresolved

Can this be removed?

satisfied_requirement

unsatisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

Apr 13, 2026, 1:11:32 PM (2 days ago) Apr 13

to Erik Chen, Lei Zhang, Tom Lukaszewicz, Dana Fried, Joe Downing, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Nikhil Nayunigari, andysjl...@chromium.org, arc-review...@google.com, asumane...@google.com, browser-comp...@chromium.org, chadduffin+w...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, dfried...@chromium.org, dkrahn...@chromium.org, dtraino...@chromium.org, ejcaruso+wa...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, hidehik...@chromium.org, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, khmel...@chromium.org, khorimoto+w...@chromium.org, mfoltz+wa...@chromium.org, mickeybu...@chromium.org, net-r...@chromium.org, nwoked...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, rginda...@chromium.org, rrsilva+wat...@google.com, stevenjb+wa...@chromium.org, tbarzi...@chromium.org, translat...@chromium.org, vakh+safe_br...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, yhanada+...@chromium.org, zackha...@chromium.org

Attention needed from Erik Chen

Lei Zhang added 1 comment

File components/os_crypt/sync/BUILD.gn

Line 13, Patchset 3 (Latest): "//chrome/browser",

Lei Zhang . resolved

Can this be removed?

Lei Zhang

Looks like no.

satisfied_requirement

unsatisfied_requirement

open

diffy

Erik Chen (Gerrit)

unread,

Apr 13, 2026, 2:02:50 PM (2 days ago) Apr 13

to Lei Zhang, Thomas Lukaszewicz, Dana Fried, Joe Downing, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Nikhil Nayunigari, andysjl...@chromium.org, arc-review...@google.com, asumane...@google.com, browser-comp...@chromium.org, chadduffin+w...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, dfried...@chromium.org, dkrahn...@chromium.org, dtraino...@chromium.org, ejcaruso+wa...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, hidehik...@chromium.org, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, khmel...@chromium.org, khorimoto+w...@chromium.org, mfoltz+wa...@chromium.org, mickeybu...@chromium.org, net-r...@chromium.org, nwoked...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, rginda...@chromium.org, rrsilva+wat...@google.com, stevenjb+wa...@chromium.org, tbarzi...@chromium.org, translat...@chromium.org, vakh+safe_br...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, yhanada+...@chromium.org, zackha...@chromium.org

Attention needed from Dana Fried, Joe Downing, Lei Zhang and Thomas Lukaszewicz

Erik Chen added 3 comments

File chrome/browser/net/BUILD.gn

Line 253, Patchset 3: if (is_win) {

Lei Zhang . resolved

Move above enable_extensions_core - group platform conditionals.

Erik Chen

Done

Line 289, Patchset 3: if (chrome_root_store_cert_management_ui) {

Lei Zhang . resolved

Move above enable_extensions_core to sort feature flag based conditionals.

Erik Chen

Done

File components/os_crypt/sync/BUILD.gn

Line 13, Patchset 3: "//chrome/browser",

Lei Zhang . resolved

Can this be removed?

Erik Chen

ERROR at //build/config/BUILDCONFIG.gn:554:5: Dependency not allowed.
    target(_target_type, target_name) {
    ^----------------------------------
The item //chrome/browser/net:impl
can not depend on //components/os_crypt/sync:sync
because it is not in //components/os_crypt/sync:sync's visibility list: [
  //chrome/browser:browser
  //chrome/test:test_support
  //components/os_crypt/async/browser:dpapi_key_provider
  //components/os_crypt/async/browser:freedesktop_secret_key_provider
  //components/os_crypt/async/browser:keychain_key_provider
  //components/os_crypt/async/browser:secret_portal_key_provider
  //components/os_crypt/async/browser:unit_tests
  //components/os_crypt/async/common:common
  //components/os_crypt/async/common:unit_tests
  //components/os_crypt/sync:test_support
  //components/os_crypt/sync:unit_tests
  //components/signin/core/browser:browser
  //headless:headless_browser
  //ios/chrome/browser/web/model:web_internal
  //services/network:network_service
  //services/test/echo:lib
  //headless:headless_shell_lib
]

which comes from
https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/net/system_network_context_manager.cc;l=52?q=os_crypt%20file:chrome%2Fbrowser%2Fnet%20-file:test&ss=chromium

    cookie_encryption_provider_ =
        std::make_unique<CookieEncryptionProviderImpl>(
            g_browser_process->os_crypt_async());
            
            
and also:
    // On Windows, OSCrypt Async manages the encryption key via the DPAPI key
    // provider, and there is no need to send the key separately to OSCrypt
    // sync.
#if !BUILDFLAG(IS_WIN)
    network_service->SetEncryptionKey(OSCrypt::GetRawEncryptionKey());
#endif  // !BUILDFLAG(IS_WIN)

Open in Gerrit

Related details

Attention is currently required from:

Dana Fried
Joe Downing
Lei Zhang

Thomas Lukaszewicz

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

Apr 13, 2026, 2:06:02 PM (2 days ago) Apr 13

to Erik Chen, Lei Zhang, Thomas Lukaszewicz, Dana Fried, Joe Downing, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Nikhil Nayunigari, andysjl...@chromium.org, arc-review...@google.com, asumane...@google.com, browser-comp...@chromium.org, chadduffin+w...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, dfried...@chromium.org, dkrahn...@chromium.org, dtraino...@chromium.org, ejcaruso+wa...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, hidehik...@chromium.org, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, khmel...@chromium.org, khorimoto+w...@chromium.org, mfoltz+wa...@chromium.org, mickeybu...@chromium.org, net-r...@chromium.org, nwoked...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, rginda...@chromium.org, rrsilva+wat...@google.com, stevenjb+wa...@chromium.org, tbarzi...@chromium.org, translat...@chromium.org, vakh+safe_br...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, yhanada+...@chromium.org, zackha...@chromium.org

Attention needed from Dana Fried, Erik Chen, Joe Downing and Thomas Lukaszewicz

Lei Zhang voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Dana Fried
Erik Chen
Joe Downing
Thomas Lukaszewicz

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Joe Downing (Gerrit)

unread,

Apr 13, 2026, 2:06:06 PM (2 days ago) Apr 13

to Erik Chen, Lei Zhang, Thomas Lukaszewicz, Dana Fried, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Nikhil Nayunigari, andysjl...@chromium.org, arc-review...@google.com, asumane...@google.com, browser-comp...@chromium.org, chadduffin+w...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, dfried...@chromium.org, dkrahn...@chromium.org, dtraino...@chromium.org, ejcaruso+wa...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, hidehik...@chromium.org, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, khmel...@chromium.org, khorimoto+w...@chromium.org, mfoltz+wa...@chromium.org, mickeybu...@chromium.org, net-r...@chromium.org, nwoked...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, rginda...@chromium.org, rrsilva+wat...@google.com, stevenjb+wa...@chromium.org, tbarzi...@chromium.org, translat...@chromium.org, vakh+safe_br...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, yhanada+...@chromium.org, zackha...@chromium.org

Attention needed from Dana Fried, Erik Chen and Thomas Lukaszewicz

Joe Downing voted and added 1 comment

Votes added by Joe Downing

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Joe Downing . resolved

remoting still lgtm

Open in Gerrit

Related details

Attention is currently required from:

Dana Fried
Erik Chen
Thomas Lukaszewicz

satisfied_requirement

open

diffy

Thomas Lukaszewicz (Gerrit)

unread,

Apr 13, 2026, 2:19:17 PM (2 days ago) Apr 13

to Erik Chen, Joe Downing, Lei Zhang, Dana Fried, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Nikhil Nayunigari, andysjl...@chromium.org, arc-review...@google.com, asumane...@google.com, browser-comp...@chromium.org, chadduffin+w...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, dfried...@chromium.org, dkrahn...@chromium.org, dtraino...@chromium.org, ejcaruso+wa...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, hidehik...@chromium.org, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, khmel...@chromium.org, khorimoto+w...@chromium.org, mfoltz+wa...@chromium.org, mickeybu...@chromium.org, net-r...@chromium.org, nwoked...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, rginda...@chromium.org, rrsilva+wat...@google.com, stevenjb+wa...@chromium.org, tbarzi...@chromium.org, translat...@chromium.org, vakh+safe_br...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, yhanada+...@chromium.org, zackha...@chromium.org

Attention needed from Dana Fried and Erik Chen

Thomas Lukaszewicz voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Dana Fried
Erik Chen

satisfied_requirement

open

diffy

Erik Chen (Gerrit)

unread,

Apr 13, 2026, 3:05:37 PM (2 days ago) Apr 13

to Thomas Lukaszewicz, Joe Downing, Lei Zhang, Dana Fried, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Nikhil Nayunigari, andysjl...@chromium.org, arc-review...@google.com, asumane...@google.com, browser-comp...@chromium.org, chadduffin+w...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, dfried...@chromium.org, dkrahn...@chromium.org, dtraino...@chromium.org, ejcaruso+wa...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, hidehik...@chromium.org, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, khmel...@chromium.org, khorimoto+w...@chromium.org, mfoltz+wa...@chromium.org, mickeybu...@chromium.org, net-r...@chromium.org, nwoked...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, rginda...@chromium.org, rrsilva+wat...@google.com, stevenjb+wa...@chromium.org, tbarzi...@chromium.org, translat...@chromium.org, vakh+safe_br...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, yhanada+...@chromium.org, zackha...@chromium.org

Attention needed from Dana Fried

Erik Chen voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

Dana Fried

satisfied_requirement

open

diffy

chromium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,

Apr 13, 2026, 3:49:09 PM (2 days ago) Apr 13

to Erik Chen, Thomas Lukaszewicz, Joe Downing, Lei Zhang, Dana Fried, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Nikhil Nayunigari, andysjl...@chromium.org, arc-review...@google.com, asumane...@google.com, browser-comp...@chromium.org, chadduffin+w...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, dfried...@chromium.org, dkrahn...@chromium.org, dtraino...@chromium.org, ejcaruso+wa...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, hidehik...@chromium.org, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, khmel...@chromium.org, khorimoto+w...@chromium.org, mfoltz+wa...@chromium.org, mickeybu...@chromium.org, net-r...@chromium.org, nwoked...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, rginda...@chromium.org, rrsilva+wat...@google.com, stevenjb+wa...@chromium.org, tbarzi...@chromium.org, translat...@chromium.org, vakh+safe_br...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, yhanada+...@chromium.org, zackha...@chromium.org

chromiu...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:

Modularize //chrome/browser/net

Extract chrome/browser/net sources from the monolithic
chrome/browser:browser static_library into dedicated :net (public
headers) and :impl (sources) targets in chrome/browser/net/BUILD.gn.
Update all dependent BUILD.gn files across chrome/browser and other
components to depend on the new targets.

Bug: 353332589

Change-Id: Ibae86cdd78e6566f4688559c864baea61ae16833

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7748201

Reviewed-by: Thomas Lukaszewicz <tl...@chromium.org>

Reviewed-by: Joe Downing <joe...@chromium.org>

Commit-Queue: Erik Chen <erik...@chromium.org>

Reviewed-by: Lei Zhang <the...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1613915}

Files:

M chrome/browser/BUILD.gn
M chrome/browser/android/BUILD.gn
M chrome/browser/ash/app_mode/BUILD.gn
M chrome/browser/ash/arc/auth/BUILD.gn
M chrome/browser/ash/arc/enterprise/cert_store/BUILD.gn
M chrome/browser/ash/arc/net/BUILD.gn
M chrome/browser/ash/arc/session/BUILD.gn
M chrome/browser/ash/attestation/BUILD.gn
M chrome/browser/ash/bruschetta/BUILD.gn
M chrome/browser/ash/customization/BUILD.gn
M chrome/browser/ash/drive/BUILD.gn
M chrome/browser/ash/extensions/file_manager/BUILD.gn
M chrome/browser/ash/kcer/BUILD.gn
M chrome/browser/ash/kcer/nssdb_migration/BUILD.gn
M chrome/browser/ash/login/BUILD.gn
M chrome/browser/ash/login/enrollment/BUILD.gn
M chrome/browser/ash/login/screens/BUILD.gn
M chrome/browser/ash/login/session/BUILD.gn
M chrome/browser/ash/main_parts/BUILD.gn
M chrome/browser/ash/net/BUILD.gn
M chrome/browser/ash/net/dns_over_https/BUILD.gn
M chrome/browser/ash/ownership/BUILD.gn
M chrome/browser/ash/platform_keys/BUILD.gn
M chrome/browser/ash/policy/core/BUILD.gn
M chrome/browser/ash/policy/enrollment/BUILD.gn
M chrome/browser/ash/policy/login/BUILD.gn
M chrome/browser/ash/printing/BUILD.gn
M chrome/browser/ash/report_controller_initializer/BUILD.gn
M chrome/browser/ash/wallpaper_handlers/BUILD.gn
M chrome/browser/assist_ranker/BUILD.gn
M chrome/browser/autofill/BUILD.gn
M chrome/browser/chromeos/extensions/wallpaper/BUILD.gn
M chrome/browser/component_updater/BUILD.gn
M chrome/browser/device_api/BUILD.gn
M chrome/browser/devtools/BUILD.gn
M chrome/browser/download/BUILD.gn
M chrome/browser/enterprise/BUILD.gn
M chrome/browser/extensions/BUILD.gn
M chrome/browser/image_fetcher/BUILD.gn
M chrome/browser/media/router/BUILD.gn
M chrome/browser/net/BUILD.gn
M chrome/browser/offline_pages/BUILD.gn
M chrome/browser/policy/BUILD.gn
M chrome/browser/prefs/BUILD.gn
M chrome/browser/privacy/BUILD.gn
M chrome/browser/safe_browsing/BUILD.gn
M chrome/browser/signin/BUILD.gn
M chrome/browser/translate/BUILD.gn
M chrome/browser/ui/BUILD.gn
M chrome/browser/ui/tabs/BUILD.gn
M chrome/browser/ui/webui/ash/login/BUILD.gn
M chrome/browser/ui/webui/ash/network_ui/BUILD.gn
M chrome/browser/ui/webui/signin/BUILD.gn
M chrome/browser/ui/webui/whats_new/BUILD.gn
M components/os_crypt/sync/BUILD.gn
M remoting/host/chromeos/BUILD.gn

Change size: L

Delta: 56 files changed, 335 insertions(+), 93 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Lei Zhang, +1 by Thomas Lukaszewicz, +1 by Joe Downing

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Modularize //chrome/browser/net [chromium/src : main]

Erik Chen (Gerrit)

Erik Chen voted Commit-Queue+1

Related details

Erik Chen (Gerrit)

Erik Chen added 1 comment

Related details

Joe Downing (Gerrit)

Joe Downing voted and added 1 comment

Votes added by Joe Downing

1 comment

Related details

Dana Fried (Gerrit)

Dana Fried voted and added 1 comment

Votes added by Dana Fried

1 comment

Related details

Tom Lukaszewicz (Gerrit)

Tom Lukaszewicz voted and added 1 comment

Votes added by Tom Lukaszewicz

1 comment

Related details

Lei Zhang (Gerrit)

Lei Zhang voted and added 2 comments

Votes added by Lei Zhang

2 comments

Related details

Lei Zhang (Gerrit)

Lei Zhang added 1 comment

Lei Zhang (Gerrit)

Lei Zhang added 1 comment

Erik Chen (Gerrit)

Erik Chen added 3 comments

Related details

Lei Zhang (Gerrit)

Lei Zhang voted Code-Review+1

Related details

Joe Downing (Gerrit)

Joe Downing voted and added 1 comment

Votes added by Joe Downing

1 comment

Related details

Thomas Lukaszewicz (Gerrit)

Thomas Lukaszewicz voted Code-Review+1

Related details

Erik Chen (Gerrit)

Erik Chen voted Commit-Queue+2

Related details

chromium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

chromiu...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information