[AI] Move suggestions parsing to base AiAgent class [devtools/devtools-frontend : main]

0 views
Skip to first unread message

Connor Clark (Gerrit)

unread,
Sep 23, 2025, 2:58:17 PM (14 hours ago) Sep 23
to Alex Rudenko, devtools-rev...@chromium.org
Attention needed from Alex Rudenko

Connor Clark voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alex Rudenko
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I775a93e7e36ca710267f2e31d1da52adb4bb7df3
Gerrit-Change-Number: 6976654
Gerrit-PatchSet: 1
Gerrit-Owner: Connor Clark <cja...@chromium.org>
Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Connor Clark <cja...@chromium.org>
Gerrit-Attention: Alex Rudenko <alexr...@chromium.org>
Gerrit-Comment-Date: Tue, 23 Sep 2025 18:58:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Alex Rudenko (Gerrit)

unread,
Sep 23, 2025, 3:02:17 PM (14 hours ago) Sep 23
to Connor Clark, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Connor Clark

Alex Rudenko voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Connor Clark
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I775a93e7e36ca710267f2e31d1da52adb4bb7df3
Gerrit-Change-Number: 6976654
Gerrit-PatchSet: 1
Gerrit-Owner: Connor Clark <cja...@chromium.org>
Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Connor Clark <cja...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Connor Clark <cja...@chromium.org>
Gerrit-Comment-Date: Tue, 23 Sep 2025 19:02:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Alex Rudenko (Gerrit)

unread,
Sep 23, 2025, 3:02:23 PM (14 hours ago) Sep 23
to Connor Clark, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Connor Clark

Alex Rudenko added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Alex Rudenko . resolved

Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Connor Clark
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I775a93e7e36ca710267f2e31d1da52adb4bb7df3
Gerrit-Change-Number: 6976654
Gerrit-PatchSet: 1
Gerrit-Owner: Connor Clark <cja...@chromium.org>
Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Connor Clark <cja...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Connor Clark <cja...@chromium.org>
Gerrit-Comment-Date: Tue, 23 Sep 2025 19:02:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

Devtools-frontend LUCI CQ (Gerrit)

unread,
Sep 23, 2025, 3:32:58 PM (13 hours ago) Sep 23
to Connor Clark, Alex Rudenko, devtools-rev...@chromium.org

Devtools-frontend LUCI CQ submitted the change

Change information

Commit message:
[AI] Move suggestions parsing to base AiAgent class
Bug: 442392194
Change-Id: I775a93e7e36ca710267f2e31d1da52adb4bb7df3
Auto-Submit: Connor Clark <cja...@chromium.org>
Reviewed-by: Alex Rudenko <alexr...@chromium.org>
Commit-Queue: Alex Rudenko <alexr...@chromium.org>
Commit-Queue: Connor Clark <cja...@chromium.org>
Files:
  • M front_end/models/ai_assistance/agents/AiAgent.ts
  • M front_end/models/ai_assistance/agents/PerformanceAgent.ts
  • M front_end/models/ai_assistance/agents/StylingAgent.ts
Change size: M
Delta: 3 files changed, 61 insertions(+), 92 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Alex Rudenko
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I775a93e7e36ca710267f2e31d1da52adb4bb7df3
Gerrit-Change-Number: 6976654
Gerrit-PatchSet: 2
Gerrit-Owner: Connor Clark <cja...@chromium.org>
Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Connor Clark <cja...@chromium.org>
Gerrit-Reviewer: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages