[e2e] Unregister service workers via UI [devtools/devtools-frontend : main]

[Wolfgang Beyer (Gerrit)]

Attention needed from Philip Pfaffe

Wolfgang Beyer voted and added 1 comment

Votes added by Wolfgang Beyer

Auto-Submit

+1

1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Wolfgang Beyer . resolved

Philip, PTAL.
We now have test flakiness in the tree, this CL applies the fix to other tests with service workers.

Open in Gerrit

Related details

Attention is currently required from:

• Philip Pfaffe

Submit Requirements:

• Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: devtools/devtools-frontend

Gerrit-Branch: main

Gerrit-Change-Id: I9a482bc70a9893bd5897644648985b0b57908071

Gerrit-Change-Number: 5665296

Gerrit-PatchSet: 2

Gerrit-Owner: Wolfgang Beyer <wo...@chromium.org>

Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>

Gerrit-Reviewer: Wolfgang Beyer <wo...@chromium.org>

Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Philip Pfaffe <pfa...@chromium.org>

Gerrit-Comment-Date: Fri, 28 Jun 2024 07:31:33 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Philip Pfaffe (Gerrit)]

Attention needed from Wolfgang Beyer

Philip Pfaffe voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

• Wolfgang Beyer

Submit Requirements:

• Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: devtools/devtools-frontend

Gerrit-Branch: main

Gerrit-Change-Id: I9a482bc70a9893bd5897644648985b0b57908071

Gerrit-Change-Number: 5665296

Gerrit-PatchSet: 2

Gerrit-Owner: Wolfgang Beyer <wo...@chromium.org>

Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>

Gerrit-Reviewer: Wolfgang Beyer <wo...@chromium.org>

Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Wolfgang Beyer <wo...@chromium.org>

Gerrit-Comment-Date: Fri, 28 Jun 2024 07:39:30 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Devtools-frontend LUCI CQ (Gerrit)]

Devtools-frontend LUCI CQ submitted the change

Change information

Commit message:

[e2e] Unregister service workers via UI

Follow-up to: https://crrev.com/c/5660065

Bug: none

Change-Id: I9a482bc70a9893bd5897644648985b0b57908071

Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5665296

Reviewed-by: Philip Pfaffe <pfa...@chromium.org>

Commit-Queue: Wolfgang Beyer <wo...@chromium.org>

Auto-Submit: Wolfgang Beyer <wo...@chromium.org>

Commit-Queue: Philip Pfaffe <pfa...@chromium.org>

Files:

• M test/e2e/application/frame-tree_test.ts
• M test/e2e/application/service-worker-network_test.ts
• M test/e2e/application/service-worker-update_test.ts
• M test/e2e/helpers/application-helpers.ts

Change size: S

Delta: 4 files changed, 33 insertions(+), 9 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Philip Pfaffe

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: devtools/devtools-frontend

Gerrit-Branch: main

Gerrit-Change-Id: I9a482bc70a9893bd5897644648985b0b57908071

Gerrit-Change-Number: 5665296

Gerrit-PatchSet: 3

Gerrit-Owner: Wolfgang Beyer <wo...@chromium.org>

Gerrit-Reviewer: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>