[ui/compositor] Refactor ui::Layer to use subclasses [chromium/src : main]

0 views
Skip to first unread message

Zoraiz Naeem (Gerrit)

unread,
Jun 12, 2026, 5:59:12 PM (2 days ago) Jun 12
to Mitsuru Oshima, Achuith Bhandarkar, SLSA Policy Verification Service, AJITH KUMAR V, chromium...@chromium.org, Daniel Andersson, devtools...@chromium.org, Henrique Ferreiro, (Julie)Jeongeun Kim, Sadrul Chowdhury, Zhe Su, Ian Vollick, abigailbk...@google.com, aji...@samsung.com, alexmo...@chromium.org, arc-review...@google.com, bici...@google.com, cc-...@chromium.org, creis...@chromium.org, croissant-...@chromium.org, cros-system-ui-prod...@google.com, dtseng...@chromium.org, francisjp...@google.com, hidehik...@chromium.org, hirokisa...@chromium.org, jbauma...@chromium.org, josiah...@chromium.org, katie...@chromium.org, keithle...@chromium.org, kyungjunle...@google.com, lens-chrome...@google.com, mac-r...@chromium.org, mercer...@google.com, navigation...@chromium.org, nektar...@chromium.org, nona+...@chromium.org, oshima...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, stanfie...@google.com, toshikikikuchi+...@chromium.org, tote-eng...@google.com, tranbaod...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, yuzo+...@chromium.org
Attention needed from Mitsuru Oshima

Zoraiz Naeem voted and added 2 comments

Votes added by Zoraiz Naeem

Commit-Queue+1

2 comments

Patchset-level comments
File-level comment, Patchset 8 (Latest):
Zoraiz Naeem . resolved

PTAL.

File ui/compositor/layer.h
Line 929, Patchset 7:class COMPOSITOR_EXPORT LayerNotDrawn : public Layer {
Zoraiz Naeem . unresolved

More type based functionality will be moved to these types.

Open in Gerrit

Related details

Attention is currently required from:
  • Mitsuru Oshima
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0e66f19d0a527f44f491c5e898466dca0e0fdf65
Gerrit-Change-Number: 7928750
Gerrit-PatchSet: 8
Gerrit-Owner: Zoraiz Naeem <zorai...@chromium.org>
Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>
Gerrit-Reviewer: Zoraiz Naeem <zorai...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: AJITH KUMAR V <aji...@chromium.org>
Gerrit-CC: Achuith Bhandarkar <ach...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Daniel Andersson <dande...@chromium.org>
Gerrit-CC: Henrique Ferreiro <hfer...@igalia.com>
Gerrit-CC: Ian Vollick <vol...@chromium.org>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-CC: Zhe Su <su...@chromium.org>
Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Comment-Date: Fri, 12 Jun 2026 21:58:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages