Record screenshot errors when running locally [devtools/devtools-frontend : main]

0 views
Skip to first unread message

Philip Pfaffe (Gerrit)

unread,
Sep 18, 2025, 8:26:54 AM (6 days ago) Sep 18
to Jack Franklin, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Jack Franklin

Philip Pfaffe voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jack Franklin
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I389b5402a5fcbc11b6f8db9261594d0c8750fda1
Gerrit-Change-Number: 6965019
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Pfaffe <pfa...@chromium.org>
Gerrit-Reviewer: Jack Franklin <jacktf...@chromium.org>
Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Jack Franklin <jacktf...@chromium.org>
Gerrit-Comment-Date: Thu, 18 Sep 2025 12:26:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Jack Franklin (Gerrit)

unread,
Sep 23, 2025, 10:34:43 AM (18 hours ago) Sep 23
to Philip Pfaffe, Code Review Nudger, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Philip Pfaffe

Jack Franklin voted and added 1 comment

Votes added by Jack Franklin

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Jack Franklin . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Philip Pfaffe
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I389b5402a5fcbc11b6f8db9261594d0c8750fda1
Gerrit-Change-Number: 6965019
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Pfaffe <pfa...@chromium.org>
Gerrit-Reviewer: Jack Franklin <jacktf...@chromium.org>
Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Philip Pfaffe <pfa...@chromium.org>
Gerrit-Comment-Date: Tue, 23 Sep 2025 14:34:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Philip Pfaffe (Gerrit)

unread,
Sep 23, 2025, 10:38:14 AM (18 hours ago) Sep 23
to Jack Franklin, Code Review Nudger, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org

Philip Pfaffe voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I389b5402a5fcbc11b6f8db9261594d0c8750fda1
Gerrit-Change-Number: 6965019
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Pfaffe <pfa...@chromium.org>
Gerrit-Reviewer: Jack Franklin <jacktf...@chromium.org>
Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Comment-Date: Tue, 23 Sep 2025 14:38:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Devtools-frontend LUCI CQ (Gerrit)

unread,
Sep 23, 2025, 11:27:14 AM (17 hours ago) Sep 23
to Philip Pfaffe, Jack Franklin, Code Review Nudger, devtools-rev...@chromium.org

Devtools-frontend LUCI CQ submitted the change

Change information

Commit message:
Record screenshot errors when running locally

And add a simple viewer to view screenshot results.
Bug: none
Change-Id: I389b5402a5fcbc11b6f8db9261594d0c8750fda1
Commit-Queue: Philip Pfaffe <pfa...@chromium.org>
Auto-Submit: Philip Pfaffe <pfa...@chromium.org>
Reviewed-by: Jack Franklin <jacktf...@chromium.org>
Files:
  • A scripts/test/screenshots.html
  • M test/conductor/screenshot-error.ts
  • M test/unit/karma.conf.ts
Change size: M
Delta: 3 files changed, 107 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Jack Franklin
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I389b5402a5fcbc11b6f8db9261594d0c8750fda1
Gerrit-Change-Number: 6965019
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Pfaffe <pfa...@chromium.org>
Gerrit-Reviewer: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages