[inspector] Propagate termination in doesAttributeHaveObservableSideEffectOnGet [v8/v8 : main]
0 views
Skip to first unread message
Benedikt Meurer (Gerrit)
Oct 21, 2026, 2:33:00 AM (yesterday) Oct 21
to devtools-...@chromium.org, v8-re...@googlegroups.com
Benedikt Meurer voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Benedikt Meurer (Gerrit)
Oct 21, 2026, 10:12:33 AM (yesterday) Oct 21
to v8-s...@luci-project-accounts.iam.gserviceaccount.com, devtools-...@chromium.org, v8-re...@googlegroups.com
Benedikt Meurer voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Benedikt Meurer (Gerrit)
Oct 21, 2026, 10:19:47 AM (yesterday) Oct 21
to Yang Guo, v8-s...@luci-project-accounts.iam.gserviceaccount.com, devtools-...@chromium.org, v8-re...@googlegroups.com
Attention needed from Yang Guo
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Yang Guo
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Benedikt Meurer (Gerrit)
Oct 21, 2026, 10:21:10 AM (yesterday) Oct 21
to Yang Guo, v8-s...@luci-project-accounts.iam.gserviceaccount.com, devtools-...@chromium.org, v8-re...@googlegroups.com
Attention needed from Yang Guo
Benedikt Meurer voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Yang Guo
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yang Guo (Gerrit)
Oct 21, 2026, 10:29:15 AM (yesterday) Oct 21
to Benedikt Meurer, v8-s...@luci-project-accounts.iam.gserviceaccount.com, devtools-...@chromium.org, v8-re...@googlegroups.com
Attention needed from Benedikt Meurer
Yang Guo added 1 comment![]( "Open in Gerrit")
File src/inspector/value-mirror.cc
Line 1666, Patchset 1 (Latest):
return false;Yang Guo . unresolved
Should we return `tryCatch.HasTerminated()` instead of `false` here? If the `Response` check terminates execution, returning `false` causes `ValueMirror::getProperties` to call `object->Get(context, v8Name)` and clear the pending termination exception.
Related details
Attention is currently required from:
- Benedikt Meurer
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Benedikt Meurer (Gerrit)
Oct 21, 2026, 10:39:26 AM (yesterday) Oct 21
to Yang Guo, v8-s...@luci-project-accounts.iam.gserviceaccount.com, devtools-...@chromium.org, v8-re...@googlegroups.com
Benedikt Meurer voted Auto-Submit+1![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yang Guo (Gerrit)
Oct 21, 2026, 11:15:17 AM (yesterday) Oct 21
to Benedikt Meurer, v8-s...@luci-project-accounts.iam.gserviceaccount.com, devtools-...@chromium.org, v8-re...@googlegroups.com
Attention needed from Benedikt Meurer
Yang Guo voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Benedikt Meurer
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yang Guo (Gerrit)
Oct 21, 2026, 11:15:22 AM (yesterday) Oct 21
to Benedikt Meurer, v8-s...@luci-project-accounts.iam.gserviceaccount.com, devtools-...@chromium.org, v8-re...@googlegroups.com
Attention needed from Benedikt Meurer
Yang Guo voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Benedikt Meurer
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yang Guo (Gerrit)
Oct 21, 2026, 11:16:29 AM (yesterday) Oct 21
to Benedikt Meurer, v8-s...@luci-project-accounts.iam.gserviceaccount.com, devtools-...@chromium.org, v8-re...@googlegroups.com
Attention needed from Benedikt Meurer
Yang Guo added 1 comment![]( "Open in Gerrit")
File src/inspector/value-mirror.cc
Should we return `tryCatch.HasTerminated()` instead of `false` here? If the `Response` check terminates execution, returning `false` causes `ValueMirror::getProperties` to call `object->Get(context, v8Name)` and clear the pending termination exception.
Yang Guo
Done in PS 2.
Related details
Attention is currently required from:
- Benedikt Meurer
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yang Guo (Gerrit)
Oct 21, 2026, 11:16:33 AM (yesterday) Oct 21
to Benedikt Meurer, v8-s...@luci-project-accounts.iam.gserviceaccount.com, devtools-...@chromium.org, v8-re...@googlegroups.com
Attention needed from Benedikt Meurer
Yang Guo voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Benedikt Meurer
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Benedikt Meurer (Gerrit)
2:06 AM (12 hours ago) 2:06 AM
to Yang Guo, v8-s...@luci-project-accounts.iam.gserviceaccount.com, devtools-...@chromium.org, v8-re...@googlegroups.com
Attention needed from Yang Guo
Benedikt Meurer voted Commit-Queue+2 on change 8619194![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Yang Guo
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
v8-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
4:05 AM (10 hours ago) 4:05 AM
to Benedikt Meurer, Yang Guo, devtools-...@chromium.org, v8-re...@googlegroups.com
v8-s...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[inspector] Propagate termination in doesAttributeHaveObservableSideEffectOnGet
If the Request lookup or instanceof check in doesAttributeHaveObservableSideEffectOnGet terminates execution (via Runtime.terminateExecution or a failed side-effect check), return true immediately instead of calling TryCatch::Reset and proceeding to the Response check, which would clear the pending termination exception.
Fixed: 575876559
Change-Id: I84d7109f698047a8f552d5f888864c82c06826dc
Reviewed-by: Yang Guo <yan...@chromium.org>
Auto-Submit: Benedikt Meurer <bme...@chromium.org>
Commit-Queue: Benedikt Meurer <bme...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#111045}
Files:
- M src/inspector/value-mirror.cc
- A test/inspector/regress/regress-575876559-expected.txt
- A test/inspector/regress/regress-575876559.js
Change size: M
Delta: 3 files changed, 94 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Yang Guo
Review-Enforcement: Code-Review+1 by Yang Guo
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages