[Spanify] Spanifier rewriter adaptation [chromium/src : main]

0 views
Skip to first unread message

Daniel Angulo (Gerrit)

unread,
Feb 27, 2026, 12:45:59 PM (4 days ago) Feb 27
to Stephen Nusko, Arthur Sonzogni, Hans Wennborg, AyeAye, devtools...@chromium.org, chrome-intelligence-te...@google.com, chrome-intell...@chromium.org
Attention needed from Arthur Sonzogni and Stephen Nusko

Daniel Angulo added 1 comment

File tools/clang/spanify/rewrite-multiple-platforms.sh
Line 280, Patchset 29: time ninja -C $OUT_DIR -t targets all \
Stephen Nusko . resolved

if we replace all with

```
BUILD_TARGETS=all
if (partition_alloc)
  BUILD_TARGETS =  base/allocator/partition_allocator:partition_alloc
```

could we reuse the build command? I'm not sure what the grep is doing but I think it is removing a couple compile targets but that shouldn't hurt PA and then we keep all our logic about getconf ARG_MAX etc.

Daniel Angulo

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Arthur Sonzogni
  • Stephen Nusko
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib21cd762662a2f6a7115fb9caeb87a0ecae1fa55
Gerrit-Change-Number: 7552504
Gerrit-PatchSet: 41
Gerrit-Owner: Daniel Angulo <angd...@google.com>
Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Reviewer: Stephen Nusko <nus...@chromium.org>
Gerrit-CC: Hans Wennborg <ha...@chromium.org>
Gerrit-Attention: Stephen Nusko <nus...@chromium.org>
Gerrit-Attention: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Comment-Date: Fri, 27 Feb 2026 17:45:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Stephen Nusko <nus...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Stephen Nusko (Gerrit)

unread,
Mar 1, 2026, 8:56:19 PM (2 days ago) Mar 1
to Daniel Angulo, Arthur Sonzogni, Hans Wennborg, AyeAye, devtools...@chromium.org, chrome-intelligence-te...@google.com, chrome-intell...@chromium.org
Attention needed from Arthur Sonzogni and Daniel Angulo

Stephen Nusko added 1 comment

File tools/clang/spanify/rewrite-multiple-platforms.sh
Line 277, Patchset 45 (Latest): if [ "$TOOL_ARG" = "--project=partition_alloc" ];
Stephen Nusko . unresolved

Can we just move BUILD_TARGETS to the top and set it at the same time we set TOOL_ARG?

Open in Gerrit

Related details

Attention is currently required from:
  • Arthur Sonzogni
  • Daniel Angulo
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib21cd762662a2f6a7115fb9caeb87a0ecae1fa55
Gerrit-Change-Number: 7552504
Gerrit-PatchSet: 45
Gerrit-Owner: Daniel Angulo <angd...@google.com>
Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Reviewer: Stephen Nusko <nus...@chromium.org>
Gerrit-CC: Hans Wennborg <ha...@chromium.org>
Gerrit-Attention: Daniel Angulo <angd...@google.com>
Gerrit-Attention: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Comment-Date: Mon, 02 Mar 2026 01:56:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Arthur Sonzogni (Gerrit)

unread,
Mar 2, 2026, 10:41:13 AM (yesterday) Mar 2
to Daniel Angulo, Stephen Nusko, Hans Wennborg, AyeAye, devtools...@chromium.org, chrome-intelligence-te...@google.com, chrome-intell...@chromium.org
Attention needed from Daniel Angulo

Arthur Sonzogni voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Angulo
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib21cd762662a2f6a7115fb9caeb87a0ecae1fa55
    Gerrit-Change-Number: 7552504
    Gerrit-PatchSet: 45
    Gerrit-Owner: Daniel Angulo <angd...@google.com>
    Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
    Gerrit-Reviewer: Stephen Nusko <nus...@chromium.org>
    Gerrit-CC: Hans Wennborg <ha...@chromium.org>
    Gerrit-Attention: Daniel Angulo <angd...@google.com>
    Gerrit-Comment-Date: Mon, 02 Mar 2026 15:41:00 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Daniel Angulo (Gerrit)

    unread,
    11:33 AM (3 hours ago) 11:33 AM
    to Arthur Sonzogni, Stephen Nusko, Hans Wennborg, AyeAye, devtools...@chromium.org, chrome-intelligence-te...@google.com, chrome-intell...@chromium.org
    Attention needed from Arthur Sonzogni and Stephen Nusko

    Daniel Angulo added 1 comment

    File tools/clang/spanify/rewrite-multiple-platforms.sh
    Line 277, Patchset 45: if [ "$TOOL_ARG" = "--project=partition_alloc" ];
    Stephen Nusko . resolved

    Can we just move BUILD_TARGETS to the top and set it at the same time we set TOOL_ARG?

    Daniel Angulo

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Arthur Sonzogni
    • Stephen Nusko
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ib21cd762662a2f6a7115fb9caeb87a0ecae1fa55
      Gerrit-Change-Number: 7552504
      Gerrit-PatchSet: 48
      Gerrit-Owner: Daniel Angulo <angd...@google.com>
      Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
      Gerrit-Reviewer: Stephen Nusko <nus...@chromium.org>
      Gerrit-CC: Hans Wennborg <ha...@chromium.org>
      Gerrit-Attention: Stephen Nusko <nus...@chromium.org>
      Gerrit-Attention: Arthur Sonzogni <arthurs...@chromium.org>
      Gerrit-Comment-Date: Tue, 03 Mar 2026 16:33:34 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Stephen Nusko <nus...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages