Use media adorner declaratively [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Alex Rudenko (Gerrit)
Nov 28, 2025, 7:42:34 AM (3 days ago) Nov 28
to Eric Leese, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Eric Leese
Alex Rudenko added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Alex Rudenko . resolved
PTAL (it is currently quite verbose but it will be better once I move all adorners and be able to clean up adorner configs and duplicate handlers). Please check if anything looks like it could have regressed the media adorner functionality (I tested manually)
Related details
Attention is currently required from:
- Eric Leese
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eric Leese (Gerrit)
Nov 28, 2025, 7:58:27 AM (3 days ago) Nov 28
to Alex Rudenko, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Alex Rudenko
Eric Leese voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Alex Rudenko
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
Nov 28, 2025, 8:45:39 AM (3 days ago) Nov 28
to Eric Leese, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Alex Rudenko voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
2:14 AM (11 hours ago) 2:14 AM
to Eric Leese, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Alex Rudenko voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devtools-frontend LUCI CQ (Gerrit)
3:06 AM (10 hours ago) 3:06 AM
to Alex Rudenko, Eric Leese, devtools-rev...@chromium.org
Devtools-frontend LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
4 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: front_end/panels/elements/ElementsTreeElement.ts
Insertions: 12, Deletions: 18.
@@ -404,7 +404,13 @@
input.onAdornerRemoved(adorner);
}
adorner = el as Adorners.Adorner.Adorner;
+
if (adorner) {
+ if (ElementsPanel.instance().isAdornerEnabled(adorner.name)) {
+ adorner.show();
+ } else {
+ adorner.hide();
+ }
input.onAdornerAdded(adorner);
}
});
@@ -727,25 +733,13 @@
{
containerAdornerActive: this.#containerAdornerActive,
adorners: !this.isClosingTag() ? this.#adorners : undefined,
- showAdAdorner:
- ElementsPanel.instance().isAdornerEnabled(ElementsComponents.AdornerManager.RegisteredAdorners.AD) &&
- this.nodeInternal.isAdFrameNode(),
- showContainerAdorner: ElementsPanel.instance().isAdornerEnabled(
- ElementsComponents.AdornerManager.RegisteredAdorners.CONTAINER) &&
- Boolean(this.#layout?.isContainer) && !this.isClosingTag(),
- showFlexAdorner:
- ElementsPanel.instance().isAdornerEnabled(ElementsComponents.AdornerManager.RegisteredAdorners.FLEX) &&
- Boolean(this.#layout?.isFlex) && !this.isClosingTag(),
+ showAdAdorner: this.nodeInternal.isAdFrameNode(),
+ showContainerAdorner: Boolean(this.#layout?.isContainer) && !this.isClosingTag(),
+ showFlexAdorner: Boolean(this.#layout?.isFlex) && !this.isClosingTag(),
flexAdornerActive: this.#flexAdornerActive,
- showGridAdorner:
- ElementsPanel.instance().isAdornerEnabled(ElementsComponents.AdornerManager.RegisteredAdorners.GRID) &&
- Boolean(this.#layout?.isGrid) && !this.isClosingTag(),
- showGridLanesAdorner: ElementsPanel.instance().isAdornerEnabled(
- ElementsComponents.AdornerManager.RegisteredAdorners.GRID_LANES) &&
- Boolean(this.#layout?.isGridLanes) && !this.isClosingTag(),
- showMediaAdorner:
- ElementsPanel.instance().isAdornerEnabled(ElementsComponents.AdornerManager.RegisteredAdorners.MEDIA) &&
- this.node().isMediaNode() && !this.isClosingTag(),
+ showGridAdorner: Boolean(this.#layout?.isGrid) && !this.isClosingTag(),
+ showGridLanesAdorner: Boolean(this.#layout?.isGridLanes) && !this.isClosingTag(),
+ showMediaAdorner: this.node().isMediaNode() && !this.isClosingTag(),
gridAdornerActive: this.#gridAdornerActive,
isSubgrid: Boolean(this.#layout?.isSubgrid),
nodeInfo: this.#nodeInfo,
```
Change information
Commit message:
Use media adorner declaratively
Fixes the issue with show/hide when settings change.
Bug: 407751414
Change-Id: I4e324367c0b2f1d0a36055b238fb79f6fd0e4bd2
Reviewed-by: Eric Leese <le...@chromium.org>
Commit-Queue: Alex Rudenko <alexr...@chromium.org>
Files:
- M front_end/panels/elements/ElementsTreeElement.ts
Change size: M
Delta: 1 file changed, 50 insertions(+), 75 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Eric Leese
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages