RPP: Ensure hasFakeConnection for rehydrated_devtools_app [devtools/devtools-frontend : main]

0 views
Skip to first unread message

Paul Irish (Gerrit)

unread,
Sep 23, 2025, 5:43:41 PM (2 days ago) Sep 23
to Connor Clark, devtools-rev...@chromium.org
Attention needed from Connor Clark

Paul Irish voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Connor Clark
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I932802acea7fda260b6246baf5828f09d23845e7
Gerrit-Change-Number: 6976658
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Irish <paul...@chromium.org>
Gerrit-Reviewer: Connor Clark <cja...@chromium.org>
Gerrit-Reviewer: Paul Irish <paul...@chromium.org>
Gerrit-Attention: Connor Clark <cja...@chromium.org>
Gerrit-Comment-Date: Tue, 23 Sep 2025 21:43:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Connor Clark (Gerrit)

unread,
Sep 23, 2025, 6:18:07 PM (2 days ago) Sep 23
to Paul Irish, Vidal Diazleal, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Paul Irish and Vidal Diazleal

Connor Clark voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Paul Irish
  • Vidal Diazleal
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I932802acea7fda260b6246baf5828f09d23845e7
Gerrit-Change-Number: 6976658
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Irish <paul...@chromium.org>
Gerrit-Reviewer: Connor Clark <cja...@chromium.org>
Gerrit-Reviewer: Paul Irish <paul...@chromium.org>
Gerrit-Reviewer: Vidal Diazleal <vido...@microsoft.com>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Paul Irish <paul...@chromium.org>
Gerrit-Attention: Vidal Diazleal <vido...@microsoft.com>
Gerrit-Comment-Date: Tue, 23 Sep 2025 22:18:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Devtools-frontend LUCI CQ (Gerrit)

unread,
Sep 23, 2025, 6:42:15 PM (2 days ago) Sep 23
to Paul Irish, Connor Clark, Vidal Diazleal, devtools-rev...@chromium.org

Devtools-frontend LUCI CQ submitted the change

Change information

Commit message:
RPP: Ensure hasFakeConnection for rehydrated_devtools_app
Bug: 432043754
Change-Id: I932802acea7fda260b6246baf5828f09d23845e7
Commit-Queue: Paul Irish <paul...@chromium.org>
Commit-Queue: Connor Clark <cja...@chromium.org>
Auto-Submit: Paul Irish <paul...@chromium.org>
Reviewed-by: Connor Clark <cja...@chromium.org>
Files:
  • M front_end/core/sdk/TargetManager.ts
Change size: XS
Delta: 1 file changed, 4 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Connor Clark
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I932802acea7fda260b6246baf5828f09d23845e7
Gerrit-Change-Number: 6976658
Gerrit-PatchSet: 3
Gerrit-Owner: Paul Irish <paul...@chromium.org>
Gerrit-Reviewer: Connor Clark <cja...@chromium.org>
Gerrit-Reviewer: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages