Select one CPU profile stream per thread by source [devtools/devtools-frontend : main]

2 views

Skip to first unread message

Issack John (Gerrit)

unread,

Nov 4, 2025, 6:49:50 PM (17 hours ago) Nov 4

to Jack Franklin, Yang Guo, Michael Lippautz, devtools-rev...@chromium.org

Attention needed from Jack Franklin

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

Jack Franklin

Submit Requirements:

Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Jack Franklin (Gerrit)

unread,

5:21 AM (7 hours ago) 5:21 AM

to Issack John, Yang Guo, Michael Lippautz, devtools-rev...@chromium.org

Attention needed from Issack John, Michael Lippautz and Yang Guo

Jack Franklin voted and added 2 comments

Votes added by Jack Franklin

Code-Review

2 comments

Patchset-level comments

File-level comment, Patchset 14 (Latest):

Jack Franklin . resolved

lgtm with one nit + there's some trailing whitespace to tidy up in the comment.s Thanks!

File front_end/models/trace/handlers/SamplesHandler.ts

Line 28, Patchset 14 (Latest): * Profile sources and their typical scenarios:

Jack Franklin . unresolved

checking my understanding: internal is what is used if the user uses "record" in the DevTools UI, is that correct?

It might be worth explicitly stating, only because sometimes in the past people use "Inspector" to refer to DevTools so the term is slightly overloaded.

Open in Gerrit

Related details

Attention is currently required from:

Issack John
Michael Lippautz
Yang Guo

Submit Requirements:

Code-Owners

Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages