Revert "Forward declare mojo::InterfaceEndpointClient where possible" [chromium/src : main]

[rubber-stamper@appspot.gserviceaccount.com (Gerrit)]

Attention needed from Daniel Cheng and Takuto Ikuta

rubber-...@appspot.gserviceaccount.com voted Bot-Commit+1

Bot-Commit

+1

Open in Gerrit

Related details

Attention is currently required from:

• Daniel Cheng
• Takuto Ikuta

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I9045f7817fb537ab465d4bcc6dc638ab2ef128ff

Gerrit-Change-Number: 8627330

Gerrit-PatchSet: 1

Gerrit-Owner: Anna Sato <anna...@chromium.org>

Gerrit-Reviewer: Anna Sato <anna...@chromium.org>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>

Gerrit-Reviewer: Takuto Ikuta <tik...@chromium.org>

Gerrit-Reviewer: rubber-...@appspot.gserviceaccount.com <rubber-...@appspot.gserviceaccount.com>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>

Gerrit-CC: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-Attention: Takuto Ikuta <tik...@chromium.org>

Gerrit-Attention: Daniel Cheng <dch...@chromium.org>

Gerrit-Comment-Date: Thu, 22 Oct 2026 06:14:10 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Anna Sato (Gerrit)]

Attention needed from Daniel Cheng and Takuto Ikuta

Anna Sato voted Commit-Queue+2

Commit-Queue

+2

Gerrit-Comment-Date: Thu, 22 Oct 2026 06:14:45 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Chromium LUCI CQ (Gerrit)]

Chromium LUCI CQ submitted the change

Change information

Commit message:

Revert "Forward declare mojo::InterfaceEndpointClient where possible"

This reverts commit 605ea41354746b7128e0d27644c81c3863025419.

Reason for revert:
Breaks the compile on linux-cfm-rel and closed the tree:
chrome/browser/ash/chromebox_for_meetings/artemis/local_data_source.h:88:
error: no type named 'RepeatingTimer' in namespace 'base'
https://ci.chromium.org/b/8667265121394171217

Failure Link: https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cfm-rel/92653/overview

Original change's description:
> Forward declare mojo::InterfaceEndpointClient where possible
>
> Forward declare mojo::InterfaceEndpointClient in AssociatedReceiver,
> AssociatedInterfacePtrState, BindingState, and InterfacePtrState
> instead of including interface_endpoint_client.h directly in these
> widely-included headers. This reduces transitive header inclusion
> across ~6,280 translation units and prepares for migrating
> InterfaceEndpointClient's maps to `absl::flat_hash_map` without
> introducing a 2.4GB regression on the compile-size builder.
>
> To avoid requiring the complete definition of InterfaceEndpointClient
> in these headers:
> - Move method definitions that dereference `endpoint_client_ on
>   `AssociatedInterfacePtrStateBase`, `AssociatedReceiverBase`, and
>   `BindingStateBase` to the .cc file.
> - Extract `endpoint_client_` handling from `AssociatedReceiver<T>`,
>   `BindingState<T>`, and `InterfacePtrState<T>` and move it to helper
>   methods defined in the .cc file on their corresponding base classes.
> - Remove `AssociatedInterfacePtrStateBase`'s unused
>   `ForwardMessageWithResponder()` method.
> - Rename `BindImpl()` and `BindInternal()` to use a consistent naming
>   and delegation style.
> - Change `AssociatedInterfacePtrStateBase::Bind()` and
>   `InterfacePtrStateBase::InitializeEndpointClient()` to return
>   `MessageReceiverWithResponder*` so the templated classes no longer
>   need to implicitly upcast when initializing `proxy_`, which would
>   require the full definition of `InterfaceEndpointClient`.
>
> Also clean up unused #includes and forward declarations in these
> headers, and add missing #includes to files that previously relied on
> transitive includes through interface_endpoint_client.h.
>
> Bug: 433462519
> Change-Id: I462b727137eae9bf00399712daccf560cab3a572
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8617201
> Reviewed-by: Takuto Ikuta <tik...@chromium.org>
> Owners-Override: Daniel Cheng <dch...@chromium.org>
> Commit-Queue: Daniel Cheng <dch...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1724461}

Bug: 433462519

No-Presubmit: true

No-Tree-Checks: true

No-Try: true

Change-Id: I9045f7817fb537ab465d4bcc6dc638ab2ef128ff

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8627330

Bot-Commit: rubber-...@appspot.gserviceaccount.com <rubber-...@appspot.gserviceaccount.com>

Owners-Override: Anna Sato <anna...@chromium.org>

Commit-Queue: Anna Sato <anna...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1724467}

Files:

• M android_webview/browser/gfx/viz_compositor_thread_runner_webview.cc
• M ash/webui/eche_app_ui/eche_connection_status_handler.h
• M chrome/browser/ash/arc/nearby_share/share_info_file_handler.h
• M chrome/browser/ash/policy/dlp/files_policy_notification_manager.h
• M chrome/browser/data_sharing/desktop/data_sharing_sdk_delegate_desktop.h
• M chrome/browser/devtools/device/android_device_manager.cc
• M chrome/browser/notifications/mac/notification_dispatcher_mojo.h
• M chrome/browser/signin/bound_session_credentials/bound_session_refresh_cookie_fetcher_impl.h
• M chrome/browser/ui/webui/ash/login/online_login_utils.cc
• M chrome/browser/ui/webui/ash/login/online_login_utils.h
• M chrome/browser/ui/webui/skills/skills_page_handler.h
• M chrome/browser/ui/webui/tab_search/tab_search_page_handler.h
• M chrome/renderer/accessibility/read_anything/read_anything_app_controller.h
• M chrome/services/file_util/safe_archive_analyzer.h
• M chrome/services/speech/soda_speech_recognizer_impl.h
• M chromecast/media/audio/audio_output_service/output_stream_connection.h
• M chromeos/ash/services/device_sync/public/cpp/device_sync_client_impl_unittest.cc
• M chromeos/ash/services/device_sync/stub_device_sync.cc
• M chromeos/ash/services/secure_channel/public/cpp/client/connection_manager_impl.cc
• M components/cast_streaming/renderer/control/playback_command_forwarding_renderer.h
• M components/global_media_controls/public/media_session_item_producer.h
• M components/global_media_controls/public/media_session_notification_item.h
• M components/mirroring/service/openscreen_session_host.h
• M components/optimization_guide/content/browser/page_content_proto_provider.cc
• M components/optimization_guide/content/browser/page_content_proto_provider_browsertest.cc
• M components/viz/service/main/viz_compositor_thread_runner_impl.cc
• M content/browser/loader/navigation_url_loader_impl.h
• M content/browser/network_service_instance_impl.cc
• M content/browser/preloading/prefetch/prefetch_canary_checker.h
• M mojo/public/cpp/bindings/associated_receiver.h
• M mojo/public/cpp/bindings/lib/associated_interface_ptr_state.cc
• M mojo/public/cpp/bindings/lib/associated_interface_ptr_state.h
• M mojo/public/cpp/bindings/lib/associated_receiver.cc
• M mojo/public/cpp/bindings/lib/binding_state.cc
• M mojo/public/cpp/bindings/lib/binding_state.h
• M mojo/public/cpp/bindings/lib/interface_ptr_state.cc
• M mojo/public/cpp/bindings/lib/interface_ptr_state.h
• M mojo/public/cpp/bindings/tests/sync_method_unittest.cc
• M third_party/blink/renderer/platform/video_capture/video_capture_impl.h
• M ui/ozone/platform/wayland/test/wayland_test.cc

Change size: L

Delta: 40 files changed, 167 insertions(+), 307 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: Bot-Commit+1 by rubber-...@appspot.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I9045f7817fb537ab465d4bcc6dc638ab2ef128ff

Gerrit-Change-Number: 8627330

Gerrit-PatchSet: 2

[hammin htet20000 (Gerrit)]

hammin htet20000 added 1 comment on change 8627330

Patchset-level comments

File-level comment, Patchset 2 (Latest):

hammin htet20000 . resolved

"

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I9045f7817fb537ab465d4bcc6dc638ab2ef128ff

Gerrit-Change-Number: 8627330

Gerrit-PatchSet: 2

Gerrit-Owner: Anna Sato <anna...@chromium.org>

Gerrit-Reviewer: Anna Sato <anna...@chromium.org>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>

Gerrit-Reviewer: Takuto Ikuta <tik...@chromium.org>

Gerrit-Reviewer: rubber-...@appspot.gserviceaccount.com <rubber-...@appspot.gserviceaccount.com>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>

Gerrit-CC: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: hammin htet20000 <hanminh...@gmail.com>

Gerrit-Comment-Date: Thu, 22 Oct 2026 17:15:48 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No