Move saveNodeToTempVariable to DOMNode [devtools/devtools-frontend : main]

0 views
Skip to first unread message

Simon Zünd (Gerrit)

unread,
12:09 AM (10 hours ago) 12:09 AM
to Alex Rudenko, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org
Attention needed from Alex Rudenko

Simon Zünd voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alex Rudenko
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: Iecf60bda47c9aadbe502fd914f9b68ac663eafd4
Gerrit-Change-Number: 8265456
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Simon Zünd <szu...@chromium.org>
Gerrit-Attention: Alex Rudenko <alexr...@chromium.org>
Gerrit-Comment-Date: Wed, 19 Aug 2026 04:09:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Alex Rudenko (Gerrit)

unread,
1:42 AM (8 hours ago) 1:42 AM
to Simon Zünd, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org

Alex Rudenko voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: Iecf60bda47c9aadbe502fd914f9b68ac663eafd4
Gerrit-Change-Number: 8265456
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Simon Zünd <szu...@chromium.org>
Gerrit-Comment-Date: Wed, 19 Aug 2026 05:42:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Alex Rudenko (Gerrit)

unread,
2:16 AM (7 hours ago) 2:16 AM
to Simon Zünd, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org

Alex Rudenko voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: Iecf60bda47c9aadbe502fd914f9b68ac663eafd4
Gerrit-Change-Number: 8265456
Gerrit-PatchSet: 3
Gerrit-Comment-Date: Wed, 19 Aug 2026 06:16:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Alex Rudenko (Gerrit)

unread,
3:05 AM (7 hours ago) 3:05 AM
to Simon Zünd, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org
Gerrit-Comment-Date: Wed, 19 Aug 2026 07:05:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Alex Rudenko (Gerrit)

unread,
3:43 AM (6 hours ago) 3:43 AM
to Simon Zünd, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org

Alex Rudenko voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: Iecf60bda47c9aadbe502fd914f9b68ac663eafd4
Gerrit-Change-Number: 8265456
Gerrit-PatchSet: 4
Gerrit-Comment-Date: Wed, 19 Aug 2026 07:43:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Alex Rudenko (Gerrit)

unread,
5:04 AM (5 hours ago) 5:04 AM
to Simon Zünd, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org

Alex Rudenko voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: Iecf60bda47c9aadbe502fd914f9b68ac663eafd4
Gerrit-Change-Number: 8265456
Gerrit-PatchSet: 5
Gerrit-Comment-Date: Wed, 19 Aug 2026 09:04:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,
5:33 AM (4 hours ago) 5:33 AM
to Alex Rudenko, Simon Zünd, devtools-rev...@chromium.org

devtools-fro...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Unreviewed changes

2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:
Move saveNodeToTempVariable to DOMNode
Bug: 407751692
Change-Id: Iecf60bda47c9aadbe502fd914f9b68ac663eafd4
Commit-Queue: Alex Rudenko <alexr...@chromium.org>
Reviewed-by: Simon Zünd <szu...@chromium.org>
Files:
  • M front_end/core/sdk/DOMModel.test.api.ts
  • M front_end/core/sdk/DOMModel.ts
  • M front_end/panels/elements/DOMTreeContextMenu.ts
  • M front_end/panels/elements/ElementsTreeOutline.ts
Change size: M
Delta: 4 files changed, 49 insertions(+), 22 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Simon Zünd
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: Iecf60bda47c9aadbe502fd914f9b68ac663eafd4
Gerrit-Change-Number: 8265456
Gerrit-PatchSet: 6
Gerrit-Owner: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Simon Zünd <szu...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages