Use HttpRequestHeadersUpdateParams in mojom::URLLoader::FollowRedirect [chromium/src : main]
1 view
Skip to first unread message
Hiroshige Hayashizaki (Gerrit)
May 13, 2026, 11:21:37 PMMay 13
to Kenichi Ishibashi, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, Hiroki Nakagawa, prerendering-reviews, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Kenichi Ishibashi
Hiroshige Hayashizaki added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 9:
Hiroshige Hayashizaki . unresolved
WDYT?
A specific alternative might be to define `FollowRedirectParams` that includes `new_url` + `HttpRequestHeadersUpdateParams`, while I don't have any specific reason to (or not to) do so.
(bot failures are due to recent addition of `FollowRedirect` overrides; I'll rebase/rerun later).
Related details
Attention is currently required from:
- Kenichi Ishibashi
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kenichi Ishibashi (Gerrit)
May 14, 2026, 12:19:12 AMMay 14
to Hiroshige Hayashizaki, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, Hiroki Nakagawa, prerendering-reviews, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Hiroshige Hayashizaki
Kenichi Ishibashi added 3 comments![]( "Open in Gerrit")
File android_webview/browser/network_service/aw_proxying_url_loader_factory.cc
Line 169, Patchset 11 (Latest):
network::HttpRequestHeadersUpdateParams headers_update_params,Kenichi Ishibashi . unresolved
Now we pass by value instead of reference. Does that mean we add extra copies?
File services/network/public/cpp/http_request_headers_mojom_traits.cc
Line 52, Patchset 11 (Latest):
bool StructTraits<network::mojom::HttpRequestHeadersUpdateParamsDataView,Kenichi Ishibashi . unresolved
Maybe nice to add unitteest.
File services/network/public/mojom/http_request_headers.mojom
Line 24, Patchset 11 (Latest):
struct HttpRequestHeadersUpdateParams {Kenichi Ishibashi . unresolved
```
// Typemapped to `network::HttpRequestHeadersUpdateParams`.
```
Also, consider using `IFFT` so that we don't forget update them each other?
Related details
Attention is currently required from:
- Hiroshige Hayashizaki
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hiroshige Hayashizaki (Gerrit)
May 14, 2026, 5:59:11 PMMay 14
to Kenichi Ishibashi, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, Hiroki Nakagawa, prerendering-reviews, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Kenichi Ishibashi
Hiroshige Hayashizaki added 1 comment![]( "Open in Gerrit")
File android_webview/browser/network_service/aw_proxying_url_loader_factory.cc
Line 169, Patchset 11:
network::HttpRequestHeadersUpdateParams headers_update_params,Kenichi Ishibashi . unresolved
Now we pass by value instead of reference. Does that mean we add extra copies?
Hiroshige Hayashizaki
No, `HttpRequestHeadersUpdateParams` is passed by move, not copy.
Related details
Attention is currently required from:
- Kenichi Ishibashi
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kenichi Ishibashi (Gerrit)
May 14, 2026, 10:20:14 PMMay 14
to Hiroshige Hayashizaki, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, Hiroki Nakagawa, prerendering-reviews, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Hiroshige Hayashizaki
Kenichi Ishibashi added 1 comment![]( "Open in Gerrit")
File android_webview/browser/network_service/aw_proxying_url_loader_factory.cc
Line 169, Patchset 11:
network::HttpRequestHeadersUpdateParams headers_update_params,Kenichi Ishibashi . resolved
Hiroshige HayashizakiNow we pass by value instead of reference. Does that mean we add extra copies?
No, `HttpRequestHeadersUpdateParams` is passed by move, not copy.
Attention is currently required from:
- Hiroshige Hayashizaki
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hiroshige Hayashizaki (Gerrit)
May 17, 2026, 9:37:53 PM (12 days ago) May 17
to Zijie He, Kenichi Ishibashi, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, Hiroki Nakagawa, prerendering-reviews, mac-r...@chromium.org, fuchsia...@chromium.org, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Kenichi Ishibashi
Hiroshige Hayashizaki added 2 comments![]( "Open in Gerrit")
File services/network/public/cpp/http_request_headers_mojom_traits.cc
Line 52, Patchset 11:
bool StructTraits<network::mojom::HttpRequestHeadersUpdateParamsDataView,Kenichi Ishibashi . resolved
Maybe nice to add unitteest.
Hiroshige Hayashizaki
Created: https://crrev.com/c/7855487
File services/network/public/mojom/http_request_headers.mojom
```
// Typemapped to `network::HttpRequestHeadersUpdateParams`.
```Also, consider using `IFFT` so that we don't forget update them each other?
Hiroshige Hayashizaki
```
// Typemapped to `network::HttpRequestHeadersUpdateParams`.
```
Done.
Also, consider using `IFFT` so that we don't forget update them each other?
Attention is currently required from:
- Kenichi Ishibashi
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kenichi Ishibashi (Gerrit)
May 18, 2026, 2:51:45 AM (12 days ago) May 18
to Hiroshige Hayashizaki, Zijie He, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, Hiroki Nakagawa, prerendering-reviews, mac-r...@chromium.org, fuchsia...@chromium.org, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Hiroshige Hayashizaki
Kenichi Ishibashi added 1 comment![]( "Open in Gerrit")
File services/network/public/cpp/http_request_headers_mojom_traits.cc
Line 52, Patchset 11:
bool StructTraits<network::mojom::HttpRequestHeadersUpdateParamsDataView,Kenichi Ishibashi . resolved
Hiroshige HayashizakiMaybe nice to add unitteest.
Created: https://crrev.com/c/7855487
Kenichi Ishibashi
It would be nice to submit the test together with the implementation, ideally factoring out in two CLs: 1. impl + test, 2. other stuff in this CL.
I don't meant to block this CL though.
Related details
Attention is currently required from:
- Hiroshige Hayashizaki
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hiroshige Hayashizaki (Gerrit)
May 19, 2026, 6:28:32 PM (10 days ago) May 19
to Zijie He, Kenichi Ishibashi, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, Hiroki Nakagawa, prerendering-reviews, mac-r...@chromium.org, fuchsia...@chromium.org, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Kenichi Ishibashi
Hiroshige Hayashizaki added 1 comment![]( "Open in Gerrit")
File services/network/public/cpp/http_request_headers_mojom_traits.cc
Line 52, Patchset 11:
bool StructTraits<network::mojom::HttpRequestHeadersUpdateParamsDataView,Kenichi Ishibashi . unresolved
Hiroshige HayashizakiMaybe nice to add unitteest.
Kenichi IshibashiCreated: https://crrev.com/c/7855487
It would be nice to submit the test together with the implementation, ideally factoring out in two CLs: 1. impl + test, 2. other stuff in this CL.
I don't meant to block this CL though.
Hiroshige Hayashizaki
Merged https://crrev.com/c/7855487.
What do you mean by "other stuff in this CL"?
Everything related to the `network::mojom::URLLoader::FollowRedirect` change should be committed at once and can't be split.
The other parts of
- Defines `network.mojom.HttpRequestHeadersUpdateParams` mojo struct.
- `services/network/public/mojom/http_request_headers.mojom`
- Maps it to `network::HttpRequestHeadersUpdateParams`.
- `services/network/public/mojom/BUILD.gn`
- `services/network/public/cpp/http_request_headers_mojom_traits.*`
can be split into a preparation CL, but is this what you mean?
Related details
Attention is currently required from:
- Kenichi Ishibashi
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kenichi Ishibashi (Gerrit)
May 20, 2026, 10:37:02 PM (9 days ago) May 20
to Hiroshige Hayashizaki, Zijie He, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, Hiroki Nakagawa, prerendering-reviews, mac-r...@chromium.org, fuchsia...@chromium.org, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Hiroshige Hayashizaki
Kenichi Ishibashi voted and added 2 comments![]( "Open in Gerrit")
Votes added by Kenichi Ishibashi
| Code-Review | +1 |
2 comments
Patchset-level comments
File services/network/public/cpp/http_request_headers_mojom_traits.cc
Line 52, Patchset 11:
bool StructTraits<network::mojom::HttpRequestHeadersUpdateParamsDataView,Kenichi Ishibashi . resolved
Hiroshige HayashizakiMaybe nice to add unitteest.
Kenichi IshibashiCreated: https://crrev.com/c/7855487
Hiroshige HayashizakiIt would be nice to submit the test together with the implementation, ideally factoring out in two CLs: 1. impl + test, 2. other stuff in this CL.
I don't meant to block this CL though.
Merged https://crrev.com/c/7855487.
What do you mean by "other stuff in this CL"?
Everything related to the `network::mojom::URLLoader::FollowRedirect` change should be committed at once and can't be split.
The other parts of
- Defines `network.mojom.HttpRequestHeadersUpdateParams` mojo struct.
- `services/network/public/mojom/http_request_headers.mojom`
- Maps it to `network::HttpRequestHeadersUpdateParams`.
- `services/network/public/mojom/BUILD.gn`
- `services/network/public/cpp/http_request_headers_mojom_traits.*`can be split into a preparation CL, but is this what you mean?
Kenichi Ishibashi
Yeah, that's what I meant:
- 1st CL: Definitions + tests
- 2nd CL: Use it in FollowRedirect.
But I understand that splitting this into two CLs is bothersome, so lgtm.
Related details
Attention is currently required from:
- Hiroshige Hayashizaki
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hiroshige Hayashizaki (Gerrit)
May 26, 2026, 8:21:44 PM (3 days ago) May 26
to Mustafa Emre Acer, Kenichi Ishibashi, Zijie He, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, Hiroki Nakagawa, prerendering-reviews, mac-r...@chromium.org, fuchsia...@chromium.org, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Kenichi Ishibashi and Mustafa Emre Acer
Hiroshige Hayashizaki voted and added 2 comments![]( "Open in Gerrit")
Votes added by Hiroshige Hayashizaki
| Commit-Queue | +1 |
2 comments
Patchset-level comments
File-level comment, Patchset 37 (Latest):
Hiroshige Hayashizaki . resolved
+mea...@chromium.org as IPC reviewer for `mojom` file (manually assigned to the owner that randomly assigned in https://crrev.com/c/7869458).
File services/network/public/cpp/http_request_headers_mojom_traits.cc
Hiroshige Hayashizaki
Sounds reasonable. Created: https://crrev.com/c/7869458
Related details
Attention is currently required from:
- Kenichi Ishibashi
- Mustafa Emre Acer
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hiroshige Hayashizaki (Gerrit)
May 26, 2026, 8:24:19 PM (3 days ago) May 26
to Colin Blundell, Mustafa Emre Acer, Kenichi Ishibashi, Zijie He, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, Hiroki Nakagawa, prerendering-reviews, mac-r...@chromium.org, fuchsia...@chromium.org, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Colin Blundell, Kenichi Ishibashi and Mustafa Emre Acer
Hiroshige Hayashizaki added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Hiroshige Hayashizaki . resolved
+blundell@ PTAL for chrome and components OWNER review.
Related details
Attention is currently required from:
- Colin Blundell
- Kenichi Ishibashi
- Mustafa Emre Acer
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hiroshige Hayashizaki (Gerrit)
May 26, 2026, 8:27:31 PM (3 days ago) May 26
to Peter Conn, Colin Blundell, Mustafa Emre Acer, Kenichi Ishibashi, Zijie He, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, Hiroki Nakagawa, prerendering-reviews, mac-r...@chromium.org, fuchsia...@chromium.org, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Colin Blundell, Kenichi Ishibashi, Mustafa Emre Acer and Peter Conn
Hiroshige Hayashizaki added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Hiroshige Hayashizaki . resolved
peconn@ PTAL for android_webview OWNER review.
Related details
Attention is currently required from:
- Colin Blundell
- Kenichi Ishibashi
- Mustafa Emre Acer
- Peter Conn
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hiroshige Hayashizaki (Gerrit)
May 26, 2026, 9:12:28 PM (3 days ago) May 26
to Arthur Sonzogni, Peter Conn, Colin Blundell, Mustafa Emre Acer, Kenichi Ishibashi, Zijie He, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, Hiroki Nakagawa, prerendering-reviews, mac-r...@chromium.org, fuchsia...@chromium.org, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Arthur Sonzogni, Colin Blundell, Hiroshige Hayashizaki, Kenichi Ishibashi, Mustafa Emre Acer and Peter Conn
Hiroshige Hayashizaki voted and added 1 comment![]( "Open in Gerrit")
Votes added by Hiroshige Hayashizaki
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Hiroshige Hayashizaki . resolved
+arthursonzogni@ PTAL for content OWNER review.
Related details
Attention is currently required from:
- Arthur Sonzogni
- Colin Blundell
- Hiroshige Hayashizaki
- Kenichi Ishibashi
- Mustafa Emre Acer
- Peter Conn
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hiroshige Hayashizaki (Gerrit)
May 26, 2026, 9:17:16 PM (3 days ago) May 26
to Tim, Arthur Sonzogni, Peter Conn, Colin Blundell, Mustafa Emre Acer, Kenichi Ishibashi, Zijie He, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, Hiroki Nakagawa, prerendering-reviews, mac-r...@chromium.org, fuchsia...@chromium.org, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Arthur Sonzogni, Colin Blundell, Kenichi Ishibashi, Mustafa Emre Acer, Peter Conn and Tim
Hiroshige Hayashizaki voted and added 1 comment![]( "Open in Gerrit")
Votes added by Hiroshige Hayashizaki
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Hiroshige Hayashizaki . resolved
+tjudkins@ PTAL for extensions OWNER review.
Related details
Attention is currently required from:
- Arthur Sonzogni
- Colin Blundell
- Kenichi Ishibashi
- Mustafa Emre Acer
- Peter Conn
- Tim
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hiroshige Hayashizaki (Gerrit)
May 26, 2026, 9:22:32 PM (3 days ago) May 26
to David Dorwin, Tim, Arthur Sonzogni, Peter Conn, Colin Blundell, Mustafa Emre Acer, Kenichi Ishibashi, Zijie He, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, Hiroki Nakagawa, prerendering-reviews, mac-r...@chromium.org, fuchsia...@chromium.org, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Arthur Sonzogni, Colin Blundell, David Dorwin, Hiroshige Hayashizaki, Kenichi Ishibashi, Mustafa Emre Acer, Peter Conn and Tim
Hiroshige Hayashizaki voted and added 1 comment![]( "Open in Gerrit")
Votes added by Hiroshige Hayashizaki
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Hiroshige Hayashizaki . resolved
+ddorwin@ PTAL for fuchsia OWNER review.
Related details
Attention is currently required from:
- Arthur Sonzogni
- Colin Blundell
- David Dorwin
- Hiroshige Hayashizaki
- Kenichi Ishibashi
- Mustafa Emre Acer
- Peter Conn
- Tim
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Dorwin (Gerrit)
May 26, 2026, 9:38:22 PM (3 days ago) May 26
to Hiroshige Hayashizaki, Tim, Arthur Sonzogni, Peter Conn, Colin Blundell, Mustafa Emre Acer, Kenichi Ishibashi, Zijie He, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, Hiroki Nakagawa, prerendering-reviews, mac-r...@chromium.org, fuchsia...@chromium.org, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Arthur Sonzogni, Colin Blundell, Hiroshige Hayashizaki, Kenichi Ishibashi, Mustafa Emre Acer, Peter Conn and Tim
David Dorwin voted and added 1 comment![]( "Open in Gerrit")
Votes added by David Dorwin
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Arthur Sonzogni
- Colin Blundell
- Hiroshige Hayashizaki
- Kenichi Ishibashi
- Mustafa Emre Acer
- Peter Conn
- Tim
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
Hiroshige Hayashizaki (Gerrit)
May 26, 2026, 9:40:54 PM (3 days ago) May 26
to Tsuyoshi Horo, David Dorwin, Tim, Arthur Sonzogni, Peter Conn, Colin Blundell, Mustafa Emre Acer, Kenichi Ishibashi, Zijie He, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, Hiroki Nakagawa, prerendering-reviews, mac-r...@chromium.org, fuchsia...@chromium.org, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Arthur Sonzogni, Colin Blundell, Kenichi Ishibashi, Mustafa Emre Acer, Peter Conn, Tim and Tsuyoshi Horo
Hiroshige Hayashizaki added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Hiroshige Hayashizaki . resolved
horo@ PTAL for storage/browser/blob/blob_url_loader.* OWNER review.
Related details
Attention is currently required from:
- Arthur Sonzogni
- Colin Blundell
- Kenichi Ishibashi
- Mustafa Emre Acer
- Peter Conn
- Tim
- Tsuyoshi Horo
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tsuyoshi Horo (Gerrit)
May 27, 2026, 12:56:23 AM (3 days ago) May 27
to Hiroshige Hayashizaki, David Dorwin, Tim, Arthur Sonzogni, Peter Conn, Colin Blundell, Mustafa Emre Acer, Kenichi Ishibashi, Zijie He, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, Hiroki Nakagawa, prerendering-reviews, mac-r...@chromium.org, fuchsia...@chromium.org, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Arthur Sonzogni, Colin Blundell, David Dorwin, Hiroshige Hayashizaki, Kenichi Ishibashi, Mustafa Emre Acer, Peter Conn and Tim
Tsuyoshi Horo voted and added 1 comment![]( "Open in Gerrit")
Votes added by Tsuyoshi Horo
| Code-Review | +1 |
Hiroshige Hayashizaki . resolved
horo@ PTAL for storage/browser/blob/blob_url_loader.* OWNER review.
Attention is currently required from:
- Arthur Sonzogni
- Colin Blundell
- David Dorwin
- Hiroshige Hayashizaki
- Kenichi Ishibashi
- Mustafa Emre Acer
- Peter Conn
- Tim
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
May 27, 2026, 4:14:38 AM (3 days ago) May 27
to Hiroshige Hayashizaki, Tsuyoshi Horo, David Dorwin, Tim, Arthur Sonzogni, Peter Conn, Colin Blundell, Mustafa Emre Acer, Kenichi Ishibashi, Zijie He, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, Hiroki Nakagawa, prerendering-reviews, mac-r...@chromium.org, fuchsia...@chromium.org, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Arthur Sonzogni, David Dorwin, Hiroshige Hayashizaki, Kenichi Ishibashi, Mustafa Emre Acer, Peter Conn and Tim
Colin Blundell added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 38 (Latest):
Colin Blundell . resolved
Thanks, Hiroshige! This CL has quite a wide spread over //chrome and //components. I don't mind doing the reviews for all of this, but I'd prefer to do them in smaller CLs to be confident that I don't end up missing anything, if I'm understanding correctly that the changes here could be split across CLs without any problem?
Related details
Attention is currently required from:
- Arthur Sonzogni
Hiroshige Hayashizaki (Gerrit)
May 27, 2026, 3:08:47 PM (3 days ago) May 27
to Michael Thiessen, Igor Ruvinov, Chrome Signin Team, Max Curran, Tsuyoshi Horo, David Dorwin, Tim, Arthur Sonzogni, Peter Conn, Colin Blundell, Mustafa Emre Acer, Kenichi Ishibashi, Zijie He, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, Hiroki Nakagawa, prerendering-reviews, mac-r...@chromium.org, fuchsia...@chromium.org, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Arthur Sonzogni, Chrome Signin Team, Colin Blundell, David Dorwin, Igor Ruvinov, Kenichi Ishibashi, Max Curran, Michael Thiessen, Mustafa Emre Acer, Peter Conn and Tim
Hiroshige Hayashizaki added 3 comments![]( "Open in Gerrit")
Patchset-level comments
Colin Blundell . resolved
Thanks, Hiroshige! This CL has quite a wide spread over //chrome and //components. I don't mind doing the reviews for all of this, but I'd prefer to do them in smaller CLs to be confident that I don't end up missing anything, if I'm understanding correctly that the changes here could be split across CLs without any problem?
Hiroshige Hayashizaki
Colin Blundell . resolved
Thanks, Hiroshige! This CL has quite a wide spread over //chrome and //components. I don't mind doing the reviews for all of this, but I'd prefer to do them in smaller CLs to be confident that I don't end up missing anything, if I'm understanding correctly that the changes here could be split across CLs without any problem?
Hiroshige Hayashizaki
As discussed in the other CL https://crrev.com/c/7835809/comments/a0032e36_83efc0a0?tab=comments, this CL also can't be split, and I'll add subdir OWNERs.
Hiroshige Hayashizaki . resolved
PTAL,
mthiesse@ for components/navigation_interception
igorruvinov@ for components/enterprise/platform_auth
chrome-signin-reviews@ for chrome/browser/signin/
curranmax@ for chrome/browser/offline_pages
Related details
Attention is currently required from:
- Arthur Sonzogni
- Chrome Signin Team
- Colin Blundell
- David Dorwin
- Igor Ruvinov
- Kenichi Ishibashi
- Max Curran
- Michael Thiessen
- Mustafa Emre Acer
- Peter Conn
- Tim
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
gwsq (Gerrit)
May 27, 2026, 3:11:38 PM (3 days ago) May 27
to Hiroshige Hayashizaki, Chrome Signin Team, Monica Salama, Ernest Nguyen Hung, Michael Thiessen, Igor Ruvinov, Max Curran, Tsuyoshi Horo, David Dorwin, Tim, Arthur Sonzogni, Peter Conn, Colin Blundell, Mustafa Emre Acer, Kenichi Ishibashi, Zijie He, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, Hiroki Nakagawa, prerendering-reviews, mac-r...@chromium.org, fuchsia...@chromium.org, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Arthur Sonzogni, Colin Blundell, David Dorwin, Ernest Nguyen Hung, Igor Ruvinov, Kenichi Ishibashi, Max Curran, Michael Thiessen, Monica Salama, Mustafa Emre Acer, Peter Conn and Tim
Message from gwsq![]( "Open in Gerrit")
Shadowed: er...@google.com
Reviewer source(s):
er...@google.com, msa...@chromium.org is from context(googleclient/chrome/chromium_gwsq/components/signin/config.gwsq)
Related details
Attention is currently required from:
- Arthur Sonzogni
- Colin Blundell
- David Dorwin
- Ernest Nguyen Hung
- Igor Ruvinov
- Kenichi Ishibashi
- Max Curran
- Michael Thiessen
- Monica Salama
- Mustafa Emre Acer
- Peter Conn
- Tim
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hiroshige Hayashizaki (Gerrit)
May 27, 2026, 3:12:35 PM (3 days ago) May 27
to Jinsuk Kim, Hiroki Nakagawa, Chrome Signin Team, Monica Salama, Ernest Nguyen Hung, Michael Thiessen, Igor Ruvinov, Max Curran, Tsuyoshi Horo, David Dorwin, Tim, Arthur Sonzogni, Peter Conn, Colin Blundell, Mustafa Emre Acer, Kenichi Ishibashi, Zijie He, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, prerendering-reviews, mac-r...@chromium.org, fuchsia...@chromium.org, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Arthur Sonzogni, Colin Blundell, David Dorwin, Ernest Nguyen Hung, Hiroki Nakagawa, Igor Ruvinov, Jinsuk Kim, Kenichi Ishibashi, Max Curran, Michael Thiessen, Monica Salama, Mustafa Emre Acer, Peter Conn and Tim
Hiroshige Hayashizaki added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Hiroshige Hayashizaki . resolved
PTAL
jinsukkim@ for components/embedder_support/android/util
nhiroki@ for chrome/browser/preloading/prefetch/search_prefetch
Related details
Attention is currently required from:
- Arthur Sonzogni
- Colin Blundell
- David Dorwin
- Ernest Nguyen Hung
- Hiroki Nakagawa
- Igor Ruvinov
- Jinsuk Kim
Hiroshige Hayashizaki (Gerrit)
May 27, 2026, 3:14:19 PM (3 days ago) May 27
to Kouhei Ueno, Jinsuk Kim, Hiroki Nakagawa, Chrome Signin Team, Monica Salama, Ernest Nguyen Hung, Michael Thiessen, Igor Ruvinov, Max Curran, Tsuyoshi Horo, David Dorwin, Tim, Arthur Sonzogni, Peter Conn, Colin Blundell, Mustafa Emre Acer, Kenichi Ishibashi, Zijie He, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, prerendering-reviews, mac-r...@chromium.org, fuchsia...@chromium.org, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Arthur Sonzogni, Colin Blundell, David Dorwin, Ernest Nguyen Hung, Hiroki Nakagawa, Igor Ruvinov, Jinsuk Kim, Kenichi Ishibashi, Kouhei Ueno, Max Curran, Michael Thiessen, Monica Salama, Mustafa Emre Acer, Peter Conn and Tim
Hiroshige Hayashizaki added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Hiroshige Hayashizaki . resolved
PTAL kouhei@ for content/browser/web_package
Related details
Attention is currently required from:
- Arthur Sonzogni
- Colin Blundell
- David Dorwin
- Ernest Nguyen Hung
- Hiroki Nakagawa
- Igor Ruvinov
- Jinsuk Kim
- Kenichi Ishibashi
- Kouhei Ueno
Jinsuk Kim (Gerrit)
May 27, 2026, 3:19:15 PM (3 days ago) May 27
to Hiroshige Hayashizaki, Kouhei Ueno, Hiroki Nakagawa, Chrome Signin Team, Monica Salama, Ernest Nguyen Hung, Michael Thiessen, Igor Ruvinov, Max Curran, Tsuyoshi Horo, David Dorwin, Tim, Arthur Sonzogni, Peter Conn, Colin Blundell, Mustafa Emre Acer, Kenichi Ishibashi, Zijie He, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, prerendering-reviews, mac-r...@chromium.org, fuchsia...@chromium.org, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Arthur Sonzogni, Colin Blundell, David Dorwin, Ernest Nguyen Hung, Hiroki Nakagawa, Hiroshige Hayashizaki, Igor Ruvinov, Kenichi Ishibashi, Kouhei Ueno, Max Curran, Michael Thiessen, Monica Salama, Mustafa Emre Acer, Peter Conn and Tim
Jinsuk Kim voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jinsuk Kim
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Arthur Sonzogni
- Colin Blundell
- David Dorwin
- Ernest Nguyen Hung
- Hiroki Nakagawa
- Hiroshige Hayashizaki
- Igor Ruvinov
Max Curran (Gerrit)
May 27, 2026, 3:43:54 PM (3 days ago) May 27
to Hiroshige Hayashizaki, Jinsuk Kim, Kouhei Ueno, Hiroki Nakagawa, Chrome Signin Team, Monica Salama, Ernest Nguyen Hung, Michael Thiessen, Igor Ruvinov, Tsuyoshi Horo, David Dorwin, Tim, Arthur Sonzogni, Peter Conn, Colin Blundell, Mustafa Emre Acer, Kenichi Ishibashi, Zijie He, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, prerendering-reviews, mac-r...@chromium.org, fuchsia...@chromium.org, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Arthur Sonzogni, Colin Blundell, David Dorwin, Ernest Nguyen Hung, Hiroki Nakagawa, Hiroshige Hayashizaki, Igor Ruvinov, Kenichi Ishibashi, Kouhei Ueno, Michael Thiessen, Monica Salama, Mustafa Emre Acer, Peter Conn and Tim
Max Curran voted and added 1 comment![]( "Open in Gerrit")
Votes added by Max Curran
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Arthur Sonzogni
- Colin Blundell
- David Dorwin
- Ernest Nguyen Hung
- Hiroki Nakagawa
- Hiroshige Hayashizaki
- Igor Ruvinov
- Kenichi Ishibashi
- Kouhei Ueno
Tim (Gerrit)
May 27, 2026, 4:12:25 PM (3 days ago) May 27
to Hiroshige Hayashizaki, Max Curran, Jinsuk Kim, Kouhei Ueno, Hiroki Nakagawa, Chrome Signin Team, Monica Salama, Ernest Nguyen Hung, Michael Thiessen, Igor Ruvinov, Tsuyoshi Horo, David Dorwin, Arthur Sonzogni, Peter Conn, Colin Blundell, Mustafa Emre Acer, Kenichi Ishibashi, Zijie He, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, prerendering-reviews, mac-r...@chromium.org, fuchsia...@chromium.org, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Arthur Sonzogni, Colin Blundell, David Dorwin, Ernest Nguyen Hung, Hiroki Nakagawa, Hiroshige Hayashizaki, Igor Ruvinov, Kenichi Ishibashi, Kouhei Ueno, Michael Thiessen, Monica Salama, Mustafa Emre Acer and Peter Conn
Tim voted and added 1 comment![]( "Open in Gerrit")
Votes added by Tim
| Code-Review | +1 |
1 comment
Patchset-level comments
Tim . resolved
extensions/* LGTM! Thanks!
Related details
Attention is currently required from:
- Arthur Sonzogni
- Colin Blundell
- David Dorwin
- Ernest Nguyen Hung
- Hiroki Nakagawa
- Hiroshige Hayashizaki
- Igor Ruvinov
- Kenichi Ishibashi
- Kouhei Ueno
- Michael Thiessen
- Monica Salama
- Mustafa Emre Acer
- Peter Conn
Ernest Nguyen Hung (Gerrit)
May 27, 2026, 4:23:13 PM (3 days ago) May 27
to Hiroshige Hayashizaki, Tim, Max Curran, Jinsuk Kim, Kouhei Ueno, Hiroki Nakagawa, Chrome Signin Team, Monica Salama, Michael Thiessen, Igor Ruvinov, Tsuyoshi Horo, David Dorwin, Arthur Sonzogni, Peter Conn, Colin Blundell, Mustafa Emre Acer, Kenichi Ishibashi, Zijie He, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, prerendering-reviews, mac-r...@chromium.org, fuchsia...@chromium.org, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Arthur Sonzogni, Colin Blundell, David Dorwin, Hiroki Nakagawa, Hiroshige Hayashizaki, Igor Ruvinov, Kenichi Ishibashi, Kouhei Ueno, Michael Thiessen, Monica Salama, Mustafa Emre Acer and Peter Conn
Ernest Nguyen Hung voted and added 1 comment![]( "Open in Gerrit")
Votes added by Ernest Nguyen Hung
| Code-Review | +1 |
1 comment
Patchset-level comments
Ernest Nguyen Hung . resolved
`chrome/browser/signin/chrome_signin_proxying_url_loader_factory.cc` LGTM.
Related details
Attention is currently required from:
- Arthur Sonzogni
- Colin Blundell
- David Dorwin
Hiroshige Hayashizaki (Gerrit)
May 27, 2026, 4:36:35 PM (3 days ago) May 27
to Andrew Rayskiy, Ernest Nguyen Hung, Tim, Max Curran, Jinsuk Kim, Kouhei Ueno, Hiroki Nakagawa, Chrome Signin Team, Monica Salama, Michael Thiessen, Igor Ruvinov, Tsuyoshi Horo, David Dorwin, Arthur Sonzogni, Peter Conn, Colin Blundell, Mustafa Emre Acer, Kenichi Ishibashi, Zijie He, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, prerendering-reviews, mac-r...@chromium.org, fuchsia...@chromium.org, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Andrew Rayskiy, Arthur Sonzogni, Colin Blundell, David Dorwin, Hiroki Nakagawa, Igor Ruvinov, Kenichi Ishibashi, Kouhei Ueno, Michael Thiessen, Monica Salama, Mustafa Emre Acer and Peter Conn
Hiroshige Hayashizaki added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Hiroshige Hayashizaki . resolved
PTAL +greengrape@ for components/webapps/isolated_web_apps/url_loading/url_loader.cc
Related details
Attention is currently required from:
- Andrew Rayskiy
- Arthur Sonzogni
- Colin Blundell
- David Dorwin
- Hiroki Nakagawa
- Igor Ruvinov
- Kenichi Ishibashi
- Kouhei Ueno
- Michael Thiessen
- Monica Salama
- Mustafa Emre Acer
- Peter Conn
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hiroshige Hayashizaki (Gerrit)
May 27, 2026, 4:38:08 PM (3 days ago) May 27
to Min Qin, Andrew Rayskiy, Ernest Nguyen Hung, Tim, Max Curran, Jinsuk Kim, Kouhei Ueno, Hiroki Nakagawa, Chrome Signin Team, Monica Salama, Michael Thiessen, Igor Ruvinov, Tsuyoshi Horo, David Dorwin, Arthur Sonzogni, Peter Conn, Colin Blundell, Mustafa Emre Acer, Kenichi Ishibashi, Zijie He, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, prerendering-reviews, mac-r...@chromium.org, fuchsia...@chromium.org, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Andrew Rayskiy, Arthur Sonzogni, Colin Blundell, David Dorwin, Hiroki Nakagawa, Igor Ruvinov, Kenichi Ishibashi, Kouhei Ueno, Michael Thiessen, Min Qin, Monica Salama, Mustafa Emre Acer and Peter Conn
Hiroshige Hayashizaki added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Andrew Rayskiy
- Arthur Sonzogni
- Colin Blundell
- David Dorwin
- Hiroki Nakagawa
- Igor Ruvinov
- Kenichi Ishibashi
- Kouhei Ueno
- Michael Thiessen
- Min Qin
Hiroshige Hayashizaki (Gerrit)
May 27, 2026, 4:43:54 PM (3 days ago) May 27
to Bo Majewski, Min Qin, Andrew Rayskiy, Ernest Nguyen Hung, Tim, Max Curran, Jinsuk Kim, Kouhei Ueno, Hiroki Nakagawa, Chrome Signin Team, Monica Salama, Michael Thiessen, Igor Ruvinov, Tsuyoshi Horo, David Dorwin, Arthur Sonzogni, Peter Conn, Colin Blundell, Mustafa Emre Acer, Kenichi Ishibashi, Zijie He, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, prerendering-reviews, mac-r...@chromium.org, fuchsia...@chromium.org, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Andrew Rayskiy, Arthur Sonzogni, Bo Majewski, Colin Blundell, David Dorwin, Hiroki Nakagawa, Igor Ruvinov, Kenichi Ishibashi, Kouhei Ueno, Michael Thiessen, Min Qin, Monica Salama, Mustafa Emre Acer and Peter Conn
Hiroshige Hayashizaki added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Hiroshige Hayashizaki . resolved
PTAL +majewski@ for chrome/browser/ash/fileapi/
Related details
Attention is currently required from:
- Andrew Rayskiy
- Arthur Sonzogni
- Bo Majewski
Hiroshige Hayashizaki (Gerrit)
May 27, 2026, 4:46:38 PM (3 days ago) May 27
to Yao Xiao, Bo Majewski, Min Qin, Andrew Rayskiy, Ernest Nguyen Hung, Tim, Max Curran, Jinsuk Kim, Kouhei Ueno, Hiroki Nakagawa, Chrome Signin Team, Monica Salama, Michael Thiessen, Igor Ruvinov, Tsuyoshi Horo, David Dorwin, Arthur Sonzogni, Peter Conn, Colin Blundell, Mustafa Emre Acer, Kenichi Ishibashi, Zijie He, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, prerendering-reviews, mac-r...@chromium.org, fuchsia...@chromium.org, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Andrew Rayskiy, Arthur Sonzogni, Bo Majewski, Colin Blundell, David Dorwin, Hiroki Nakagawa, Igor Ruvinov, Kenichi Ishibashi, Kouhei Ueno, Michael Thiessen, Min Qin, Monica Salama, Mustafa Emre Acer, Peter Conn and Yao Xiao
Hiroshige Hayashizaki added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Hiroshige Hayashizaki . resolved
PTAL +yaoxia@ for content/browser/browsing_topics/
Related details
Attention is currently required from:
- Andrew Rayskiy
- Arthur Sonzogni
- Bo Majewski
- Colin Blundell
- David Dorwin
- Hiroki Nakagawa
- Igor Ruvinov
- Kenichi Ishibashi
- Kouhei Ueno
- Michael Thiessen
- Min Qin
- Monica Salama
- Mustafa Emre Acer
- Peter Conn
- Yao Xiao
Hiroshige Hayashizaki (Gerrit)
May 27, 2026, 4:48:25 PM (3 days ago) May 27
to Russ Hamilton, Yao Xiao, Bo Majewski, Min Qin, Andrew Rayskiy, Ernest Nguyen Hung, Tim, Max Curran, Jinsuk Kim, Kouhei Ueno, Hiroki Nakagawa, Chrome Signin Team, Monica Salama, Michael Thiessen, Igor Ruvinov, Tsuyoshi Horo, David Dorwin, Arthur Sonzogni, Peter Conn, Colin Blundell, Mustafa Emre Acer, Kenichi Ishibashi, Zijie He, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, prerendering-reviews, mac-r...@chromium.org, fuchsia...@chromium.org, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Andrew Rayskiy, Arthur Sonzogni, Bo Majewski, Colin Blundell, David Dorwin, Hiroki Nakagawa, Igor Ruvinov, Kenichi Ishibashi, Kouhei Ueno, Michael Thiessen, Min Qin, Monica Salama, Mustafa Emre Acer, Peter Conn, Russ Hamilton and Yao Xiao
Hiroshige Hayashizaki added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Hiroshige Hayashizaki . resolved
PTAL behamilton@ for content/browser/interest_group
Related details
Attention is currently required from:
- Andrew Rayskiy
- Arthur Sonzogni
- Bo Majewski
- Colin Blundell
- David Dorwin
- Hiroki Nakagawa
- Igor Ruvinov
- Kenichi Ishibashi
- Kouhei Ueno
- Michael Thiessen
- Min Qin
- Monica Salama
- Mustafa Emre Acer
- Peter Conn
- Russ Hamilton
- Yao Xiao
Russ Hamilton (Gerrit)
May 27, 2026, 4:49:46 PM (3 days ago) May 27
to Hiroshige Hayashizaki, Yao Xiao, Bo Majewski, Min Qin, Andrew Rayskiy, Ernest Nguyen Hung, Tim, Max Curran, Jinsuk Kim, Kouhei Ueno, Hiroki Nakagawa, Chrome Signin Team, Monica Salama, Michael Thiessen, Igor Ruvinov, Tsuyoshi Horo, David Dorwin, Arthur Sonzogni, Peter Conn, Colin Blundell, Mustafa Emre Acer, Kenichi Ishibashi, Zijie He, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, prerendering-reviews, mac-r...@chromium.org, fuchsia...@chromium.org, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Andrew Rayskiy, Arthur Sonzogni, Bo Majewski, Colin Blundell, David Dorwin, Hiroki Nakagawa, Hiroshige Hayashizaki, Igor Ruvinov, Kenichi Ishibashi, Kouhei Ueno, Michael Thiessen, Min Qin, Monica Salama, Mustafa Emre Acer, Peter Conn and Yao Xiao
Russ Hamilton voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Andrew Rayskiy
- Arthur Sonzogni
- Bo Majewski
- Colin Blundell
- David Dorwin
- Hiroki Nakagawa
- Hiroshige Hayashizaki
- Igor Ruvinov
- Kenichi Ishibashi
- Kouhei Ueno
- Michael Thiessen
- Min Qin
- Monica Salama
- Mustafa Emre Acer
- Peter Conn
- Yao Xiao
Hiroshige Hayashizaki (Gerrit)
May 27, 2026, 4:52:03 PM (3 days ago) May 27
to Andrey Kosyakov, Russ Hamilton, Yao Xiao, Bo Majewski, Min Qin, Andrew Rayskiy, Ernest Nguyen Hung, Tim, Max Curran, Jinsuk Kim, Kouhei Ueno, Hiroki Nakagawa, Chrome Signin Team, Monica Salama, Michael Thiessen, Igor Ruvinov, Tsuyoshi Horo, David Dorwin, Arthur Sonzogni, Peter Conn, Colin Blundell, Mustafa Emre Acer, Kenichi Ishibashi, Zijie He, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, prerendering-reviews, mac-r...@chromium.org, fuchsia...@chromium.org, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Andrew Rayskiy, Andrey Kosyakov, Arthur Sonzogni, Bo Majewski, Colin Blundell, David Dorwin, Hiroki Nakagawa, Hiroshige Hayashizaki, Igor Ruvinov, Kenichi Ishibashi, Kouhei Ueno, Michael Thiessen, Min Qin, Monica Salama, Mustafa Emre Acer, Peter Conn and Yao Xiao
Hiroshige Hayashizaki added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Hiroshige Hayashizaki . resolved
+caseq@ PTAL for content/browser/devtools
Related details
Attention is currently required from:
- Andrew Rayskiy
- Andrey Kosyakov
Michael Thiessen (Gerrit)
May 27, 2026, 4:56:49 PM (3 days ago) May 27
to Hiroshige Hayashizaki, Andrey Kosyakov, Russ Hamilton, Yao Xiao, Bo Majewski, Min Qin, Andrew Rayskiy, Ernest Nguyen Hung, Tim, Max Curran, Jinsuk Kim, Kouhei Ueno, Hiroki Nakagawa, Chrome Signin Team, Monica Salama, Igor Ruvinov, Tsuyoshi Horo, David Dorwin, Arthur Sonzogni, Peter Conn, Colin Blundell, Mustafa Emre Acer, Kenichi Ishibashi, Zijie He, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, prerendering-reviews, mac-r...@chromium.org, fuchsia...@chromium.org, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Andrew Rayskiy, Andrey Kosyakov, Arthur Sonzogni, Bo Majewski, Colin Blundell, David Dorwin, Hiroki Nakagawa, Hiroshige Hayashizaki, Igor Ruvinov, Kenichi Ishibashi, Kouhei Ueno, Min Qin, Monica Salama, Mustafa Emre Acer, Peter Conn and Yao Xiao
Michael Thiessen voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Andrew Rayskiy
- Andrey Kosyakov
- Arthur Sonzogni
- Bo Majewski
- Colin Blundell
- David Dorwin
- Hiroki Nakagawa
- Hiroshige Hayashizaki
- Igor Ruvinov
- Kenichi Ishibashi
- Kouhei Ueno
Yao Xiao (Gerrit)
May 27, 2026, 4:58:24 PM (3 days ago) May 27
to Hiroshige Hayashizaki, Michael Thiessen, Andrey Kosyakov, Russ Hamilton, Bo Majewski, Min Qin, Andrew Rayskiy, Ernest Nguyen Hung, Tim, Max Curran, Jinsuk Kim, Kouhei Ueno, Hiroki Nakagawa, Chrome Signin Team, Monica Salama, Igor Ruvinov, Tsuyoshi Horo, David Dorwin, Arthur Sonzogni, Peter Conn, Colin Blundell, Mustafa Emre Acer, Kenichi Ishibashi, Zijie He, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, prerendering-reviews, mac-r...@chromium.org, fuchsia...@chromium.org, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Andrew Rayskiy, Andrey Kosyakov, Arthur Sonzogni, Bo Majewski, Colin Blundell, David Dorwin, Hiroki Nakagawa, Hiroshige Hayashizaki, Igor Ruvinov, Kenichi Ishibashi, Kouhei Ueno, Min Qin, Monica Salama, Mustafa Emre Acer and Peter Conn
Yao Xiao voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Andrew Rayskiy
- Andrey Kosyakov
- Arthur Sonzogni
- Bo Majewski
- Colin Blundell
- David Dorwin
- Hiroki Nakagawa
- Hiroshige Hayashizaki
- Igor Ruvinov
- Kenichi Ishibashi
- Kouhei Ueno
- Min Qin
- Monica Salama
- Mustafa Emre Acer
- Peter Conn
Michael Thiessen (Gerrit)
May 27, 2026, 4:58:49 PM (3 days ago) May 27
to Hiroshige Hayashizaki, Yao Xiao, Andrey Kosyakov, Russ Hamilton, Bo Majewski, Min Qin, Andrew Rayskiy, Ernest Nguyen Hung, Tim, Max Curran, Jinsuk Kim, Kouhei Ueno, Hiroki Nakagawa, Chrome Signin Team, Monica Salama, Igor Ruvinov, Tsuyoshi Horo, David Dorwin, Arthur Sonzogni, Peter Conn, Colin Blundell, Mustafa Emre Acer, Kenichi Ishibashi, Zijie He, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, prerendering-reviews, mac-r...@chromium.org, fuchsia...@chromium.org, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Andrew Rayskiy, Andrey Kosyakov, Arthur Sonzogni, Bo Majewski, Colin Blundell, David Dorwin, Hiroki Nakagawa, Hiroshige Hayashizaki, Igor Ruvinov, Kenichi Ishibashi, Kouhei Ueno, Min Qin, Monica Salama, Mustafa Emre Acer and Peter Conn
Michael Thiessen added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Colin Blundell . resolved
Hiroshige HayashizakiThanks, Hiroshige! This CL has quite a wide spread over //chrome and //components. I don't mind doing the reviews for all of this, but I'd prefer to do them in smaller CLs to be confident that I don't end up missing anything, if I'm understanding correctly that the changes here could be split across CLs without any problem?
Michael Thiessen
In the future for CLs like this I would recommend finding somebody with owners-override powers as this is a largely mechanical change, so you only need 1-2 reviewers.
Igor Ruvinov (Gerrit)
May 27, 2026, 5:03:04 PM (3 days ago) May 27
to Hiroshige Hayashizaki, Yao Xiao, Michael Thiessen, Andrey Kosyakov, Russ Hamilton, Bo Majewski, Min Qin, Andrew Rayskiy, Ernest Nguyen Hung, Tim, Max Curran, Jinsuk Kim, Kouhei Ueno, Hiroki Nakagawa, Chrome Signin Team, Monica Salama, Tsuyoshi Horo, David Dorwin, Arthur Sonzogni, Peter Conn, Colin Blundell, Mustafa Emre Acer, Kenichi Ishibashi, Zijie He, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, prerendering-reviews, mac-r...@chromium.org, fuchsia...@chromium.org, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Andrew Rayskiy, Andrey Kosyakov, Arthur Sonzogni, Bo Majewski, Colin Blundell, David Dorwin, Hiroki Nakagawa, Hiroshige Hayashizaki, Kenichi Ishibashi, Kouhei Ueno, Min Qin, Monica Salama, Mustafa Emre Acer and Peter Conn
Igor Ruvinov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Igor Ruvinov
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Andrew Rayskiy
- Andrey Kosyakov
- Arthur Sonzogni
- Bo Majewski
- Colin Blundell
- David Dorwin
- Hiroki Nakagawa
- Hiroshige Hayashizaki
Min Qin (Gerrit)
May 27, 2026, 6:14:53 PM (2 days ago) May 27
to Hiroshige Hayashizaki, Igor Ruvinov, Yao Xiao, Michael Thiessen, Andrey Kosyakov, Russ Hamilton, Bo Majewski, Andrew Rayskiy, Ernest Nguyen Hung, Tim, Max Curran, Jinsuk Kim, Kouhei Ueno, Hiroki Nakagawa, Chrome Signin Team, Monica Salama, Tsuyoshi Horo, David Dorwin, Arthur Sonzogni, Peter Conn, Colin Blundell, Mustafa Emre Acer, Kenichi Ishibashi, Zijie He, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, prerendering-reviews, mac-r...@chromium.org, fuchsia...@chromium.org, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Andrew Rayskiy, Andrey Kosyakov, Arthur Sonzogni, Bo Majewski, Colin Blundell, David Dorwin, Hiroki Nakagawa, Hiroshige Hayashizaki, Kenichi Ishibashi, Kouhei Ueno, Monica Salama, Mustafa Emre Acer and Peter Conn
Min Qin voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Andrew Rayskiy
- Andrey Kosyakov
- Arthur Sonzogni
- Bo Majewski
- Colin Blundell
- David Dorwin
- Hiroki Nakagawa
- Hiroshige Hayashizaki
- Kenichi Ishibashi
- Kouhei Ueno
Kenichi Ishibashi (Gerrit)
May 27, 2026, 7:39:41 PM (2 days ago) May 27
to Hiroshige Hayashizaki, Min Qin, Igor Ruvinov, Yao Xiao, Michael Thiessen, Andrey Kosyakov, Russ Hamilton, Bo Majewski, Andrew Rayskiy, Ernest Nguyen Hung, Tim, Max Curran, Jinsuk Kim, Kouhei Ueno, Hiroki Nakagawa, Chrome Signin Team, Monica Salama, Tsuyoshi Horo, David Dorwin, Arthur Sonzogni, Peter Conn, Colin Blundell, Mustafa Emre Acer, Zijie He, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, prerendering-reviews, mac-r...@chromium.org, fuchsia...@chromium.org, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Andrew Rayskiy, Andrey Kosyakov, Arthur Sonzogni, Bo Majewski, Colin Blundell, David Dorwin, Hiroki Nakagawa, Hiroshige Hayashizaki, Kouhei Ueno, Monica Salama, Mustafa Emre Acer and Peter Conn
Kenichi Ishibashi voted and added 2 comments![]( "Open in Gerrit")
Votes added by Kenichi Ishibashi
| Code-Review | +1 |
2 comments
Patchset-level comments
Kenichi Ishibashi . resolved
stamp-ish lgtm
File components/download/internal/common/resource_downloader.cc
Line 278, Patchset 38 (Latest):
url_loader_->FollowRedirect({}, std::nullopt);Kenichi Ishibashi . unresolved
nit: `/*headers_update_params=*/`
Ditto below.
Related details
Attention is currently required from:
- Andrew Rayskiy
- Andrey Kosyakov
- Arthur Sonzogni
- Bo Majewski
- Colin Blundell
- David Dorwin
- Hiroki Nakagawa
- Hiroshige Hayashizaki
Kouhei Ueno (Gerrit)
May 27, 2026, 9:59:05 PM (2 days ago) May 27
to Hiroshige Hayashizaki, Kenichi Ishibashi, Min Qin, Igor Ruvinov, Yao Xiao, Michael Thiessen, Andrey Kosyakov, Russ Hamilton, Bo Majewski, Andrew Rayskiy, Ernest Nguyen Hung, Tim, Max Curran, Jinsuk Kim, Hiroki Nakagawa, Chrome Signin Team, Monica Salama, Tsuyoshi Horo, David Dorwin, Arthur Sonzogni, Peter Conn, Colin Blundell, Mustafa Emre Acer, Zijie He, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, prerendering-reviews, mac-r...@chromium.org, fuchsia...@chromium.org, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Andrew Rayskiy, Andrey Kosyakov, Arthur Sonzogni, Bo Majewski, Colin Blundell, David Dorwin, Hiroki Nakagawa, Hiroshige Hayashizaki, Monica Salama, Mustafa Emre Acer and Peter Conn
Kouhei Ueno voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Andrew Rayskiy
- Andrey Kosyakov
- Arthur Sonzogni
- Bo Majewski
- Colin Blundell
- David Dorwin
- Hiroki Nakagawa
- Hiroshige Hayashizaki
Colin Blundell (Gerrit)
May 28, 2026, 3:08:04 AM (2 days ago) May 28
to Hiroshige Hayashizaki, Colin Blundell, Kouhei Ueno, Kenichi Ishibashi, Min Qin, Igor Ruvinov, Yao Xiao, Michael Thiessen, Andrey Kosyakov, Russ Hamilton, Bo Majewski, Andrew Rayskiy, Ernest Nguyen Hung, Tim, Max Curran, Jinsuk Kim, Hiroki Nakagawa, Chrome Signin Team, Monica Salama, Tsuyoshi Horo, David Dorwin, Arthur Sonzogni, Peter Conn, Mustafa Emre Acer, Zijie He, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, prerendering-reviews, mac-r...@chromium.org, fuchsia...@chromium.org, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Andrew Rayskiy, Andrey Kosyakov, Arthur Sonzogni, Bo Majewski, David Dorwin, Hiroki Nakagawa, Hiroshige Hayashizaki, Monica Salama, Mustafa Emre Acer and Peter Conn
Colin Blundell voted and added 2 comments![]( "Open in Gerrit")
Votes added by Colin Blundell
| Code-Review | +1 |
2 comments
Patchset-level comments
Colin Blundell . resolved
Hiroshige HayashizakiThanks, Hiroshige! This CL has quite a wide spread over //chrome and //components. I don't mind doing the reviews for all of this, but I'd prefer to do them in smaller CLs to be confident that I don't end up missing anything, if I'm understanding correctly that the changes here could be split across CLs without any problem?
Michael Thiessen
In the future for CLs like this I would recommend finding somebody with owners-override powers as this is a largely mechanical change, so you only need 1-2 reviewers.
Colin Blundell
This is on me - I had asked Hiroshige to find closer OWNERS for //chrome and //components as I didn't feel comfortable reviewing all of that spread. It definitely introduced a fair bit of process overhead, for which I apologize.
Colin Blundell . resolved
Thanks, Hiroshige! I appreciate your effort here. Remaining //chrome and //components files LGTM.
Related details
Attention is currently required from:
- Andrew Rayskiy
- Andrey Kosyakov
- Arthur Sonzogni
- Bo Majewski
Monica Salama (Gerrit)
May 28, 2026, 4:08:08 AM (2 days ago) May 28
to Hiroshige Hayashizaki, Colin Blundell, Kouhei Ueno, Kenichi Ishibashi, Min Qin, Igor Ruvinov, Yao Xiao, Michael Thiessen, Andrey Kosyakov, Russ Hamilton, Bo Majewski, Andrew Rayskiy, Ernest Nguyen Hung, Tim, Max Curran, Jinsuk Kim, Hiroki Nakagawa, Chrome Signin Team, Tsuyoshi Horo, David Dorwin, Arthur Sonzogni, Peter Conn, Mustafa Emre Acer, Zijie He, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, prerendering-reviews, mac-r...@chromium.org, fuchsia...@chromium.org, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Andrew Rayskiy, Andrey Kosyakov, Arthur Sonzogni, Bo Majewski, David Dorwin, Hiroki Nakagawa, Hiroshige Hayashizaki, Mustafa Emre Acer and Peter Conn
Monica Salama voted and added 1 comment![]( "Open in Gerrit")
Votes added by Monica Salama
| Code-Review | +1 |
1 comment
Patchset-level comments
Monica Salama . resolved
chrome/browser/signin/chrome_signin_proxying_url_loader_factory.cc,LGTM, thanks!
Related details
Attention is currently required from:
- Andrew Rayskiy
- Andrey Kosyakov
- Arthur Sonzogni
- Bo Majewski
- David Dorwin
- Hiroki Nakagawa
- Hiroshige Hayashizaki
Andrew Rayskiy (Gerrit)
May 28, 2026, 4:34:15 AM (2 days ago) May 28
to Hiroshige Hayashizaki, Monica Salama, Colin Blundell, Kouhei Ueno, Kenichi Ishibashi, Min Qin, Igor Ruvinov, Yao Xiao, Michael Thiessen, Andrey Kosyakov, Russ Hamilton, Bo Majewski, Ernest Nguyen Hung, Tim, Max Curran, Jinsuk Kim, Hiroki Nakagawa, Chrome Signin Team, Tsuyoshi Horo, David Dorwin, Arthur Sonzogni, Peter Conn, Mustafa Emre Acer, Zijie He, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, prerendering-reviews, mac-r...@chromium.org, fuchsia...@chromium.org, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Andrey Kosyakov, Arthur Sonzogni, Bo Majewski, David Dorwin, Hiroki Nakagawa, Hiroshige Hayashizaki, Mustafa Emre Acer and Peter Conn
Andrew Rayskiy voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
Arthur Sonzogni (Gerrit)
May 28, 2026, 4:50:35 AM (2 days ago) May 28
to Hiroshige Hayashizaki, Andrew Rayskiy, Monica Salama, Colin Blundell, Kouhei Ueno, Kenichi Ishibashi, Min Qin, Igor Ruvinov, Yao Xiao, Michael Thiessen, Andrey Kosyakov, Russ Hamilton, Bo Majewski, Ernest Nguyen Hung, Tim, Max Curran, Jinsuk Kim, Hiroki Nakagawa, Chrome Signin Team, Tsuyoshi Horo, David Dorwin, Peter Conn, Mustafa Emre Acer, Zijie He, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, prerendering-reviews, mac-r...@chromium.org, fuchsia...@chromium.org, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Andrey Kosyakov, Bo Majewski, David Dorwin, Hiroki Nakagawa, Hiroshige Hayashizaki, Mustafa Emre Acer and Peter Conn
Arthur Sonzogni voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Andrey Kosyakov
Hiroshige Hayashizaki (Gerrit)
May 28, 2026, 4:22:52 PM (2 days ago) May 28
to Nate Fischer, Arthur Sonzogni, Andrew Rayskiy, Monica Salama, Colin Blundell, Kouhei Ueno, Kenichi Ishibashi, Min Qin, Igor Ruvinov, Yao Xiao, Michael Thiessen, Andrey Kosyakov, Russ Hamilton, Bo Majewski, Ernest Nguyen Hung, Tim, Max Curran, Jinsuk Kim, Hiroki Nakagawa, Chrome Signin Team, Tsuyoshi Horo, David Dorwin, Mustafa Emre Acer, Zijie He, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, prerendering-reviews, mac-r...@chromium.org, fuchsia...@chromium.org, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Andrey Kosyakov, Bo Majewski, David Dorwin, Hiroki Nakagawa, Mustafa Emre Acer and Nate Fischer
Hiroshige Hayashizaki added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 38:
Hiroshige Hayashizaki . resolved
+ntfschr@ PTAL as android_webview/browser/network_service OWNER
(Removing peconn@ instead due to OOO)
File components/download/internal/common/resource_downloader.cc
Line 278, Patchset 38:
url_loader_->FollowRedirect({}, std::nullopt);Kenichi Ishibashi . resolved
Hiroshige Hayashizakinit: `/*headers_update_params=*/`
Ditto below.
Done
Related details
Attention is currently required from:
- Andrey Kosyakov
- Bo Majewski
- David Dorwin
- Hiroki Nakagawa
- Mustafa Emre Acer
- Nate Fischer
David Dorwin (Gerrit)
May 28, 2026, 4:52:24 PM (2 days ago) May 28
to Hiroshige Hayashizaki, Nate Fischer, Arthur Sonzogni, Andrew Rayskiy, Monica Salama, Colin Blundell, Kouhei Ueno, Kenichi Ishibashi, Min Qin, Igor Ruvinov, Yao Xiao, Michael Thiessen, Andrey Kosyakov, Russ Hamilton, Bo Majewski, Ernest Nguyen Hung, Tim, Max Curran, Jinsuk Kim, Hiroki Nakagawa, Chrome Signin Team, Tsuyoshi Horo, Mustafa Emre Acer, Zijie He, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, prerendering-reviews, mac-r...@chromium.org, fuchsia...@chromium.org, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Andrey Kosyakov, Bo Majewski, Hiroki Nakagawa, Hiroshige Hayashizaki, Mustafa Emre Acer and Nate Fischer
David Dorwin voted and added 1 comment![]( "Open in Gerrit")
Votes added by David Dorwin
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Andrey Kosyakov
- Bo Majewski
- Hiroki Nakagawa
- Hiroshige Hayashizaki
- Mustafa Emre Acer
- Nate Fischer
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrey Kosyakov (Gerrit)
May 28, 2026, 7:17:58 PM (2 days ago) May 28
to Hiroshige Hayashizaki, David Dorwin, Nate Fischer, Arthur Sonzogni, Andrew Rayskiy, Monica Salama, Colin Blundell, Kouhei Ueno, Kenichi Ishibashi, Min Qin, Igor Ruvinov, Yao Xiao, Michael Thiessen, Russ Hamilton, Bo Majewski, Ernest Nguyen Hung, Tim, Max Curran, Jinsuk Kim, Hiroki Nakagawa, Chrome Signin Team, Tsuyoshi Horo, Mustafa Emre Acer, Zijie He, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, prerendering-reviews, mac-r...@chromium.org, fuchsia...@chromium.org, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Bo Majewski, Hiroki Nakagawa, Hiroshige Hayashizaki, Mustafa Emre Acer and Nate Fischer
Andrey Kosyakov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Andrey Kosyakov
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
Nate Fischer (Gerrit)
May 28, 2026, 8:58:53 PM (2 days ago) May 28
to Hiroshige Hayashizaki, Andrey Kosyakov, David Dorwin, Arthur Sonzogni, Andrew Rayskiy, Monica Salama, Colin Blundell, Kouhei Ueno, Kenichi Ishibashi, Min Qin, Igor Ruvinov, Yao Xiao, Michael Thiessen, Russ Hamilton, Bo Majewski, Ernest Nguyen Hung, Tim, Max Curran, Jinsuk Kim, Hiroki Nakagawa, Chrome Signin Team, Tsuyoshi Horo, Mustafa Emre Acer, Zijie He, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, prerendering-reviews, mac-r...@chromium.org, fuchsia...@chromium.org, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Bo Majewski, Hiroki Nakagawa, Hiroshige Hayashizaki and Mustafa Emre Acer
Nate Fischer voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Bo Majewski
- Hiroki Nakagawa
- Hiroshige Hayashizaki
- Mustafa Emre Acer
Submit Requirements:
Code-Coverage
Code-Owners
Hiroshige Hayashizaki (Gerrit)
May 28, 2026, 9:42:45 PM (2 days ago) May 28
to Nate Fischer, Andrey Kosyakov, David Dorwin, Arthur Sonzogni, Andrew Rayskiy, Monica Salama, Colin Blundell, Kouhei Ueno, Kenichi Ishibashi, Min Qin, Igor Ruvinov, Yao Xiao, Michael Thiessen, Russ Hamilton, Bo Majewski, Ernest Nguyen Hung, Tim, Max Curran, Jinsuk Kim, Hiroki Nakagawa, Chrome Signin Team, Tsuyoshi Horo, Mustafa Emre Acer, Zijie He, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, prerendering-reviews, mac-r...@chromium.org, fuchsia...@chromium.org, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Bo Majewski, Hiroki Nakagawa and Mustafa Emre Acer
Hiroshige Hayashizaki added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 9:
Hiroshige Hayashizaki . resolved
Hiroshige HayashizakiWDYT?
A specific alternative might be to define `FollowRedirectParams` that includes `new_url` + `HttpRequestHeadersUpdateParams`, while I don't have any specific reason to (or not to) do so.
(bot failures are due to recent addition of `FollowRedirect` overrides; I'll rebase/rerun later).
Proceeding to the current approach for now.
Related details
Attention is currently required from:
- Bo Majewski
- Hiroki Nakagawa
- Mustafa Emre Acer
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
Hiroki Nakagawa (Gerrit)
May 28, 2026, 9:49:35 PM (2 days ago) May 28
to Hiroshige Hayashizaki, Nate Fischer, Andrey Kosyakov, David Dorwin, Arthur Sonzogni, Andrew Rayskiy, Monica Salama, Colin Blundell, Kouhei Ueno, Kenichi Ishibashi, Min Qin, Igor Ruvinov, Yao Xiao, Michael Thiessen, Russ Hamilton, Bo Majewski, Ernest Nguyen Hung, Tim, Max Curran, Jinsuk Kim, Chrome Signin Team, Tsuyoshi Horo, Mustafa Emre Acer, Zijie He, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, prerendering-reviews, mac-r...@chromium.org, fuchsia...@chromium.org, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Bo Majewski, Hiroshige Hayashizaki and Mustafa Emre Acer
Hiroki Nakagawa voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Bo Majewski
- Hiroshige Hayashizaki
- Mustafa Emre Acer
Hiroshige Hayashizaki (Gerrit)
May 29, 2026, 3:56:59 PM (13 hours ago) May 29
to Hiroki Nakagawa, Nate Fischer, Andrey Kosyakov, David Dorwin, Arthur Sonzogni, Andrew Rayskiy, Monica Salama, Colin Blundell, Kouhei Ueno, Kenichi Ishibashi, Min Qin, Igor Ruvinov, Yao Xiao, Michael Thiessen, Russ Hamilton, Bo Majewski, Ernest Nguyen Hung, Tim, Max Curran, Jinsuk Kim, Chrome Signin Team, Tsuyoshi Horo, Mustafa Emre Acer, Zijie He, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, prerendering-reviews, mac-r...@chromium.org, fuchsia...@chromium.org, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Bo Majewski and Mustafa Emre Acer
Hiroshige Hayashizaki voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Bo Majewski
- Mustafa Emre Acer
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
May 29, 2026, 6:59:25 PM (10 hours ago) May 29
to Hiroshige Hayashizaki, Hiroki Nakagawa, Nate Fischer, Andrey Kosyakov, David Dorwin, Arthur Sonzogni, Andrew Rayskiy, Monica Salama, Colin Blundell, Kouhei Ueno, Kenichi Ishibashi, Min Qin, Igor Ruvinov, Yao Xiao, Michael Thiessen, Russ Hamilton, Bo Majewski, Ernest Nguyen Hung, Tim, Max Curran, Jinsuk Kim, Chrome Signin Team, Tsuyoshi Horo, Mustafa Emre Acer, Zijie He, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, prerendering-reviews, mac-r...@chromium.org, fuchsia...@chromium.org, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
40 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Use HttpRequestHeadersUpdateParams in mojom::URLLoader::FollowRedirect
Follow-up of https://crrev.com/c/7835601 that introduced
`network::HttpRequestHeadersUpdateParams`.
This CL uses `network.mojom.HttpRequestHeadersUpdateParams` (defined
in https://crrev.com/c/7869458) in
`network::mojom::URLLoader::FollowRedirect` in
`services/network/public/mojom/url_loader.mojom`, and adjust its
overrides accordingly.
### Purely mechanical changes (See Patch Set 35):
Replaces
```
FollowRedirect\(\s*
const std::vector<std::string>&\s*\w*,\s*
const (::)?net::HttpRequestHeaders&\s*\w*,\s*
const (::)?net::HttpRequestHeaders&\s*\w*,
```
with
```
FollowRedirect(
network::HttpRequestHeadersUpdateParams headers_update_params,
```
Replaces the followings (ignoring whitespaces):
```
FollowRedirect({}, {}, {}, std::nullopt)
FollowRedirect({}, {}, {}, {})
FollowRedirect(/*removed_headers=*/{},
/*modified_headers=*/{},
/*modified_cors_exempt_headers=*/{},
/*new_url=*/std::nullopt)
FollowRedirect(/*removed_headers=*/{},
/*modified_headers=*/{},
/*modified_cors_exempt_headers=*/{},
std::nullopt)
FollowRedirect(
std::vector<std::string>() /* sremoved_headers */,
net::HttpRequestHeaders() /* modified_headers */,
net::HttpRequestHeaders() /* smodified_cors_exempt_headers*/,
std::nullopt)
```
with
```
FollowRedirect(/*headers_update_params=*/{}, /*new_url=*/std::nullopt)
```
### Manual changes
Still mostly straightforward, with notable manual changes:
- `PrefetchURLLoader` has been intentionally dropped some of
`HttpRequestHeadersUpdateParams` since before. This CL has
additional lines to preserve the existing behavior:
- `content/browser/loader/prefetch_url_loader.cc`
- Before this CL, we had some copies just because `FollowRedirect()`
has been passing `const&` arguments. This CL removes the copies and
modifies the passed `headers_update_params` directly.
- `android_webview/browser/network_service/aw_proxying_url_loader_factory.cc`
- `chrome/browser/signin/chrome_signin_proxying_url_loader_factory.cc`
- `content/browser/loader/subresource_proxying_url_loader.cc`
- `services/network/cors/cors_url_loader.cc`
Bug: 511306597, 434292502
Change-Id: Ib3c70b9f986a543bdf93e7a97a9212a8a756a600
Reviewed-by: Colin Blundell <blun...@chromium.org>
Reviewed-by: Min Qin <qin...@chromium.org>
Reviewed-by: Tsuyoshi Horo <ho...@chromium.org>
Reviewed-by: Igor Ruvinov <igorr...@chromium.org>
Reviewed-by: David Dorwin <ddo...@chromium.org>
Reviewed-by: Tim <tjud...@chromium.org>
Reviewed-by: Michael Thiessen <mthi...@chromium.org>
Reviewed-by: Arthur Sonzogni <arthurs...@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiro...@chromium.org>
Reviewed-by: Kouhei Ueno <kou...@chromium.org>
Reviewed-by: Yao Xiao <yao...@chromium.org>
Reviewed-by: Kenichi Ishibashi <ba...@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhi...@chromium.org>
Reviewed-by: Andrew Rayskiy <green...@google.com>
Reviewed-by: Max Curran <curr...@chromium.org>
Reviewed-by: Russ Hamilton <beham...@google.com>
Reviewed-by: Monica Salama <msa...@chromium.org>
Reviewed-by: Andrey Kosyakov <ca...@chromium.org>
Reviewed-by: Ernest Nguyen Hung <er...@google.com>
Reviewed-by: Jinsuk Kim <jins...@chromium.org>
Reviewed-by: Nate Fischer <ntf...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1638790}
Files:
- M android_webview/browser/network_service/aw_proxying_url_loader_factory.cc
- M chrome/browser/ash/fileapi/external_file_url_loader_factory.cc
- M chrome/browser/contextual_tasks/contextual_tasks_url_loader_factory_interceptor.cc
- M chrome/browser/extensions/chrome_url_request_util.cc
- M chrome/browser/offline_pages/offline_page_url_loader.cc
- M chrome/browser/offline_pages/offline_page_url_loader.h
- M chrome/browser/plugins/plugin_response_interceptor_url_loader_throttle.cc
- M chrome/browser/preloading/prefetch/search_prefetch/cache_alias_search_prefetch_url_loader.cc
- M chrome/browser/preloading/prefetch/search_prefetch/cache_alias_search_prefetch_url_loader.h
- M chrome/browser/preloading/prefetch/search_prefetch/streaming_search_prefetch_url_loader.cc
- M chrome/browser/preloading/prefetch/search_prefetch/streaming_search_prefetch_url_loader.h
- M chrome/browser/signin/chrome_signin_proxying_url_loader_factory.cc
- M chrome/browser/ssl/https_upgrades_interceptor.h
- M components/download/internal/common/resource_downloader.cc
- M components/embedder_support/android/util/android_stream_reader_url_loader.cc
- M components/embedder_support/android/util/android_stream_reader_url_loader.h
- M components/enterprise/platform_auth/url_session_url_loader.h
- M components/enterprise/platform_auth/url_session_url_loader.mm
- M components/navigation_interception/intercept_navigation_delegate.cc
- M components/webapps/isolated_web_apps/url_loading/url_loader.cc
- M content/browser/android/content_url_loader_factory.cc
- M content/browser/browsing_topics/browsing_topics_url_loader_unittest.cc
- M content/browser/devtools/devtools_url_loader_interceptor.cc
- M content/browser/file_system/file_system_url_loader_factory.cc
- M content/browser/interest_group/ad_auction_url_loader_interceptor_unittest.cc
- M content/browser/loader/file_url_loader_factory.cc
- M content/browser/loader/keep_alive_url_loader.cc
- M content/browser/loader/keep_alive_url_loader.h
- M content/browser/loader/loader_browsertest.cc
- M content/browser/loader/prefetch_url_loader.cc
- M content/browser/loader/prefetch_url_loader.h
- M content/browser/loader/subresource_proxying_url_loader.cc
- M content/browser/loader/subresource_proxying_url_loader.h
- M content/browser/preloading/prefetch/prefetch_response_reader.cc
- M content/browser/preloading/prefetch/prefetch_response_reader.h
- M content/browser/preloading/prefetch/prefetch_streaming_url_loader.cc
- M content/browser/preloading/prefetch/prefetch_streaming_url_loader_unittest.cc
- M content/browser/service_worker/service_worker_browsertest.cc
- M content/browser/service_worker/service_worker_installed_script_loader.cc
- M content/browser/service_worker/service_worker_installed_script_loader.h
- M content/browser/service_worker/service_worker_main_resource_loader.cc
- M content/browser/service_worker/service_worker_main_resource_loader.h
- M content/browser/service_worker/service_worker_new_script_loader.cc
- M content/browser/service_worker/service_worker_new_script_loader.h
- M content/browser/service_worker/service_worker_updated_script_loader.cc
- M content/browser/service_worker/service_worker_updated_script_loader.h
- M content/browser/web_package/prefetched_signed_exchange_cache.cc
- M content/browser/web_package/signed_exchange_cert_fetcher_unittest.cc
- M content/browser/web_package/signed_exchange_inner_response_url_loader.cc
- M content/browser/web_package/signed_exchange_inner_response_url_loader.h
- M content/browser/web_package/signed_exchange_loader.cc
- M content/browser/web_package/signed_exchange_loader.h
- M content/browser/web_package/signed_exchange_loader_unittest.cc
- M content/browser/worker_host/worker_script_loader.cc
- M content/browser/worker_host/worker_script_loader.h
- M content/common/service_worker/forwarded_race_network_request_url_loader_factory.cc
- M content/common/service_worker/forwarded_race_network_request_url_loader_factory_unittest.cc
- M content/renderer/service_worker/service_worker_subresource_loader.cc
- M content/renderer/service_worker/service_worker_subresource_loader.h
- M content/renderer/service_worker/service_worker_subresource_loader_unittest.cc
- M extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc
- M extensions/browser/api/web_request/web_request_proxying_url_loader_factory.h
- M extensions/browser/extension_protocols.cc
- M extensions/renderer/extension_localization_throttle.cc
- M extensions/renderer/extension_localization_throttle_unittest.cc
- M fuchsia_web/webengine/browser/content_directory_loader_factory.cc
- M services/network/cors/cors_url_loader.cc
- M services/network/cors/cors_url_loader.h
- M services/network/cors/cors_url_loader_test_util.h
- M services/network/network_context_unittest.cc
- M services/network/network_service_unittest.cc
- M services/network/prefetch_url_loader_client_unittest.cc
- M services/network/public/cpp/content_decoding_interceptor.cc
- M services/network/public/cpp/content_decoding_interceptor_unittest.cc
- M services/network/public/cpp/simple_url_loader.cc
- M services/network/public/cpp/simple_url_loader_unittest.cc
- M services/network/public/mojom/url_loader.mojom
- M services/network/test/test_url_loader_factory.cc
- M services/network/test/test_url_loader_factory.h
- M services/network/url_loader.cc
- M services/network/url_loader.h
- M services/network/url_loader_unittest.cc
- M services/network/web_bundle/web_bundle_url_loader_factory.cc
- M storage/browser/blob/blob_url_loader.cc
- M storage/browser/blob/blob_url_loader.h
- M third_party/blink/common/loader/mime_sniffing_url_loader.cc
- M third_party/blink/common/loader/throttling_url_loader.cc
- M third_party/blink/common/loader/throttling_url_loader_unittest.cc
- M third_party/blink/public/common/loader/mime_sniffing_url_loader.h
- M third_party/blink/renderer/platform/loader/child_url_loader_factory_bundle.cc
- M third_party/blink/renderer/platform/loader/fetch/url_loader/background_url_loader_unittest.cc
- M third_party/blink/renderer/platform/loader/fetch/url_loader/resource_request_sender_unittest.cc
- M third_party/blink/renderer/platform/loader/fetch/url_loader/worker_main_script_loader_unittest.cc
Change size: L
Delta: 93 files changed, 324 insertions(+), 494 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Nate Fischer, +1 by Kouhei Ueno, +1 by Yao Xiao, +1 by Andrey Kosyakov, +1 by Colin Blundell, +1 by Andrew Rayskiy, +1 by David Dorwin, +1 by Arthur Sonzogni, +1 by Hiroki Nakagawa, +1 by Min Qin, +1 by Ernest Nguyen Hung, +1 by Michael Thiessen, +1 by Tsuyoshi Horo, +1 by Kenichi Ishibashi, +1 by Max Curran, +1 by Jinsuk Kim, +1 by Monica Salama, +1 by Tim, +1 by Igor Ruvinov, +1 by Russ Hamilton
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages