Remove chrome:: namespace for FindBrowserWithTab and path enums [chromium/src : main]

0 views
Skip to first unread message

Vishwa Kalubowila (Gerrit)

unread,
Apr 17, 2025, 6:53:42 AMApr 17
to Jimmy Gong, Alex Rudenko, chromium...@chromium.org, devtools...@chromium.org
Attention needed from Alex Rudenko and Jimmy Gong

Vishwa Kalubowila added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Vishwa Kalubowila . resolved

Hi ,
Could you please review this CL? .
Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Alex Rudenko
  • Jimmy Gong
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib85a45f69a1039d4971be938e92ba908043e09bd
Gerrit-Change-Number: 6468912
Gerrit-PatchSet: 1
Gerrit-Owner: Vishwa Kalubowila <vishwa.k...@codimite.com>
Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Jimmy Gong <jimmy...@chromium.org>
Gerrit-Attention: Alex Rudenko <alexr...@chromium.org>
Gerrit-Attention: Jimmy Gong <jimmy...@chromium.org>
Gerrit-Comment-Date: Thu, 17 Apr 2025 10:53:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Jan Keitel (Gerrit)

unread,
Apr 17, 2025, 7:19:41 AMApr 17
to Vishwa Kalubowila, Chromium LUCI CQ, David Roger, Jimmy Gong, Alex Rudenko, chromium...@chromium.org, devtools...@chromium.org
Attention needed from Alex Rudenko, David Roger, Jimmy Gong and Vishwa Kalubowila

Jan Keitel added 1 comment

File chrome/browser/ui/browser_finder.h
Line 210, Patchset 1 (Latest):namespace browser {
namespace ui {
Jan Keitel . unresolved

What's the motivation for doing this? I haven't seen anything like it and AFAIK code in `chrome` should by default live in the global namespace.

Open in Gerrit

Related details

Attention is currently required from:
  • Alex Rudenko
  • David Roger
  • Jimmy Gong
  • Vishwa Kalubowila
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib85a45f69a1039d4971be938e92ba908043e09bd
    Gerrit-Change-Number: 6468912
    Gerrit-PatchSet: 1
    Gerrit-Owner: Vishwa Kalubowila <vishwa.k...@codimite.com>
    Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
    Gerrit-Reviewer: David Roger <dro...@chromium.org>
    Gerrit-Reviewer: Jan Keitel <jke...@google.com>
    Gerrit-Reviewer: Jimmy Gong <jimmy...@chromium.org>
    Gerrit-Reviewer: Vishwa Kalubowila <vishwa.k...@codimite.com>
    Gerrit-Attention: Alex Rudenko <alexr...@chromium.org>
    Gerrit-Attention: Jimmy Gong <jimmy...@chromium.org>
    Gerrit-Attention: Vishwa Kalubowila <vishwa.k...@codimite.com>
    Gerrit-Attention: David Roger <dro...@chromium.org>
    Gerrit-Comment-Date: Thu, 17 Apr 2025 11:19:32 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Alex Rudenko (Gerrit)

    unread,
    Apr 22, 2025, 3:51:50 AMApr 22
    to Vishwa Kalubowila, Chromium LUCI CQ, David Roger, Jan Keitel, Jimmy Gong, chromium...@chromium.org, devtools...@chromium.org
    Attention needed from David Roger, Jimmy Gong and Vishwa Kalubowila

    Alex Rudenko voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • David Roger
    • Jimmy Gong
    • Vishwa Kalubowila
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib85a45f69a1039d4971be938e92ba908043e09bd
    Gerrit-Change-Number: 6468912
    Gerrit-PatchSet: 1
    Gerrit-Owner: Vishwa Kalubowila <vishwa.k...@codimite.com>
    Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
    Gerrit-Reviewer: David Roger <dro...@chromium.org>
    Gerrit-Reviewer: Jan Keitel <jke...@google.com>
    Gerrit-Reviewer: Jimmy Gong <jimmy...@chromium.org>
    Gerrit-Reviewer: Vishwa Kalubowila <vishwa.k...@codimite.com>
    Gerrit-Attention: Jimmy Gong <jimmy...@chromium.org>
    Gerrit-Attention: Vishwa Kalubowila <vishwa.k...@codimite.com>
    Gerrit-Attention: David Roger <dro...@chromium.org>
    Gerrit-Comment-Date: Tue, 22 Apr 2025 07:51:40 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Vishwa Kalubowila (Gerrit)

    unread,
    Nov 4, 2025, 1:07:33 AM (yesterday) Nov 4
    to Alex Rudenko, Chromium LUCI CQ, David Roger, Jan Keitel, Jimmy Gong, chromium...@chromium.org, devtools...@chromium.org
    Attention needed from Alex Rudenko, David Roger, Jan Keitel, Jimmy Gong and Vishwa Kalubowila

    Message from Vishwa Kalubowila

    Set Ready For Review

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Alex Rudenko
    • David Roger
    • Jan Keitel
    • Jimmy Gong
    • Vishwa Kalubowila
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib85a45f69a1039d4971be938e92ba908043e09bd
    Gerrit-Change-Number: 6468912
    Gerrit-PatchSet: 2
    Gerrit-Owner: Vishwa Kalubowila <vishwa.k...@codimite.com>
    Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
    Gerrit-Reviewer: David Roger <dro...@chromium.org>
    Gerrit-Reviewer: Jan Keitel <jke...@google.com>
    Gerrit-Reviewer: Jimmy Gong <jimmy...@chromium.org>
    Gerrit-Reviewer: Vishwa Kalubowila <vishwa.k...@codimite.com>
    Gerrit-Attention: David Roger <dro...@chromium.org>
    Gerrit-Attention: Jimmy Gong <jimmy...@chromium.org>
    Gerrit-Attention: Vishwa Kalubowila <vishwa.k...@codimite.com>
    Gerrit-Attention: Jan Keitel <jke...@google.com>
    Gerrit-Attention: Alex Rudenko <alexr...@chromium.org>
    Gerrit-Comment-Date: Tue, 04 Nov 2025 06:07:01 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Alex Rudenko (Gerrit)

    unread,
    Nov 4, 2025, 2:27:10 AM (yesterday) Nov 4
    to Vishwa Kalubowila, Chromium LUCI CQ, David Roger, Jan Keitel, Jimmy Gong, chromium...@chromium.org, devtools...@chromium.org
    Attention needed from David Roger, Jimmy Gong and Vishwa Kalubowila

    Alex Rudenko added 1 comment

    Patchset-level comments
    File-level comment, Patchset 3 (Latest):
    Alex Rudenko . resolved

    Have these concerns were resolved?https://crrev.com/c/6472403/comments/1da4c962_b2600f31?tab=comments it looks like there is a desire to keep the namespaces as is. Perhaps it's worth checking on the issue first if it's still desired to perform this refactoring.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • David Roger
    • Jimmy Gong
    • Vishwa Kalubowila
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib85a45f69a1039d4971be938e92ba908043e09bd
    Gerrit-Change-Number: 6468912
    Gerrit-PatchSet: 3
    Gerrit-Owner: Vishwa Kalubowila <vishwa.k...@codimite.com>
    Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
    Gerrit-Reviewer: David Roger <dro...@chromium.org>
    Gerrit-Reviewer: Jan Keitel <jke...@google.com>
    Gerrit-Reviewer: Jimmy Gong <jimmy...@chromium.org>
    Gerrit-Reviewer: Vishwa Kalubowila <vishwa.k...@codimite.com>
    Gerrit-Attention: David Roger <dro...@chromium.org>
    Gerrit-Attention: Jimmy Gong <jimmy...@chromium.org>
    Gerrit-Attention: Vishwa Kalubowila <vishwa.k...@codimite.com>
    Gerrit-Comment-Date: Tue, 04 Nov 2025 07:26:52 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    David Roger (Gerrit)

    unread,
    Nov 4, 2025, 9:41:49 AM (19 hours ago) Nov 4
    to Vishwa Kalubowila, Alex Rudenko, Chromium LUCI CQ, Jan Keitel, Jimmy Gong, chromium...@chromium.org, devtools...@chromium.org
    Attention needed from Jimmy Gong and Vishwa Kalubowila

    David Roger voted and added 1 comment

    Votes added by David Roger

    Commit-Queue+0

    1 comment

    Patchset-level comments
    David Roger . resolved

    There are conflict markers, please fix that.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Jimmy Gong
    • Vishwa Kalubowila
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib85a45f69a1039d4971be938e92ba908043e09bd
    Gerrit-Change-Number: 6468912
    Gerrit-PatchSet: 3
    Gerrit-Owner: Vishwa Kalubowila <vishwa.k...@codimite.com>
    Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
    Gerrit-Reviewer: David Roger <dro...@chromium.org>
    Gerrit-Reviewer: Jan Keitel <jke...@google.com>
    Gerrit-Reviewer: Jimmy Gong <jimmy...@chromium.org>
    Gerrit-Reviewer: Vishwa Kalubowila <vishwa.k...@codimite.com>
    Gerrit-Attention: Jimmy Gong <jimmy...@chromium.org>
    Gerrit-Attention: Vishwa Kalubowila <vishwa.k...@codimite.com>
    Gerrit-Comment-Date: Tue, 04 Nov 2025 14:41:32 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages