Add loading spinner and timer to teaser [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Samiya Caur (Gerrit)
Dec 2, 2025, 2:17:02 AMDec 2
to Ergün Erdoğmuş, devtools-rev...@chromium.org
Attention needed from Ergün Erdoğmuş
Samiya Caur voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Ergün Erdoğmuş
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ergün Erdoğmuş (Gerrit)
Dec 19, 2025, 8:14:46 AM (12 days ago) Dec 19
to Samiya Caur, Code Review Nudger, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Samiya Caur
Ergün Erdoğmuş voted and added 2 comments![]( "Open in Gerrit")
Votes added by Ergün Erdoğmuş
| Code-Review | +1 |
2 comments
Patchset-level comments
File front_end/panels/common/AiCodeGenerationTeaser.ts
Line 39, Patchset 8 (Latest):
const SPINNER_CHARS = ['⠋', '⠙', '⠹', '⠸', '⠼', '⠴', '⠦', '⠧', '⠇', '⠏'];Ergün Erdoğmuş . unresolved
As discussed offline, I think this can be implemented using a CSS animation and that'd remove some complexity from the implementation.
Related details
Attention is currently required from:
- Samiya Caur
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samiya Caur (Gerrit)
Dec 22, 2025, 6:38:27 AM (9 days ago) Dec 22
to Ergün Erdoğmuş, Code Review Nudger, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Ergün Erdoğmuş
Samiya Caur voted and added 1 comment![]( "Open in Gerrit")
Votes added by Samiya Caur
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
File front_end/panels/common/AiCodeGenerationTeaser.ts
Line 39, Patchset 8:
const SPINNER_CHARS = ['⠋', '⠙', '⠹', '⠸', '⠼', '⠴', '⠦', '⠧', '⠇', '⠏'];Ergün Erdoğmuş . resolved
As discussed offline, I think this can be implemented using a CSS animation and that'd remove some complexity from the implementation.
Attention is currently required from:
- Ergün Erdoğmuş
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ergün Erdoğmuş (Gerrit)
Dec 29, 2025, 6:24:04 AM (yesterday) Dec 29
to Samiya Caur, Code Review Nudger, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Samiya Caur
Ergün Erdoğmuş voted and added 1 comment![]( "Open in Gerrit")
Votes added by Ergün Erdoğmuş
| Code-Review | +1 |
1 comment
File front_end/panels/common/AiCodeGenerationTeaser.ts
Line 136, Patchset 11 (Latest):
if (this.#displayState === AiCodeGenerationTeaserDisplayState.LOADING) {Ergün Erdoğmuş . unresolved
Let's wait for the `updateComplete` in here to that it's linked to the update we're waiting exactly.
Related details
Attention is currently required from:
- Samiya Caur
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samiya Caur (Gerrit)
Dec 29, 2025, 9:15:22 AM (yesterday) Dec 29
to Ergün Erdoğmuş, Code Review Nudger, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Samiya Caur voted and added 1 comment![]( "Open in Gerrit")
Votes added by Samiya Caur
| Auto-Submit | +1 |
1 comment
File front_end/panels/common/AiCodeGenerationTeaser.ts
Line 136, Patchset 11:
if (this.#displayState === AiCodeGenerationTeaserDisplayState.LOADING) {Ergün Erdoğmuş . resolved
Let's wait for the `updateComplete` in here to that it's linked to the update we're waiting exactly.
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samiya Caur (Gerrit)
Dec 29, 2025, 9:15:27 AM (yesterday) Dec 29
to Ergün Erdoğmuş, Code Review Nudger, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Samiya Caur voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ergün Erdoğmuş (Gerrit)
6:07 AM (17 hours ago) 6:07 AM
to Samiya Caur, Code Review Nudger, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Samiya Caur
Ergün Erdoğmuş voted![]( "Open in Gerrit")
Attention is currently required from:
- Samiya Caur
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devtools-frontend LUCI CQ (Gerrit)
6:09 AM (17 hours ago) 6:09 AM
to Samiya Caur, Ergün Erdoğmuş, Code Review Nudger, devtools-rev...@chromium.org
Devtools-frontend LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Add loading spinner and timer to teaser
Bug: 448796757
Change-Id: I06a0cb2d95e4bc932394e8be23485a83b53498ba
Reviewed-by: Ergün Erdoğmuş <erg...@chromium.org>
Auto-Submit: Samiya Caur <sam...@chromium.org>
Commit-Queue: Ergün Erdoğmuş <erg...@chromium.org>
Files:
- M front_end/panels/common/AiCodeGenerationTeaser.test.ts
- M front_end/panels/common/AiCodeGenerationTeaser.ts
- M front_end/panels/common/aiCodeGenerationTeaser.css
- M front_end/ui/components/text_editor/AiCodeGenerationProvider.test.ts
Change size: M
Delta: 4 files changed, 137 insertions(+), 12 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Ergün Erdoğmuş
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages