[build] Load en-US.json at runtime in LocaleHelpers [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Nikolay Vitkov (Gerrit)
Oct 21, 2026, 5:27:47 AM (yesterday) Oct 21
to Victor Porof, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org
Attention needed from Victor Porof
Nikolay Vitkov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Nikolay Vitkov <nvi...@chromium.org>
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 5 (Latest):
Nikolay Vitkov . resolved
This should also speed up running a single test locally if it does not require the hook.
Related details
Attention is currently required from:
- Victor Porof
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Victor Porof (Gerrit)
2:55 AM (11 hours ago) 2:55 AM
to Nikolay Vitkov, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org
Victor Porof voted Commit-Queue+2 on change 8612248![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
3:22 AM (11 hours ago) 3:22 AM
to Victor Porof, Nikolay Vitkov, devtools-rev...@chromium.org
devtools-fro...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Unreviewed changes
5 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[build] Load en-US.json at runtime in LocaleHelpers
LocaleHelpers.ts imported ../core/i18n/locales/en-US.json statically,
and front_end/testing had deps on ../core/i18n/locales so that the type
check could read the generated 676 KB file. So each UI string edit ran
testing-dts and testing_checked again (~0.7 s).
Load en-US.json with import() and a non-literal specifier in
initializeGlobalLocaleVars(), and use data_deps in front_end/testing
again.
Results:
- Local build after a UI string edit: 23% faster on top of the other 4
CLs (1.75 s instead of 2.27 s, ~0.5 s less per build), and 12% faster
on its own (3.98 s instead of 4.52 s). The build runs 8–9 steps
instead of 10–11.
- All 5 CLs together: 61% faster after a UI string edit (1.75 s instead
of 4.52 s, ~2.8 s less per build), and 30% faster after a code edit
that keeps the public types (1.45 s instead of 2.08 s, ~0.6 s less).
- Reach: 9.6% of CLs in the last 6 months (344 of 3,575, without
autoroller CLs) changed a UI string.
Build times are median Siso times without the ~0.45 s startup, using
the caches of an earlier build.
Benchmark: go/chrome-devtools:ui-strings-build-benchmark
Bug: 576211357
Change-Id: I8535b9784c95372e65ca46eeddc49c1ef7eb3d65
TAG=agy
CONV=9b027603-1e83-4e14-b0df-c96b0b384de4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/8612248
Reviewed-by: Nikolay Vitkov <nvi...@chromium.org>
Commit-Queue: Victor Porof <victo...@chromium.org>
Files:
- M front_end/testing/BUILD.gn
- M front_end/testing/LocaleHelpers.ts
Change size: S
Delta: 2 files changed, 8 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Nikolay Vitkov
Review-Enforcement: Code-Review+1 by Nikolay Vitkov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages