[parser] Serialize context hoisting metadata in ScopeInfo [v8/v8 : main]
0 views
Skip to first unread message
Oscar García Pineda (Gerrit)
Mar 19, 2026, 8:42:23 AM (5 days ago) Mar 19
to Toon Verwaest, AyeAye, devtools-...@chromium.org, marja...@chromium.org, v8-re...@googlegroups.com
Attention needed from Toon Verwaest
Oscar García Pineda added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Toon Verwaest
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Toon Verwaest (Gerrit)
Mar 19, 2026, 8:59:12 AM (5 days ago) Mar 19
to Igor Sheludko, AyeAye, devtools-...@chromium.org, marja...@chromium.org, v8-re...@googlegroups.com
Attention needed from Igor Sheludko
Toon Verwaest added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Toon Verwaest . resolved
ptal, pre-work for https://chromium-review.git.corp.google.com/c/v8/v8/+/7679258
Related details
Attention is currently required from:
- Igor Sheludko
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Igor Sheludko (Gerrit)
5:49 AM (2 hours ago) 5:49 AM
to Toon Verwaest, Hannes Payer, V8 LUCI CQ, AyeAye, mlippau...@chromium.org, devtools-...@chromium.org, marja...@chromium.org, v8-re...@googlegroups.com
Attention needed from Toon Verwaest
Igor Sheludko voted and added 1 comment![]( "Open in Gerrit")
Votes added by Igor Sheludko
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Toon Verwaest
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Toon Verwaest (Gerrit)
6:22 AM (2 hours ago) 6:22 AM
to Igor Sheludko, Hannes Payer, V8 LUCI CQ, AyeAye, mlippau...@chromium.org, devtools-...@chromium.org, marja...@chromium.org, v8-re...@googlegroups.com
Toon Verwaest voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
7:00 AM (1 hour ago) 7:00 AM
to Toon Verwaest, Igor Sheludko, Hannes Payer, AyeAye, mlippau...@chromium.org, devtools-...@chromium.org, marja...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[parser] Serialize context hoisting metadata in ScopeInfo
Adds information whether a context/SFI is basically hoisted to the start of its outer context. This indicates the earliest position that variable references from within the context can access variables declared in the direct outer context.
Bug: 42203665
Change-Id: I05930b8b4e40c6cce183faf1e1c9cef6818f8042
Commit-Queue: Toon Verwaest <verw...@chromium.org>
Reviewed-by: Igor Sheludko <ish...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#105994}
Files:
- M src/ast/scopes.cc
- M src/ast/scopes.h
- M src/debug/liveedit.cc
- M src/diagnostics/objects-printer.cc
- M src/heap/setup-heap-internal.cc
- M src/objects/scope-info-inl.h
- M src/objects/scope-info.cc
- M src/objects/scope-info.h
- M src/objects/scope-info.tq
- M src/objects/shared-function-info-inl.h
- M src/objects/shared-function-info.cc
- M src/objects/shared-function-info.h
- M src/objects/shared-function-info.tq
- M src/parsing/parse-info.cc
- M src/parsing/parse-info.h
- M test/unittests/interpreter/bytecode-array-builder-unittest.cc
Change size: M
Delta: 16 files changed, 150 insertions(+), 42 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Igor Sheludko
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages