[autosizer] Delete the text autosizer [chromium/src : main]

[David Grogan (Gerrit)]

Attention needed from Ian Kilpatrick

David Grogan added 6 comments

Patchset-level comments

File-level comment, Patchset 12 (Latest):

David Grogan . resolved

Ian, you get first crack... apologies 😊

File content/browser/web_contents/web_contents_impl.cc

Line 4011, Patchset 1: // Not needed for larger form factors

David Grogan . resolved

ax

David Grogan

Done

Line 10811, Patchset 1 (Parent): // Set the TextAutosizer state from the main frame's renderer on the new view,

David Grogan . resolved

ax

David Grogan

Done

File third_party/blink/renderer/core/frame/settings_string_converter.h

Line 42, Patchset 1 (Parent):template <>

David Grogan . resolved

Put this back

David Grogan

Done

File third_party/blink/renderer/core/page/chrome_client.h

Line 122, Patchset 4:namespace mojom {

David Grogan . resolved

delete 4 lines

David Grogan

Done

File third_party/blink/web_tests/NeverFixTests

Line 1446, Patchset 1:# Tests that require the text autosizing setting.

David Grogan . resolved

Update comment

David Grogan

Done

Open in Gerrit

Related details

Attention is currently required from:

• Ian Kilpatrick

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I96fb17e87284037bfb25cdd57c9a59acb715537e

Gerrit-Change-Number: 7738023

Gerrit-PatchSet: 12

Gerrit-Owner: David Grogan <dgr...@chromium.org>

Gerrit-Reviewer: David Grogan <dgr...@chromium.org>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Daniel Cheng <dch...@chromium.org>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-Comment-Date: Thu, 09 Apr 2026 15:51:10 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: David Grogan <dgr...@chromium.org>

[Ian Kilpatrick (Gerrit)]

Attention needed from David Grogan

Ian Kilpatrick voted and added 10 comments

Votes added by Ian Kilpatrick

Code-Review

+1

10 comments

Patchset-level comments

File-level comment, Patchset 12 (Latest):

Ian Kilpatrick . resolved

lgtm!

File content/browser/site_per_process_layout_browsertest.cc

Line 1131, Patchset 12 (Latest):// frame width, that the browser is notified.

Ian Kilpatrick . unresolved

remove

File third_party/blink/renderer/core/inspector/dev_tools_emulator.cc

Line 32, Patchset 12 (Latest):} // namespace

Ian Kilpatrick . unresolved

remove anon namespace

Line 91, Patchset 12 (Latest):

Ian Kilpatrick . unresolved

remove

File third_party/blink/renderer/core/layout/layout_block.cc

Line 149, Patchset 12 (Parent):

Ian Kilpatrick . unresolved

.nit keep this newline for consistency

File third_party/blink/renderer/core/layout/layout_text.cc

Line 252, Patchset 12 (Parent):

Ian Kilpatrick . unresolved

.nit keep this newline for consistency

Line 1083, Patchset 12 (Parent):

Ian Kilpatrick . unresolved

.nit keep this newline for consistency

File third_party/blink/renderer/core/page/page.h

Line 714, Patchset 12 (Parent):

Ian Kilpatrick . unresolved

.nit keep this newline for consistency

Line 436, Patchset 12 (Parent):

Ian Kilpatrick . unresolved

.nit keep this newline for consistency

File third_party/blink/renderer/core/style/computed_style.cc

Line 2436, Patchset 12 (Latest):// TODO(dgrogan): Condense LineHeight() with LineHeightInternal().

Ian Kilpatrick . unresolved

This is easy to do if you want to do it in this patch, just remove:
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/css/css_properties.json5;l=4114;drc=89b1c909268cb81a98c534f65c5f902c1b7ab0ea

Open in Gerrit

Related details

Attention is currently required from:

• David Grogan

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I96fb17e87284037bfb25cdd57c9a59acb715537e

Gerrit-Change-Number: 7738023

Gerrit-PatchSet: 12

Gerrit-Owner: David Grogan <dgr...@chromium.org>

Gerrit-Reviewer: David Grogan <dgr...@chromium.org>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Daniel Cheng <dch...@chromium.org>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: David Grogan <dgr...@chromium.org>

Gerrit-Comment-Date: Thu, 09 Apr 2026 16:12:00 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[David Grogan (Gerrit)]

Attention needed from Ian Kilpatrick

David Grogan added 9 comments

File content/browser/site_per_process_layout_browsertest.cc

Line 1131, Patchset 12:// frame width, that the browser is notified.

Ian Kilpatrick . resolved

remove

David Grogan

Done

File third_party/blink/renderer/core/inspector/dev_tools_emulator.cc

Line 32, Patchset 12:} // namespace

Ian Kilpatrick . resolved

remove anon namespace

David Grogan

Done

Line 91, Patchset 12:

Ian Kilpatrick . resolved

remove

David Grogan

Done

File third_party/blink/renderer/core/layout/layout_block.cc

Line 149, Patchset 12 (Parent):

Ian Kilpatrick . resolved

.nit keep this newline for consistency

David Grogan

Done

File third_party/blink/renderer/core/layout/layout_text.cc

Line 252, Patchset 12 (Parent):

Ian Kilpatrick . resolved

.nit keep this newline for consistency

David Grogan

Done

Line 1083, Patchset 12 (Parent):

Ian Kilpatrick . resolved

.nit keep this newline for consistency

David Grogan

Done

File third_party/blink/renderer/core/page/page.h

Line 714, Patchset 12 (Parent):

Ian Kilpatrick . resolved

.nit keep this newline for consistency

David Grogan

Done

Line 436, Patchset 12 (Parent):

Ian Kilpatrick . resolved

.nit keep this newline for consistency

David Grogan

Done

File third_party/blink/renderer/core/style/computed_style.cc

Line 2436, Patchset 12:// TODO(dgrogan): Condense LineHeight() with LineHeightInternal().

Ian Kilpatrick . unresolved

This is easy to do if you want to do it in this patch, just remove:
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/css/css_properties.json5;l=4114;drc=89b1c909268cb81a98c534f65c5f902c1b7ab0ea

David Grogan

Ack -- I'll also remove references to `LineHeightInternal` and `SpecifiedLineHeight`. I still want to do it in follow-up, but if you want it removed in this CL, LMK and I'll make it so 😊

Open in Gerrit

Related details

Attention is currently required from:

• Ian Kilpatrick

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I96fb17e87284037bfb25cdd57c9a59acb715537e

Gerrit-Change-Number: 7738023

Gerrit-PatchSet: 13

Gerrit-Owner: David Grogan <dgr...@chromium.org>

Gerrit-Reviewer: David Grogan <dgr...@chromium.org>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Daniel Cheng <dch...@chromium.org>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-Comment-Date: Thu, 09 Apr 2026 18:34:07 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Ian Kilpatrick <ikilp...@chromium.org>

[Ian Kilpatrick (Gerrit)]

Attention needed from David Grogan

Ian Kilpatrick voted and added 1 comment

Votes added by Ian Kilpatrick

Code-Review

+1

1 comment

File third_party/blink/renderer/core/style/computed_style.cc

Line 2436, Patchset 12:// TODO(dgrogan): Condense LineHeight() with LineHeightInternal().

Ian Kilpatrick . resolved

This is easy to do if you want to do it in this patch, just remove:
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/css/css_properties.json5;l=4114;drc=89b1c909268cb81a98c534f65c5f902c1b7ab0ea

David Grogan

Ack -- I'll also remove references to `LineHeightInternal` and `SpecifiedLineHeight`. I still want to do it in follow-up, but if you want it removed in this CL, LMK and I'll make it so 😊

Ian Kilpatrick

Followup is good!

Open in Gerrit

Related details

Attention is currently required from:

• David Grogan

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I96fb17e87284037bfb25cdd57c9a59acb715537e

Gerrit-Change-Number: 7738023

Gerrit-PatchSet: 15

Gerrit-Owner: David Grogan <dgr...@chromium.org>

Gerrit-Reviewer: David Grogan <dgr...@chromium.org>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Daniel Cheng <dch...@chromium.org>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: David Grogan <dgr...@chromium.org>

Gerrit-Comment-Date: Thu, 09 Apr 2026 18:45:26 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: David Grogan <dgr...@chromium.org>

Comment-In-Reply-To: Ian Kilpatrick <ikilp...@chromium.org>

[David Grogan (Gerrit)]

Attention needed from Philip Rogers and Richard (Torne) Coles

David Grogan added 1 comment

Patchset-level comments

File-level comment, Patchset 17 (Latest):

David Grogan . resolved

+Torne for android_webview
+pdr for everything/anything

Open in Gerrit

Related details

Attention is currently required from:

• Philip Rogers
• Richard (Torne) Coles

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I96fb17e87284037bfb25cdd57c9a59acb715537e

Gerrit-Change-Number: 7738023

Gerrit-PatchSet: 17

Gerrit-Owner: David Grogan <dgr...@chromium.org>

Gerrit-Reviewer: David Grogan <dgr...@chromium.org>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-Reviewer: Philip Rogers <p...@chromium.org>

Gerrit-Reviewer: Richard (Torne) Coles <to...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Daniel Cheng <dch...@chromium.org>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Richard (Torne) Coles <to...@chromium.org>

Gerrit-Attention: Philip Rogers <p...@chromium.org>

Gerrit-Comment-Date: Thu, 09 Apr 2026 19:36:29 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Richard (Torne) Coles (Gerrit)]

Attention needed from David Grogan and Philip Rogers

Richard (Torne) Coles voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• David Grogan
• Philip Rogers

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I96fb17e87284037bfb25cdd57c9a59acb715537e

Gerrit-Change-Number: 7738023

Gerrit-PatchSet: 17

Gerrit-Owner: David Grogan <dgr...@chromium.org>

Gerrit-Reviewer: David Grogan <dgr...@chromium.org>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-Reviewer: Philip Rogers <p...@chromium.org>

Gerrit-Reviewer: Richard (Torne) Coles <to...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Daniel Cheng <dch...@chromium.org>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Philip Rogers <p...@chromium.org>

Gerrit-Attention: David Grogan <dgr...@chromium.org>

Gerrit-Comment-Date: Thu, 09 Apr 2026 19:44:32 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[David Grogan (Gerrit)]

Attention needed from Chromium IPC Reviews and Ian Kilpatrick

David Grogan added 1 comment

Patchset-level comments

File-level comment, Patchset 17 (Latest):

David Grogan . resolved

+chrome-ip...@google.com for mojom files

Open in Gerrit

Related details

Attention is currently required from:

• Chromium IPC Reviews
• Ian Kilpatrick

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I96fb17e87284037bfb25cdd57c9a59acb715537e

Gerrit-Change-Number: 7738023

Gerrit-PatchSet: 17

Gerrit-Owner: David Grogan <dgr...@chromium.org>

Gerrit-Reviewer: Chromium IPC Reviews <chrome-ip...@google.com>

Gerrit-Reviewer: David Grogan <dgr...@chromium.org>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-Reviewer: Richard (Torne) Coles <to...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Daniel Cheng <dch...@chromium.org>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-Attention: Chromium IPC Reviews <chrome-ip...@google.com>

Gerrit-Comment-Date: Fri, 10 Apr 2026 23:47:22 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[gwsq (Gerrit)]

Attention needed from Ian Kilpatrick and Will Harris

Message from gwsq

From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: w...@chromium.org

📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).

IPC reviewer(s): w...@chromium.org

Reviewer source(s):
w...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:

• Ian Kilpatrick
• Will Harris

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I96fb17e87284037bfb25cdd57c9a59acb715537e

Gerrit-Change-Number: 7738023

Gerrit-PatchSet: 17

Gerrit-Owner: David Grogan <dgr...@chromium.org>

Gerrit-Reviewer: David Grogan <dgr...@chromium.org>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-Reviewer: Richard (Torne) Coles <to...@chromium.org>

Gerrit-Reviewer: Will Harris <w...@chromium.org>

Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Daniel Cheng <dch...@chromium.org>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-Attention: Will Harris <w...@chromium.org>

Gerrit-Comment-Date: Sat, 11 Apr 2026 00:07:47 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

[Will Harris (Gerrit)]

Attention needed from David Grogan and Ian Kilpatrick

Will Harris voted and added 1 comment

Votes added by Will Harris

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 17 (Latest):

Will Harris . resolved

lgtm all the mojom and the mojo traits. I only looked at those files. they remove code, and so I trust the bots here to verify.

Open in Gerrit

Related details

Attention is currently required from:

• David Grogan
• Ian Kilpatrick

Gerrit-Attention: David Grogan <dgr...@chromium.org>

Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-Comment-Date: Sat, 11 Apr 2026 00:13:37 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[David Grogan (Gerrit)]

Attention needed from Ian Kilpatrick and Rakina Zata Amni

David Grogan added 1 comment

Patchset-level comments

File-level comment, Patchset 17 (Latest):

David Grogan . resolved

Rakina, can you review for content/ changes?

Open in Gerrit

Related details

Attention is currently required from:

• Ian Kilpatrick
• Rakina Zata Amni

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I96fb17e87284037bfb25cdd57c9a59acb715537e

Gerrit-Change-Number: 7738023

Gerrit-PatchSet: 17

Gerrit-Owner: David Grogan <dgr...@chromium.org>

Gerrit-Reviewer: David Grogan <dgr...@chromium.org>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>

Gerrit-Reviewer: Richard (Torne) Coles <to...@chromium.org>

Gerrit-Reviewer: Will Harris <w...@chromium.org>

Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Daniel Cheng <dch...@chromium.org>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>

Gerrit-Comment-Date: Sat, 11 Apr 2026 03:35:18 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[David Grogan (Gerrit)]

Attention needed from Ian Kilpatrick, James Cook and Rakina Zata Amni

David Grogan added 1 comment

Patchset-level comments

File-level comment, Patchset 17 (Latest):

David Grogan . resolved

jamescook@, could you review for chrome/browser/{chromeos,extensions} ?

Open in Gerrit

Related details

Attention is currently required from:

• Ian Kilpatrick
• James Cook
• Rakina Zata Amni

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I96fb17e87284037bfb25cdd57c9a59acb715537e

Gerrit-Change-Number: 7738023

Gerrit-PatchSet: 17

Gerrit-Owner: David Grogan <dgr...@chromium.org>

Gerrit-Reviewer: David Grogan <dgr...@chromium.org>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-Reviewer: James Cook <jame...@chromium.org>

Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>

Gerrit-Reviewer: Richard (Torne) Coles <to...@chromium.org>

Gerrit-Reviewer: Will Harris <w...@chromium.org>

Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Daniel Cheng <dch...@chromium.org>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-Attention: James Cook <jame...@chromium.org>

Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>

Gerrit-Comment-Date: Sat, 11 Apr 2026 03:43:39 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Rakina Zata Amni (Gerrit)]

Attention needed from David Grogan and James Cook

Rakina Zata Amni voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• David Grogan
• James Cook

Gerrit-Attention: David Grogan <dgr...@chromium.org>

Gerrit-Comment-Date: Mon, 13 Apr 2026 02:15:21 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[David Grogan (Gerrit)]

Attention needed from Chris Harrelson and James Cook

David Grogan added 1 comment

Patchset-level comments

File-level comment, Patchset 17 (Latest):

David Grogan . resolved

jamescook@, could you review for chrome/browser/{chromeos,extensions} ?

Open in Gerrit

Related details

Attention is currently required from:

• Chris Harrelson
• James Cook

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I96fb17e87284037bfb25cdd57c9a59acb715537e

Gerrit-Change-Number: 7738023

Gerrit-PatchSet: 17

Gerrit-Owner: David Grogan <dgr...@chromium.org>

Gerrit-Reviewer: Chris Harrelson <chri...@chromium.org>

Gerrit-Reviewer: David Grogan <dgr...@chromium.org>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-Reviewer: James Cook <jame...@chromium.org>

Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>

Gerrit-Reviewer: Richard (Torne) Coles <to...@chromium.org>

Gerrit-Reviewer: Will Harris <w...@chromium.org>

Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Daniel Cheng <dch...@chromium.org>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: chromiu...@luci-project-accounts.iam.gserviceaccount.com <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: gwsq

Gerrit-Attention: James Cook <jame...@chromium.org>

Gerrit-Attention: Chris Harrelson <chri...@chromium.org>

Gerrit-Comment-Date: Mon, 13 Apr 2026 15:17:14 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[David Grogan (Gerrit)]

Attention needed from Chris Harrelson and James Cook

David Grogan added 1 comment

Patchset-level comments

File-level comment, Patchset 17 (Latest):

David Grogan . resolved

Chris, could you review for

third_party/blink/public/common/web_preferences/web_preferences.h
third_party/blink/public/mojom/BUILD.gn
third_party/blink/public/web/web_settings.h

Gerrit-Comment-Date: Mon, 13 Apr 2026 15:18:22 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[James Cook (Gerrit)]

Attention needed from Chris Harrelson and David Grogan

James Cook voted and added 1 comment

Votes added by James Cook

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 17 (Latest):

James Cook . resolved

LGTM for chromeos and extensions

Open in Gerrit

Related details

Attention is currently required from:

• Chris Harrelson
• David Grogan

Gerrit-Attention: David Grogan <dgr...@chromium.org>

Gerrit-Attention: Chris Harrelson <chri...@chromium.org>

Gerrit-Comment-Date: Mon, 13 Apr 2026 17:24:02 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Chris Harrelson (Gerrit)]

Attention needed from David Grogan

Chris Harrelson voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• David Grogan

Submit Requirements:

• Code-Coverage
• Code-Owners

Gerrit-Comment-Date: Mon, 13 Apr 2026 17:39:30 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[David Grogan (Gerrit)]

David Grogan voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Gerrit-Comment-Date: Mon, 13 Apr 2026 18:11:46 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[chromium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)]

chromiu...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:

[autosizer] Delete the text autosizer

This patch is mostly straightforward and mechanical. There are a few
TODOs that might involve some actual refactoring that I didn't want to
combine with this mechanical patch.

`device_scale_adjustment` is also deleted in this patch because the
autosizer was the only thing that used it.

android_webview/browser/aw_settings.cc has some small manual changes.

I still need to delete all the layout tests. I skipped them here just to
keep the size of this patch sane, but will delete them in a follow-up.

Recent history of our autosizer turndown efforts:
* It has been fully disabled since 143 on Chrome in Dec 2025
* It has been fully disabled since 145 on WebView (approx Feb 17, 2026)
* Prior to that, it was disabled on 50% of WebView since Nov 2025.
* We've received 0 bug reports.
* UMA has 0 pages being autosized over the last month [0]

[0] Chrome --
http://uma/p/chrome/timeline_v2?sid=df0def83f99e03938b2c604beb6a9985
WebView --
http://uma/p/chrome/timeline_v2?sid=4a9f3e0fec8097333c1e9ca7ee338b18

Change-Id: I96fb17e87284037bfb25cdd57c9a59acb715537e

Include-Ci-Only-Tests: true

Bug: 391990606

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7738023

Reviewed-by: Richard (Torne) Coles <to...@chromium.org>

Reviewed-by: James Cook <jame...@chromium.org>

Reviewed-by: Chris Harrelson <chri...@chromium.org>

Reviewed-by: Will Harris <w...@chromium.org>

Reviewed-by: Rakina Zata Amni <rak...@chromium.org>

Reviewed-by: Ian Kilpatrick <ikilp...@chromium.org>

Commit-Queue: David Grogan <dgr...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1613866}

Files:

• M android_webview/browser/aw_settings.cc
• M android_webview/common/aw_feature_map.cc
• M android_webview/java/src/org/chromium/android_webview/common/ProductionSupportedFlagList.java
• M android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java
• M chrome/browser/about_flags.cc
• M chrome/browser/chromeos/tablet_mode/chrome_content_browser_client_tablet_mode_part.cc
• M chrome/browser/chromeos/tablet_mode/tablet_mode_page_behavior_browsertest.cc
• M chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc
• M chrome/browser/flag-metadata.json
• M chrome/browser/flag_descriptions.h
• M content/browser/preloading/prerender/prerender_browsertest.cc
• M content/browser/renderer_host/page_impl.cc
• M content/browser/renderer_host/page_impl.h
• M content/browser/renderer_host/render_frame_host_delegate.cc
• M content/browser/renderer_host/render_frame_host_impl.cc
• M content/browser/renderer_host/render_frame_host_impl.h
• M content/browser/site_per_process_layout_browsertest.cc
• M content/browser/web_contents/web_contents_impl.cc
• M content/browser/web_contents/web_contents_impl.h
• M content/common/DEPS
• M testing/buildbot/filters/ios.content_browsertests.filter
• M third_party/blink/common/features.cc
• M third_party/blink/common/web_preferences/web_preferences_mojom_traits.cc
• M third_party/blink/public/common/features.h
• M third_party/blink/public/common/web_preferences/web_preferences.h
• M third_party/blink/public/common/web_preferences/web_preferences_mojom_traits.h
• M third_party/blink/public/mojom/BUILD.gn
• M third_party/blink/public/mojom/frame/frame.mojom
• M third_party/blink/public/mojom/frame/remote_frame.mojom
• D third_party/blink/public/mojom/frame/text_autosizer_page_info.mojom
• M third_party/blink/public/mojom/use_counter/metrics/web_feature.mojom
• M third_party/blink/public/mojom/webpreferences/web_preferences.mojom
• M third_party/blink/public/web/web_settings.h
• M third_party/blink/renderer/core/css/document_style_environment_variables.cc
• M third_party/blink/renderer/core/css/resolver/font_builder.cc
• M third_party/blink/renderer/core/css/resolver/matched_properties_cache.cc
• M third_party/blink/renderer/core/css/resolver/style_cascade_test.cc
• M third_party/blink/renderer/core/css/resolver/style_resolver.cc
• M third_party/blink/renderer/core/css/resolver/style_resolver_state.h
• M third_party/blink/renderer/core/dom/document.cc
• M third_party/blink/renderer/core/dom/document.h
• M third_party/blink/renderer/core/editing/commands/replace_selection_command_test.cc
• M third_party/blink/renderer/core/editing/finder/text_finder.cc
• M third_party/blink/renderer/core/editing/finder/text_finder_test.cc
• M third_party/blink/renderer/core/exported/web_settings_impl.cc
• M third_party/blink/renderer/core/exported/web_settings_impl.h
• M third_party/blink/renderer/core/exported/web_view_impl.cc
• M third_party/blink/renderer/core/exported/web_view_impl.h
• M third_party/blink/renderer/core/exported/web_view_impl_test.cc
• M third_party/blink/renderer/core/frame/local_frame.cc
• M third_party/blink/renderer/core/frame/local_frame_view.cc
• M third_party/blink/renderer/core/frame/remote_frame.cc
• M third_party/blink/renderer/core/frame/remote_frame.h
• M third_party/blink/renderer/core/frame/settings.json5
• M third_party/blink/renderer/core/frame/settings_delegate.h
• M third_party/blink/renderer/core/frame/settings_string_converter.h
• M third_party/blink/renderer/core/frame/web_frame_test.cc
• M third_party/blink/renderer/core/inspector/dev_tools_emulator.cc
• M third_party/blink/renderer/core/inspector/dev_tools_emulator.h
• M third_party/blink/renderer/core/layout/block_node.cc
• M third_party/blink/renderer/core/layout/build.gni
• M third_party/blink/renderer/core/layout/column_layout_algorithm.cc
• M third_party/blink/renderer/core/layout/layout_block.cc
• M third_party/blink/renderer/core/layout/layout_block_flow.cc
• M third_party/blink/renderer/core/layout/layout_inline.cc
• M third_party/blink/renderer/core/layout/layout_text.cc
• M third_party/blink/renderer/core/layout/table/table_layout_algorithm.cc
• D third_party/blink/renderer/core/layout/text_autosizer.cc
• D third_party/blink/renderer/core/layout/text_autosizer.h
• D third_party/blink/renderer/core/layout/text_autosizer_test.cc
• M third_party/blink/renderer/core/mobile_metrics/mobile_friendliness_checker_test.cc
• M third_party/blink/renderer/core/mobile_metrics/tap_friendliness_checker_test.cc
• M third_party/blink/renderer/core/page/chrome_client.h
• M third_party/blink/renderer/core/page/chrome_client_impl.cc
• M third_party/blink/renderer/core/page/chrome_client_impl.h
• M third_party/blink/renderer/core/page/page.cc
• M third_party/blink/renderer/core/page/page.h
• M third_party/blink/renderer/core/style/computed_style.cc
• M third_party/blink/renderer/core/style/computed_style.h
• M third_party/blink/renderer/core/style/computed_style_extra_fields.json5
• M third_party/blink/renderer/core/testing/internal_settings.cc
• M third_party/blink/renderer/core/testing/internal_settings.h
• M third_party/blink/renderer/core/testing/internal_settings.idl
• M third_party/blink/web_tests/FlagExpectations/highdpi
• M third_party/blink/web_tests/NeverFixTests
• M third_party/blink/web_tests/TestExpectations
• M third_party/blink/web_tests/VirtualTestSuites
• D third_party/blink/web_tests/virtual/text-autosizing/README.md
• M tools/metrics/histograms/metadata/blink/enums.xml

Change size: XL

Delta: 89 files changed, 43 insertions(+), 4687 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by James Cook, +1 by Ian Kilpatrick, +1 by Chris Harrelson, +1 by Rakina Zata Amni, +1 by Richard (Torne) Coles, +1 by Will Harris

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I96fb17e87284037bfb25cdd57c9a59acb715537e

Gerrit-Change-Number: 7738023

Gerrit-PatchSet: 18

Gerrit-Owner: David Grogan <dgr...@chromium.org>

Gerrit-Reviewer: Chris Harrelson <chri...@chromium.org>

Gerrit-Reviewer: David Grogan <dgr...@chromium.org>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-Reviewer: James Cook <jame...@chromium.org>

Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>

Gerrit-Reviewer: Richard (Torne) Coles <to...@chromium.org>

Gerrit-Reviewer: Will Harris <w...@chromium.org>

Gerrit-Reviewer: chromiu...@luci-project-accounts.iam.gserviceaccount.com <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Daniel Cheng <dch...@chromium.org>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

[Elliott Sprehn (Gerrit)]

Elliott Sprehn added 1 comment

Patchset-level comments

File-level comment, Patchset 18 (Latest):

Elliott Sprehn . resolved

For posterity here's the original design doc (in case the short url goes away). You could add that link to the commit message.

https://docs.google.com/document/d/1PPcEwAhXJJ1TQShor29KWB17KJJq7UJOM34oHwYP3Zg/edit?pli=1&tab=t.0#heading=h.kzw6s3kvr392

Amazing to see this finally removed! The web has changed so much in 12 years. 😊

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I96fb17e87284037bfb25cdd57c9a59acb715537e

Gerrit-Change-Number: 7738023

Gerrit-PatchSet: 18

Gerrit-Owner: David Grogan <dgr...@chromium.org>

Gerrit-Reviewer: Chris Harrelson <chri...@chromium.org>

Gerrit-Reviewer: David Grogan <dgr...@chromium.org>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-Reviewer: James Cook <jame...@chromium.org>

Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>

Gerrit-Reviewer: Richard Coles <to...@chromium.org>

Gerrit-Reviewer: Will Harris <w...@chromium.org>

Gerrit-Reviewer: chromiu...@luci-project-accounts.iam.gserviceaccount.com <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Daniel Cheng <dch...@chromium.org>

Gerrit-CC: Elliott Sprehn <esp...@chromium.org>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-Comment-Date: Tue, 14 Apr 2026 17:01:15 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No