[SDK] Use context-based settings in ServiceWorkerManager... [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Simon Zünd (Gerrit)
3:25 AM (2 hours ago) 3:25 AM
to Kim-Anh Tran, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Kim-Anh Tran
Simon Zünd added 1 comment![]( "Open in Gerrit")
File front_end/core/sdk/TargetManager.test.ts
Line 79, Patchset 4 (Latest):
context.set(Common.Settings.Settings, Common.Settings.Settings.instance());Simon Zünd . resolved
FYI, the `TestUniverse` handles this automagically, but here we want to explicitly check the `TargetManager` constructor so we do things manually here.
Related details
Attention is currently required from:
- Kim-Anh Tran
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kim-Anh Tran (Gerrit)
4:01 AM (2 hours ago) 4:01 AM
to Simon Zünd, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Simon Zünd
Kim-Anh Tran voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Simon Zünd
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Simon Zünd (Gerrit)
4:03 AM (2 hours ago) 4:03 AM
to Kim-Anh Tran, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Simon Zünd voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devtools-frontend LUCI CQ (Gerrit)
4:05 AM (2 hours ago) 4:05 AM
to Simon Zünd, Kim-Anh Tran, devtools-rev...@chromium.org
Devtools-frontend LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[SDK] Use context-based settings in ServiceWorkerManager...
...and RuntimeModel
Bug: 493760728
Change-Id: Iedbf0077c0679088e38f8e90b96f0118f7715316
Commit-Queue: Simon Zünd <szu...@chromium.org>
Reviewed-by: Kim-Anh Tran <kim...@chromium.org>
Files:
- M front_end/core/sdk/RuntimeModel.ts
- M front_end/core/sdk/ServiceWorkerManager.ts
- M front_end/core/sdk/TargetManager.test.ts
Change size: S
Delta: 3 files changed, 13 insertions(+), 9 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Kim-Anh Tran
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages