Allow Non-Ordinary Pages to have appropriate color provider [chromium/src : main]
0 views
Skip to first unread message
Sam Davis Omekara (Gerrit)
Jun 26, 2024, 1:28:30 PM (4 days ago) Jun 26
to Daniel Cheng, Tricium, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Stephen Chenney, blink-...@chromium.org, devtools-re...@chromium.org, fmalit...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org
Attention needed from Daniel Cheng
Sam Davis Omekara added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Daniel Cheng
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Cheng (Gerrit)
Jun 26, 2024, 11:04:45 PM (3 days ago) Jun 26
to Sam Davis Omekara, Daniel Cheng, Tricium, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Stephen Chenney, blink-...@chromium.org, devtools-re...@chromium.org, fmalit...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org
Attention needed from Sam Davis Omekara
Daniel Cheng added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/core/page/page.h
Line 186, Patchset 2 (Latest):
color_provider_colors_ = color_provider_colors;Daniel Cheng . unresolved
If `ColorProviderColorMaps` is movable, please use std::move() here.
Otherwise, please pass by const ref and only incur one copy.
Related details
Attention is currently required from:
- Sam Davis Omekara
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sam Davis Omekara (Gerrit)
Jun 27, 2024, 12:09:55 PM (3 days ago) Jun 27
to Daniel Cheng, Tricium, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Stephen Chenney, blink-...@chromium.org, devtools-re...@chromium.org, fmalit...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org
Attention needed from Daniel Cheng
Sam Davis Omekara added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/core/page/page.h
If `ColorProviderColorMaps` is movable, please use std::move() here.
Otherwise, please pass by const ref and only incur one copy.
Attention is currently required from:
- Daniel Cheng
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Cheng (Gerrit)
Jun 27, 2024, 3:03:01 PM (3 days ago) Jun 27
to Sam Davis Omekara, Daniel Cheng, Tricium, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Stephen Chenney, blink-...@chromium.org, devtools-re...@chromium.org, fmalit...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org
Attention needed from Sam Davis Omekara
Daniel Cheng voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Sam Davis Omekara
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sam Davis Omekara (Gerrit)
Jun 27, 2024, 4:17:02 PM (3 days ago) Jun 27
to Alison Maher, Daniel Cheng, Tricium, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Stephen Chenney, blink-...@chromium.org, devtools-re...@chromium.org, fmalit...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org
Sam Davis Omekara added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Sam Davis Omekara . resolved
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sam Davis Omekara (Gerrit)
Jun 27, 2024, 4:17:09 PM (3 days ago) Jun 27
to Alison Maher, Daniel Cheng, Tricium, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Stephen Chenney, blink-...@chromium.org, devtools-re...@chromium.org, fmalit...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org
Sam Davis Omekara voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 27, 2024, 4:30:03 PM (3 days ago) Jun 27
to Sam Davis Omekara, Alison Maher, Daniel Cheng, Tricium, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Stephen Chenney, blink-...@chromium.org, devtools-re...@chromium.org, fmalit...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Allow Non-Ordinary Pages to have appropriate color provider
This change addresses an issue where non-ordinary pages did not have
accurate color providers. The problem arose because color providers
created for pages spawned via Page::CreateNonOrdinary used default
colors instead of the system colors calculated from the browser
process. As a result, some popups and scrollbars displayed incorrect
colors.
To resolve this, the change caches the color provider colors in the
Page class. The cached colors are then used to obtain the main
page’s colors and are passed down to create color providers for
non-ordinary pages when a main page is present. This approach is
similar to how web settings are handled for non-ordinary pages.
Bug: 345611805, 339171218
Change-Id: I2c53930565e8d9ec89891cc378a67e2f8bc87363
Reviewed-by: Daniel Cheng <dch...@chromium.org>
Commit-Queue: Sam Davis Omekara <samome...@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1320600}
Files:
- M third_party/blink/renderer/controller/highest_pmf_reporter_test.cc
- M third_party/blink/renderer/core/editing/serializers/serialization.cc
- M third_party/blink/renderer/core/exported/web_page_popup_impl.cc
- M third_party/blink/renderer/core/inspector/inspector_overlay_agent.cc
- M third_party/blink/renderer/core/page/page.cc
- M third_party/blink/renderer/core/page/page.h
- M third_party/blink/renderer/core/page/page_test.cc
- M third_party/blink/renderer/core/page/validation_message_overlay_delegate.cc
- M third_party/blink/renderer/core/svg/graphics/isolated_svg_document_host.cc
- M third_party/blink/renderer/core/testing/dummy_page_holder.cc
Change size: M
Delta: 10 files changed, 47 insertions(+), 16 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Daniel Cheng
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages