Implement per resource limit in DevTools Durable Messages [chromium/src : main]

0 views
Skip to first unread message

Andrey Kosyakov (Gerrit)

unread,
Oct 13, 2025, 5:45:04 PM (9 hours ago) Oct 13
to Alex N. Jose, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, ipc-securi...@chromium.org, network-ser...@chromium.org
Attention needed from Alex N. Jose

Andrey Kosyakov voted and added 2 comments

Votes added by Andrey Kosyakov

Code-Review+1

2 comments

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Andrey Kosyakov . unresolved

Perhaps add some tests that cover hitting the per-resource limit? Otherwise lgtm.

File services/network/devtools_durable_msg_collector.cc
Line 99, Patchset 4 (Latest): // The message being called with is now evicted, and remaining bytes
Andrey Kosyakov . unresolved

"The message that the bytes are added to is now ..."

Open in Gerrit

Related details

Attention is currently required from:
  • Alex N. Jose
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I40b0913f2f848bba260dcf81864b275196dc7f90
Gerrit-Change-Number: 6898420
Gerrit-PatchSet: 4
Gerrit-Owner: Alex N. Jose <ale...@chromium.org>
Gerrit-Reviewer: Alex N. Jose <ale...@chromium.org>
Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Attention: Alex N. Jose <ale...@chromium.org>
Gerrit-Comment-Date: Mon, 13 Oct 2025 21:44:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages