Hiding irrelevant controls for standalone mode [devtools/devtools-frontend : main]
Vidal Diazleal (Gerrit)
Vidal Diazleal added 1 comment![]( "Open in Gerrit")
Hi Connor,
Here is the CL for next section in the backlog "[UX] Hide irrelevant controls". I'm not sure how the "canRecord" implementation will look like, but my educated guess is that solution will be tied to the target itself, so I moved it to the TargetManager instead so that it is available in the other tools, let me know any thoughts on this, and as always thank you for the help reviewing this.
Related details
- Connor Clark
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Connor Clark (Gerrit)
Connor Clark added 1 comment![]( "Open in Gerrit")
paul updated the "canRecord" signal and added "hasFakeConnection" to Target, that should work for this now.
Related details
- Vidal Diazleal
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Connor Clark (Gerrit)
Connor Clark added 1 comment![]( "Open in Gerrit")
paul updated the "canRecord" signal and added "hasFakeConnection" to Target, that should work for this now.
(just need to rebase)
Related details
- Vidal Diazleal
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Connor Clark (Gerrit)
Connor Clark added 1 comment![]( "Open in Gerrit")
control Devtools'please fix formatting of list
Related details
- Vidal Diazleal
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Connor Clark (Gerrit)
Connor Clark added 1 comment![]( "Open in Gerrit")
Performance Panel: Hiding 'Load Trace' button.
Paul actually convinced me that we should not hide the load trace button (it would be problematic for trace.cafe). Can you revert this change please?
Related details
- Vidal Diazleal
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vidal Diazleal (Gerrit)
Vidal Diazleal added 2 comments![]( "Open in Gerrit")
Connor Clarkpaul updated the "canRecord" signal and added "hasFakeConnection" to Target, that should work for this now.
(just need to rebase)
Done
Hi Connor
I did a rebase on the branch to include this code
6943527: RPP: Reland hiding irrelevant buttons in standalone usages | https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6943527
But the results are flaky to me, sometimes I see the controls being hidden and sometimes they don't. I did some debugging and a found couple of exceptions on main branch due to the recent changes introduced (details below), not sure if they related to my issue, but wanted to give and update and hear any thoughts you might have.
Related details
- Connor Clark
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paul Irish (Gerrit)
Paul Irish added 1 comment![]( "Open in Gerrit")
Hi Connor
I did a rebase on the branch to include this code
6943527: RPP: Reland hiding irrelevant buttons in standalone usages | https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6943527But the results are flaky to me, sometimes I see the controls being hidden and sometimes they don't. I did some debugging and a found couple of exceptions on main branch due to the recent changes introduced (details below), not sure if they related to my issue, but wanted to give and update and hear any thoughts you might have.
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6976658 should fix the flakiness.
The exceptions I'm less sure about.
I have personally seen something like the URL parsing errors because an undefined `url` or `sourceURL` is making its way into SDK.Script. (But yours looks different).
Maximum callstack is unexpected. I removed a rAF and perhaps that's playing a role. Can you email me the enhanced trace file you're testing with?
Related details
- Connor Clark
- Vidal Diazleal
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |