[GreenDevFloaty]: Remove Mac-specific handling of CreateDialogWidget. [chromium/src : main]

0 views

Skip to first unread message

Alex Rudenko (Gerrit)

unread,

5:22 AM (7 hours ago) 5:22 AM

to Finnur Thorarinsson, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org

Attention needed from Finnur Thorarinsson

Alex Rudenko voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Finnur Thorarinsson

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

6:03 AM (6 hours ago) 6:03 AM

to Finnur Thorarinsson, Alex Rudenko, chromium...@chromium.org, devtools...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

[GreenDevFloaty]: Remove Mac-specific handling of CreateDialogWidget.

I put in a hack to get around a compilation issue on Mac, caused by
passing in nullptr for the native_view, which other platforms didn't
complain about. Passing in gfx::NativeView() instead of the nullptr
avoids the build error.

Bug: 482495837, 466071312

Change-Id: I26d7051f9c51d39d87ee30b048ef785580b52588

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7562249

Commit-Queue: Finnur Thorarinsson <fin...@chromium.org>

Commit-Queue: Alex Rudenko <alexr...@chromium.org>

Auto-Submit: Finnur Thorarinsson <fin...@chromium.org>

Reviewed-by: Alex Rudenko <alexr...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1582401}

Files:

M chrome/browser/devtools/views/devtools_floaty.cc

Change size: XS

Delta: 1 file changed, 1 insertion(+), 8 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Alex Rudenko

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages