RPP: Wrap & position the popover to stop it overflowing the viewport [devtools/devtools-frontend : main]

0 views

Skip to first unread message

Jack Franklin (Gerrit)

unread,

Jul 3, 2026, 6:31:23 AM (yesterday) Jul 3

to Alina Varkki, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org

Attention needed from Alina Varkki

Jack Franklin voted and added 1 comment

Votes added by Jack Franklin

Auto-Submit

1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Jack Franklin . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:

Alina Varkki

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alina Varkki (Gerrit)

unread,

Jul 3, 2026, 9:30:06 AM (yesterday) Jul 3

to Jack Franklin, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org

Attention needed from Jack Franklin

Alina Varkki voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Jack Franklin

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,

Jul 3, 2026, 9:32:10 AM (yesterday) Jul 3

to Jack Franklin, Alina Varkki, devtools-rev...@chromium.org

devtools-fro...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:

RPP: Wrap & position the popover to stop it overflowing the viewport

Allow long URL origins in the flamechart popover to wrap and break
lines. This prevents the popover from overflowing the canvas or becoming
excessively wide.

Fixed: 530575918

Change-Id: Ic28f1b9252aa690b358d446d32e8d135fa0b48aa

Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/8034026

Auto-Submit: Jack Franklin <jacktf...@chromium.org>

Commit-Queue: Alina Varkki <alina...@chromium.org>

Reviewed-by: Alina Varkki <alina...@chromium.org>

Files:

M front_end/panels/timeline/timelineFlamechartPopover.css
M front_end/ui/legacy/components/perf_ui/FlameChart.test.ts
M front_end/ui/legacy/components/perf_ui/FlameChart.ts

Change size: M

Delta: 3 files changed, 164 insertions(+), 33 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Alina Varkki

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages